diff --git a/apps/web/playwright/fixtures/users.ts b/apps/web/playwright/fixtures/users.ts index d7150cf16e..26a4488d3c 100644 --- a/apps/web/playwright/fixtures/users.ts +++ b/apps/web/playwright/fixtures/users.ts @@ -153,6 +153,7 @@ const createTeamAndAddUser = async ( isDnsSetup, index, orgRequestedSlug, + schedulingType, }: { user: { id: number; email: string; username: string | null; role?: MembershipRole }; isUnpublished?: boolean; @@ -163,6 +164,7 @@ const createTeamAndAddUser = async ( organizationId?: number | null; index?: number; orgRequestedSlug?: string; + schedulingType?: SchedulingType; }, workerInfo: WorkerInfo ) => { @@ -189,7 +191,9 @@ const createTeamAndAddUser = async ( data.slug = !isUnpublished ? slug : undefined; if (isOrg && hasSubteam) { const team = await createTeamAndAddUser({ user }, workerInfo); - await createTeamEventType(user, team); + await createTeamEventType(user, team, { + schedulingType: schedulingType, + }); await createTeamWorkflow(user, team); data.children = { connect: [{ id: team.id }] }; } @@ -532,6 +536,7 @@ export const createUsersFixture = ( hasSubteam: scenario.hasSubteam, organizationId: opts?.organizationId, orgRequestedSlug: scenario.orgRequestedSlug, + schedulingType: scenario.schedulingType, }, workerInfo ); diff --git a/packages/app-store/routing-forms/TODO.md b/packages/app-store/routing-forms/TODO.md index e7ce90225f..0fee3b24fc 100644 --- a/packages/app-store/routing-forms/TODO.md +++ b/packages/app-store/routing-forms/TODO.md @@ -13,6 +13,7 @@ - [ ] Warnings are needed with recommendation to create new attribute instead in unsupported scenarios. We need to test for more such changes to Attribute types. - [ ] When choosing 'Value of Field' option in RAQB, show a warning somewhere if all options of the Form field aren't present in the attribute option. - So, if Form Field is 'What is Comapny Size' with options Enterprise, Large, Medium, Small and Attribute for which Value of 'What is compnay size' has options Enterprise, Large, Medium. It would show a warning that 'Small' option is not present in the attribute. +- [ ] When logic can't be built(Short text maps to an attribute with given set of options but the short text value doesn't match any of the options), the team member matching route throws error but Test Preview still shows the previous value - It show should the error in there. ### Performance Tests and Improvements - [ ] Test with ~1000 team members and ~100 attributes. @@ -30,7 +31,7 @@ - [x] Basic Tests - [ ] getAttributes - [ ] Querying Logic Test -- [ ] getRoutedUsers tests +- [x] getRoutedUsers tests - [ ] getAvailableSlots - [ ] should use routedTeamMemberIds in availability query diff --git a/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx b/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx index 1a1bfcf506..15c90a6e03 100644 --- a/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx +++ b/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx @@ -444,6 +444,7 @@ const Route = ({