From 24635af7301af29d28ab1c08507cd4b14a73b7bb Mon Sep 17 00:00:00 2001 From: Hariom Balhara Date: Sat, 24 Sep 2022 14:10:49 +0530 Subject: [PATCH] Hotfix: Be more strict with safeRedirectUrl check (#4675) * Be more strict * Apply suggestions from code review Co-authored-by: Alex van Andel --- packages/lib/getSafeRedirectUrl.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/lib/getSafeRedirectUrl.ts b/packages/lib/getSafeRedirectUrl.ts index 20d87d3e4a..1ddf4acced 100644 --- a/packages/lib/getSafeRedirectUrl.ts +++ b/packages/lib/getSafeRedirectUrl.ts @@ -9,8 +9,10 @@ export const getSafeRedirectUrl = (url = "") => { throw new Error("Pass an absolute URL"); } + const urlParsed = new URL(url); + // Avoid open redirection security vulnerability - if (![CONSOLE_URL, WEBAPP_URL, WEBSITE_URL].some((u) => url.startsWith(u))) { + if (![CONSOLE_URL, WEBAPP_URL, WEBSITE_URL].some((u) => new URL(u).origin === urlParsed.origin)) { url = `${WEBAPP_URL}/`; }