From 309340d3f3b8ee22cda24c9298b8d9f0b9bdadaf Mon Sep 17 00:00:00 2001 From: Volnei Munhoz Date: Sun, 28 Dec 2025 21:29:44 -0300 Subject: [PATCH] fix: add missing peer dependencies and fix inconsistent peer dependency declarations (#26244) * fix: add missing peer dependencies and fix inconsistent peer dependency declarations - @calcom/ui: Move react from dependencies to peerDependencies (was inconsistent with react-dom being a peer) - @calcom/emails: Move react and react-dom to peerDependencies - @coss/ui: Add react and react-dom as peerDependencies (uses lucide-react and @base-ui/react) - @calcom/app-store: Add react, react-dom, zod as peerDependencies (depends on @calcom/features which has these peers) - @calcom/platform-libraries: Add react, react-dom, stripe, zod as peerDependencies (depends on @calcom/features) - @calcom/features: Add next as peerDependency (depends on @calcom/trpc which has next as peer), update react/react-dom to flexible version ranges - @calcom/features/ee: Add react, react-dom, react-hook-form as peerDependencies (uses @calcom/ui and @hookform packages) Co-Authored-By: Volnei Munhoz * fix: add more peer dependencies for PnP compatibility Additional changes: - @calcom/app-store: Move stripe from dependencies to peerDependencies - @calcom/ui: Move @tanstack/react-query to peerDependencies (singleton pattern) - @calcom/trpc: Move @tanstack/react-query to peerDependencies (singleton pattern) - @calcom/atoms: Move @tanstack/react-query to peerDependencies (singleton pattern) - @calcom/stripepayment: Add react, react-dom, stripe as peerDependencies - @calcom/caldavcalendar: Add react, react-dom, react-hook-form as peerDependencies - @calcom/exchange2013calendar: Add react, react-dom, react-hook-form as peerDependencies - @calcom/exchange2016calendar: Add react, react-dom, react-hook-form as peerDependencies - @calcom/ics-feed: Add react, react-dom, react-hook-form as peerDependencies Co-Authored-By: Volnei Munhoz * fix: revert dependency moves for packages with own builds Packages with their own build step should not have dependencies moved to peerDependencies as they need those deps at build time. Reverted: - @calcom/trpc: Keep @tanstack/react-query out of peerDependencies - @calcom/atoms: Restore @tanstack/react-query to dependencies - @calcom/stripepayment: Restore stripe to dependencies Co-Authored-By: Volnei Munhoz --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- packages/app-store/caldavcalendar/package.json | 8 ++++++-- packages/app-store/exchange2013calendar/package.json | 8 ++++++-- packages/app-store/exchange2016calendar/package.json | 8 ++++++-- packages/app-store/ics-feedcalendar/package.json | 8 ++++++-- packages/app-store/package.json | 9 +++++++-- packages/coss-ui/package.json | 4 ++++ packages/emails/package.json | 6 ++++-- packages/features/ee/package.json | 5 +++++ packages/features/package.json | 5 +++-- packages/platform/libraries/package.json | 6 ++++++ packages/trpc/package.json | 3 ++- packages/ui/package.json | 6 +++--- 12 files changed, 58 insertions(+), 18 deletions(-) diff --git a/packages/app-store/caldavcalendar/package.json b/packages/app-store/caldavcalendar/package.json index cb4aa37b4f..ec4bd942ff 100644 --- a/packages/app-store/caldavcalendar/package.json +++ b/packages/app-store/caldavcalendar/package.json @@ -8,8 +8,12 @@ "dependencies": { "@calcom/lib": "workspace:*", "@calcom/prisma": "workspace:*", - "@calcom/ui": "workspace:*", - "react-hook-form": "7.43.3" + "@calcom/ui": "workspace:*" + }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", + "react-hook-form": "^7.0.0" }, "devDependencies": { "@calcom/types": "workspace:*" diff --git a/packages/app-store/exchange2013calendar/package.json b/packages/app-store/exchange2013calendar/package.json index ecf74781b4..5889ce6f74 100644 --- a/packages/app-store/exchange2013calendar/package.json +++ b/packages/app-store/exchange2013calendar/package.json @@ -8,8 +8,12 @@ "@calcom/lib": "workspace:*", "@calcom/prisma": "workspace:*", "@calcom/ui": "workspace:*", - "ews-javascript-api": "0.11.0", - "react-hook-form": "7.43.3" + "ews-javascript-api": "0.11.0" + }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", + "react-hook-form": "^7.0.0" }, "devDependencies": { "@calcom/types": "workspace:*" diff --git a/packages/app-store/exchange2016calendar/package.json b/packages/app-store/exchange2016calendar/package.json index e5cdd9d876..96ce4e7f70 100644 --- a/packages/app-store/exchange2016calendar/package.json +++ b/packages/app-store/exchange2016calendar/package.json @@ -8,8 +8,12 @@ "@calcom/lib": "workspace:*", "@calcom/prisma": "workspace:*", "@calcom/ui": "workspace:*", - "ews-javascript-api": "0.11.0", - "react-hook-form": "7.43.3" + "ews-javascript-api": "0.11.0" + }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", + "react-hook-form": "^7.0.0" }, "devDependencies": { "@calcom/types": "workspace:*" diff --git a/packages/app-store/ics-feedcalendar/package.json b/packages/app-store/ics-feedcalendar/package.json index 119b2f612e..11aedb0142 100644 --- a/packages/app-store/ics-feedcalendar/package.json +++ b/packages/app-store/ics-feedcalendar/package.json @@ -7,8 +7,12 @@ "dependencies": { "@calcom/lib": "workspace:*", "@calcom/prisma": "workspace:*", - "@calcom/ui": "workspace:*", - "react-hook-form": "7.43.3" + "@calcom/ui": "workspace:*" + }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", + "react-hook-form": "^7.0.0" }, "devDependencies": { "@calcom/types": "workspace:*" diff --git a/packages/app-store/package.json b/packages/app-store/package.json index 3e37261ef8..ff67095fc9 100644 --- a/packages/app-store/package.json +++ b/packages/app-store/package.json @@ -24,8 +24,13 @@ "@calcom/zoomvideo": "workspace:*", "lodash": "4.17.21", "qs-stringify": "1.2.1", - "react-i18next": "12.3.1", - "stripe": "9.16.0" + "react-i18next": "12.3.1" + }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", + "stripe": "^9.0.0 || ^15.0.0", + "zod": "^3.0.0" }, "devDependencies": { "@calcom/eslint-config": "workspace:*", diff --git a/packages/coss-ui/package.json b/packages/coss-ui/package.json index be78fb6213..a9be112342 100644 --- a/packages/coss-ui/package.json +++ b/packages/coss-ui/package.json @@ -22,6 +22,10 @@ "lucide-react": "0.555.0", "tailwind-merge": "3.4.0" }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0" + }, "devDependencies": { "ts-node": "10.9.2", "tsc-absolute": "1.0.0", diff --git a/packages/emails/package.json b/packages/emails/package.json index ec14bf2f32..64af5b257c 100644 --- a/packages/emails/package.json +++ b/packages/emails/package.json @@ -9,10 +9,12 @@ "dependencies": { "@calcom/dayjs": "workspace:*", "@calcom/lib": "workspace:*", - "react": "18.2.0", - "react-dom": "18.2.0", "rrule": "2.7.1" }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0" + }, "devDependencies": { "@calcom/tsconfig": "workspace:*", "@calcom/types": "workspace:*" diff --git a/packages/features/ee/package.json b/packages/features/ee/package.json index ea1088dd7d..02b069dd24 100644 --- a/packages/features/ee/package.json +++ b/packages/features/ee/package.json @@ -16,6 +16,11 @@ "twilio": "3.84.1", "zod": "3.25.76" }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", + "react-hook-form": "^7.0.0" + }, "devDependencies": { "@calcom/tsconfig": "workspace:*" } diff --git a/packages/features/package.json b/packages/features/package.json index a53580a257..85c71bd461 100644 --- a/packages/features/package.json +++ b/packages/features/package.json @@ -35,8 +35,9 @@ "zustand": "4.5.2" }, "peerDependencies": { - "react": "18.2.0", - "react-dom": "18.2.0", + "next": ">=14.0.0", + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", "react-is": "^18.2.0", "stripe": "^9.0.0 || ^15.0.0", "zod": "^3.0.0" diff --git a/packages/platform/libraries/package.json b/packages/platform/libraries/package.json index 9a2433380b..110ea7a29c 100644 --- a/packages/platform/libraries/package.json +++ b/packages/platform/libraries/package.json @@ -20,6 +20,12 @@ "@calcom/features": "workspace:*", "@calcom/lib": "workspace:*" }, + "peerDependencies": { + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0", + "stripe": "^9.0.0 || ^15.0.0", + "zod": "^3.0.0" + }, "devDependencies": { "@types/node": "20.17.23", "@vitejs/plugin-react": "4.2.1", diff --git a/packages/trpc/package.json b/packages/trpc/package.json index 2d09da1162..eeaaa472f2 100644 --- a/packages/trpc/package.json +++ b/packages/trpc/package.json @@ -14,7 +14,6 @@ "build:react": "yarn tsc --project tsconfig.react.json" }, "dependencies": { - "@tanstack/react-query": "5.17.19", "@trpc/client": "11.0.0-next-beta.222", "@trpc/next": "11.0.0-next-beta.222", "@trpc/react-query": "11.0.0-next-beta.222", @@ -25,12 +24,14 @@ "zod": "3.25.76" }, "peerDependencies": { + "@tanstack/react-query": "^5.0.0", "next": ">=14.0.0", "react": "^18.0.0 || ^19.0.0", "react-dom": "^18.0.0 || ^19.0.0" }, "devDependencies": { "@calcom/eslint-config": "workspace:*", + "@tanstack/react-query": "5.17.19", "@types/cookie": "0.6.0", "@types/uuid": "8.3.4", "typescript": "5.9.2" diff --git a/packages/ui/package.json b/packages/ui/package.json index 421f625db0..409c00b2b4 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -93,7 +93,6 @@ "@radix-ui/react-slider": "1.2.2", "@storybook/blocks": "7.6.3", "@storybook/react": "7.6.3", - "@tanstack/react-query": "5.17.19", "@tanstack/react-table": "8.20.6", "@wojtekmaj/react-daterange-picker": "3.4.0", "class-variance-authority": "0.4.0", @@ -103,7 +102,6 @@ "date-fns": "3.6.0", "downshift": "6.1.9", "lexical": "0.9.0", - "react": "18.2.0", "react-colorful": "5.6.1", "react-day-picker": "8.10.1", "react-easy-crop": "5.0.0", @@ -116,7 +114,9 @@ "zod": "3.25.76" }, "peerDependencies": { - "react-dom": "18.2.0" + "@tanstack/react-query": "^5.0.0", + "react": "^18.0.0 || ^19.0.0", + "react-dom": "^18.0.0 || ^19.0.0" }, "devDependencies": { "@calcom/config": "workspace:*",