From 3b471f0e259ab4f8575b6a53d94b114011fbdf4b Mon Sep 17 00:00:00 2001
From: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
Date: Wed, 17 Sep 2025 21:25:53 +0530
Subject: [PATCH] fix: one e2e flake visible in ci (#23897)

* fix: e2e flake visible in ci

* fix
---
 apps/web/playwright/fixtures/apps.ts  | 3 +++
 apps/web/playwright/fixtures/users.ts | 4 ++++
 apps/web/playwright/workflow.e2e.ts   | 2 +-
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/apps/web/playwright/fixtures/apps.ts b/apps/web/playwright/fixtures/apps.ts
index 3d213d4e79..b511b041a8 100644
--- a/apps/web/playwright/fixtures/apps.ts
+++ b/apps/web/playwright/fixtures/apps.ts
@@ -111,6 +111,9 @@ export function createAppsFixture(page: Page) {
     },
     goToEventType: async (eventType: string) => {
       await page.getByRole("link", { name: eventType }).click();
+      // fix the race condition
+      await page.waitForSelector('[data-testid="event-title"]');
+      await expect(page.getByTestId("vertical-tab-basics")).toHaveAttribute("aria-current", "page");
     },
     goToAppsTab: async () => {
       await page.getByTestId("vertical-tab-apps").click();
diff --git a/apps/web/playwright/fixtures/users.ts b/apps/web/playwright/fixtures/users.ts
index 4642bb1d56..cd5370e422 100644
--- a/apps/web/playwright/fixtures/users.ts
+++ b/apps/web/playwright/fixtures/users.ts
@@ -584,6 +584,10 @@ export const createUsersFixture = (
     get: () => store.users,
     logout: async () => {
       await page.goto("/auth/logout");
+      const logoutBtn = page.getByTestId("logout-btn");
+      await expect(logoutBtn).toHaveText("Go back to the login page");
+      await page.reload();
+      await expect(logoutBtn).toHaveText("Go back to the login page");
     },
     deleteAll: async () => {
       const ids = store.users.map((u) => u.id);
diff --git a/apps/web/playwright/workflow.e2e.ts b/apps/web/playwright/workflow.e2e.ts
index f262c5e8c2..290ce20c99 100644
--- a/apps/web/playwright/workflow.e2e.ts
+++ b/apps/web/playwright/workflow.e2e.ts
@@ -15,7 +15,7 @@ test.describe("Workflow Tab - Event Type", () => {
       test("Creating a new workflow", async ({ workflowPage }) => {
         const { createWorkflow, assertListCount } = workflowPage;
 
-        await createWorkflow({ name: "" });
+        await createWorkflow({ name: "test workflow" });
         await assertListCount(3);
       });