From 3b966191e3537960dda717224c6ce22379aa76ca Mon Sep 17 00:00:00 2001
From: Som <132274403+Sompalkar@users.noreply.github.com>
Date: Tue, 9 Sep 2025 13:43:15 +0530
Subject: [PATCH] fix: prevent footer doubling with CSS position absolute for
 grid layouts (#23368)

* fix: prevent footer doubling with CSS position absolute for grid layouts

* fix: use :host selector for Shadow DOM compatibility in footer doubling fix

* Add better comments and updae playground to be ab le to test it

---------

Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
---
 packages/embeds/embed-core/index.html         | 22 +++++++++++++++++--
 .../embed-core/src/ModalBox/ModalBoxHtml.ts   | 10 +++++++++
 2 files changed, 30 insertions(+), 2 deletions(-)

diff --git a/packages/embeds/embed-core/index.html b/packages/embeds/embed-core/index.html
index abe160bc67..2b64e305a5 100644
--- a/packages/embeds/embed-core/index.html
+++ b/packages/embeds/embed-core/index.html
@@ -1,6 +1,13 @@
 <html>
   <head>
     <title>Embed Playground</title>
+    <style>
+      html.grid-row-gap body {
+        grid-row-gap: 10rem;
+        flex-flow: column;
+        display: flex;
+      }
+    </style>
      <script type="text/javascript" src="./playground/lib/playground-init.ts"></script>
     <script>
       let popupRescheduleUid = null;
@@ -15,6 +22,10 @@
       if (!location.search.includes("nonResponsive")) {
         document.write('<meta name="viewport" content="width=device-width"/>');
       }
+
+      if (location.search.includes("grid-row-gap")) {
+        document.documentElement.classList.add("grid-row-gap");
+      }
      
       function addInlineEmbedInNewNamespaceWithoutReload(selector) {
         Cal("init", "withoutReloadNamespace", {
@@ -175,7 +186,16 @@
     </style>
   </head>
   <body>
+    <div style="margin-bottom: 20px;">
+      <h2>Different variations of the page</h2>
+      <div style="display: flex; flex-flow: row; gap: 10px;"> 
+        <span style="display: block"><a href="?color-scheme=dark">With Dark Color Scheme for the Page</a></span>
+        <span style="display: block"><a href="?nonResponsive">Non responsive version of this page here</a></span>
+        <span style="display: block"><a href="?grid-row-gap">Grid row gap version of this page here</a></span>
+    </div>
+    </div>
     <div id="misc-embeds">
+      <h2>Misc Embeds</h2>
       <div>
         <button id="add-inline-embed-in-a-new-namespace-without-reload-button" onclick="addInlineEmbedInNewNamespaceWithoutReload('#add-inline-embed-in-a-new-namespace-without-reload-button-content')">Add Inline Embed in a new namespace without reload</button>
         <div id="add-inline-embed-in-a-new-namespace-without-reload-button-content"></div>
@@ -195,8 +215,6 @@
           <div id="two-different-namespace-with-different-init-config-content-2"></div>
         </div>
       </div>
-      <span style="display: block"><a href="?color-scheme=dark">With Dark Color Scheme for the Page</a></span>
-      <span style="display: block"><a href="?nonResponsive">Non responsive version of this page here</a></span>
       <span style="display: block">
         <a href="?name=john&email=email&guests=abc&guests=def&notes=NOTES&location=%7B%22optionValue%22%3A%22%2B919999999999%22%2C%22value%22%3A%22phone%22%7D&only=ns%3ApageParamsForwarding">
           Page Params Forwarding(Prefills various fields by auto-forwarding query params)
diff --git a/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts b/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts
index f8cb6aeafb..a7f283ceb9 100644
--- a/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts
+++ b/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts
@@ -4,6 +4,16 @@ import { generateSkeleton } from "../ui/skeleton";
 function getStyle() {
   return `
   <style>
+    /* 
+      Modal box is added as a child of the top-most element which is body(the container)
+      If the container has grid layout being used. Even if the cal-modal-box is visiblity:hidden, it causes it to take up space in the grid layout
+      It causes that space to keep on increasing as modal box is opened and closed repeatedly
+      We set position:absolute to move it out of the regular flow of the grid layout
+    */
+    :host {
+      position: absolute;
+    }
+    
     .my-backdrop {
       position:fixed;
       width:100%;