From 451278b48efc6842d73021d74b2e4cc25ae89f3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Omar=20L=C3=B3pez?= <zomars@me.com>
Date: Tue, 30 May 2023 14:15:57 -0700
Subject: [PATCH] fix: routing-form flakyness (#9214)

---
 packages/app-store/routing-forms/components/SingleForm.tsx    | 4 ++--
 .../routing-forms/pages/route-builder/[...appPages].tsx       | 2 +-
 .../app-store/routing-forms/playwright/tests/basic.e2e.ts     | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/packages/app-store/routing-forms/components/SingleForm.tsx b/packages/app-store/routing-forms/components/SingleForm.tsx
index 8c1fba94e7..7a6bc17870 100644
--- a/packages/app-store/routing-forms/components/SingleForm.tsx
+++ b/packages/app-store/routing-forms/components/SingleForm.tsx
@@ -331,7 +331,7 @@ function SingleForm({ form, appUrl, Page }: SingleFormComponentProps) {
                         {form.routers.map((router) => {
                           return (
                             <div key={router.id} className="mr-2">
-                              <Link href={`/${appUrl}/route-builder/${router.id}`}>
+                              <Link href={`${appUrl}/route-builder/${router.id}`}>
                                 <Badge variant="gray">{router.name}</Badge>
                               </Link>
                             </div>
@@ -353,7 +353,7 @@ function SingleForm({ form, appUrl, Page }: SingleFormComponentProps) {
                         {connectedForms.map((router) => {
                           return (
                             <div key={router.id} className="mr-2">
-                              <Link href={`/${appUrl}/route-builder/${router.id}`}>
+                              <Link href={`${appUrl}/route-builder/${router.id}`}>
                                 <Badge variant="default">{router.name}</Badge>
                               </Link>
                             </div>
diff --git a/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx b/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx
index 2a6eda1fb7..e331ab9658 100644
--- a/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx
+++ b/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx
@@ -139,7 +139,7 @@ const Route = ({
           }
           className="mb-6">
           <div className="-mt-3">
-            <Link href={`/${appUrl}/route-builder/${route.id}`}>
+            <Link href={`${appUrl}/route-builder/${route.id}`}>
               <Badge variant="gray">
                 <span className="font-semibold">{route.name}</span>
               </Badge>
diff --git a/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts b/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts
index a6af91f1c1..b2e6f9c6c6 100644
--- a/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts
+++ b/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts
@@ -344,6 +344,7 @@ test.describe("Routing Forms", () => {
       const routingForm = user.routingForms[0];
       page.goto(`apps/routing-forms/form-edit/${routingForm.id}`);
       await page.click('[data-testid="test-preview"]');
+      await page.waitForLoadState("networkidle");
 
       // //event redirect
       await page.fill('[data-testid="form-field-Test field"]', "event-routing");