From 46f73e79c14a9f43d68fbf533bf4f16834e167b1 Mon Sep 17 00:00:00 2001 From: Rajiv Sahal Date: Fri, 21 Feb 2025 17:12:11 +0530 Subject: [PATCH] fix: booking fields being overridden whenever saving with atom (#19339) * fix booking fields not saving properly * fixup --- .../src/modules/atoms/services/event-types-atom.service.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/api/v2/src/modules/atoms/services/event-types-atom.service.ts b/apps/api/v2/src/modules/atoms/services/event-types-atom.service.ts index 6a22323c7e..c7c4869260 100644 --- a/apps/api/v2/src/modules/atoms/services/event-types-atom.service.ts +++ b/apps/api/v2/src/modules/atoms/services/event-types-atom.service.ts @@ -2,9 +2,9 @@ import { EventTypesService_2024_06_14 } from "@/ee/event-types/event-types_2024_ import { AtomsRepository } from "@/modules/atoms/atoms.repository"; import { CredentialsRepository } from "@/modules/credentials/credentials.repository"; import { MembershipsRepository } from "@/modules/memberships/memberships.repository"; -import { TeamsEventTypesService } from "@/modules/teams/event-types/services/teams-event-types.service"; import { PrismaReadService } from "@/modules/prisma/prisma-read.service"; import { PrismaWriteService } from "@/modules/prisma/prisma-write.service"; +import { TeamsEventTypesService } from "@/modules/teams/event-types/services/teams-event-types.service"; import { UsersService } from "@/modules/users/services/users.service"; import { UserWithProfile } from "@/modules/users/users.repository"; import { Injectable, NotFoundException, ForbiddenException } from "@nestjs/common"; @@ -122,9 +122,10 @@ export class EventTypesAtomService { async updateEventType(eventTypeId: number, body: TUpdateEventTypeInputSchema, user: UserWithProfile) { await this.eventTypeService.checkCanUpdateEventType(user.id, eventTypeId, body.scheduleId); const eventTypeUser = await this.eventTypeService.getUserToUpdateEvent(user); - const bookingFields = [...(body.bookingFields || [])]; + const bookingFields = body.bookingFields ? [...body.bookingFields] : undefined; if ( + bookingFields?.length && !bookingFields.find((field) => field.type === "email") && !bookingFields.find((field) => field.type === "phone") ) {