diff --git a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/SettingsLayoutAppDirClient.tsx b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/SettingsLayoutAppDirClient.tsx index c379f2991b..792ec1f01b 100644 --- a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/SettingsLayoutAppDirClient.tsx +++ b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/SettingsLayoutAppDirClient.tsx @@ -191,7 +191,6 @@ const useTabs = ({ const { data: user } = trpc.viewer.me.get.useQuery({ includePasswordAdded: true }); const orgBranding = useOrgBranding(); const isAdmin = session.data?.user.role === UserPermissionRole.ADMIN; - const isOrgAdminOrOwner = checkAdminOrOwner(orgBranding?.role); const processTabsMemod = useMemo(() => { const processedTabs = getTabs(orgBranding).map((tab) => { @@ -204,13 +203,10 @@ const useTabs = ({ }; } else if (tab.href === "/settings/organizations") { const newArray = (tab?.children ?? []).filter( - (child) => - permissions?.canUpdateOrganization || - isOrgAdminOrOwner || - !organizationAdminKeys.includes(child.name) + (child) => permissions?.canUpdateOrganization || !organizationAdminKeys.includes(child.name) ); - if (permissions?.canUpdateOrganization || isOrgAdminOrOwner) { + if (permissions?.canUpdateOrganization) { newArray.splice(4, 0, { name: "attributes", href: "/settings/organizations/attributes", @@ -242,7 +238,7 @@ const useTabs = ({ }); } } else { - if (permissions?.canUpdateOrganization || isOrgAdminOrOwner) { + if (permissions?.canUpdateOrganization) { newArray.push({ name: "billing", href: "/settings/organizations/billing", @@ -268,8 +264,7 @@ const useTabs = ({ return { ...tab, children: filtered }; } else if (tab.href === "/settings/developer") { const filtered = tab?.children?.filter( - (childTab) => - permissions?.canUpdateOrganization || isOrgAdminOrOwner || childTab.name !== "admin_api" + (childTab) => permissions?.canUpdateOrganization || childTab.name !== "admin_api" ); return { ...tab, children: filtered }; } @@ -279,21 +274,12 @@ const useTabs = ({ // check if name is in adminRequiredKeys return processedTabs.filter((tab) => { if (organizationRequiredKeys.includes(tab.name)) return !!orgBranding; - if (tab.name === "other_teams" && !(permissions?.canUpdateOrganization || isOrgAdminOrOwner)) - return false; + if (tab.name === "other_teams" && !permissions?.canUpdateOrganization) return false; if (isAdmin) return true; return !adminRequiredKeys.includes(tab.name); }); - }, [ - isAdmin, - orgBranding, - isOrgAdminOrOwner, - user, - isDelegationCredentialEnabled, - isPbacEnabled, - permissions, - ]); + }, [isAdmin, orgBranding, user, isDelegationCredentialEnabled, isPbacEnabled, permissions]); return processTabsMemod; }; @@ -574,8 +560,6 @@ const SettingsSidebarContainer = ({ } }, [searchParams?.get("id"), otherTeams]); - const isOrgAdminOrOwner = checkAdminOrOwner(orgBranding?.role); - return (