From 58ad4412234e50517b90863b7077ca5c24da6776 Mon Sep 17 00:00:00 2001 From: Hariom Balhara Date: Wed, 12 Jun 2024 19:38:04 +0530 Subject: [PATCH] fix: margin top in booker embed (#15412) --- .../embed-core/playwright/tests/embed-pages.e2e.ts | 14 ++++++++++---- packages/features/bookings/Booker/Booker.tsx | 5 ++++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts b/packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts index a392641e01..8c50488ca2 100644 --- a/packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts +++ b/packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts @@ -10,14 +10,19 @@ test.describe("Embed Pages", () => { await page.goto("http://localhost:3000/free/30min/embed"); // Checks the margin from top by checking the distance between the div inside main from the viewport const marginFromTop = await page.evaluate(async () => { - return await new Promise((resolve) => { + return await new Promise<{ + bookerContainer: number; + mainEl: number; + }>((resolve) => { (function tryGettingBoundingRect() { const mainElement = document.querySelector(".main"); + const bookerContainer = document.querySelector('[data-testid="booker-container"]'); - if (mainElement) { + if (mainElement && bookerContainer) { // This returns the distance of the div element from the viewport const mainElBoundingRect = mainElement.getBoundingClientRect(); - resolve(mainElBoundingRect.top); + const bookerContainerBoundingRect = bookerContainer.getBoundingClientRect(); + resolve({ bookerContainer: bookerContainerBoundingRect.top, mainEl: mainElBoundingRect.top }); } else { setTimeout(tryGettingBoundingRect, 500); } @@ -25,7 +30,8 @@ test.describe("Embed Pages", () => { }); }); - expect(marginFromTop).toBe(0); + expect(marginFromTop.bookerContainer).toBe(0); + expect(marginFromTop.mainEl).toBe(0); }); test("Event Type Page: should have margin top on non embed page", async ({ page }) => { diff --git a/packages/features/bookings/Booker/Booker.tsx b/packages/features/bookings/Booker/Booker.tsx index 0604ac950c..80c6a3cf97 100644 --- a/packages/features/bookings/Booker/Booker.tsx +++ b/packages/features/bookings/Booker/Booker.tsx @@ -268,9 +268,12 @@ const BookerComponent = ({ )}>