From 5dac6896d241d3e94704d3e44886cd315be89674 Mon Sep 17 00:00:00 2001
From: Hariom Balhara <hariombalhara@gmail.com>
Date: Mon, 24 Apr 2023 19:42:50 +0530
Subject: [PATCH] Routing-Forms/External Redirect URL improvement (#8487)

---
 .../routing-forms/pages/route-builder/[...appPages].tsx       | 4 ++--
 .../routing-forms/pages/routing-link/[...appPages].tsx        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx b/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx
index 2539142625..d36b792cc4 100644
--- a/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx
+++ b/packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx
@@ -215,14 +215,14 @@ const Route = ({
                     name="externalRedirectUrl"
                     className="border-default flex w-full flex-grow text-sm"
                     containerClassName="w-full mt-2"
-                    type="text"
+                    type="url"
                     required
                     labelSrOnly
                     value={route.action.value}
                     onChange={(e) => {
                       setRoute(route.id, { action: { ...route.action, value: e.target.value } });
                     }}
-                    placeholder="Enter External Redirect URL"
+                    placeholder="https://example.com"
                   />
                 ) : (
                   <div className="block w-full">
diff --git a/packages/app-store/routing-forms/pages/routing-link/[...appPages].tsx b/packages/app-store/routing-forms/pages/routing-link/[...appPages].tsx
index a2ffb18b63..5661a2e203 100644
--- a/packages/app-store/routing-forms/pages/routing-link/[...appPages].tsx
+++ b/packages/app-store/routing-forms/pages/routing-link/[...appPages].tsx
@@ -86,7 +86,7 @@ function RoutingForm({ form, profile, ...restProps }: inferSSRProps<typeof getSe
       } else if (decidedAction.type === "eventTypeRedirectUrl") {
         router.push(`/${decidedAction.value}`);
       } else if (decidedAction.type === "externalRedirectUrl") {
-        window.location.href = decidedAction.value;
+        window.parent.location.href = decidedAction.value;
       }
       // showToast("Form submitted successfully! Redirecting now ...", "success");
     },