From 5e98cca0625ad28083dbf9bbc6f32ecf11d9e0b8 Mon Sep 17 00:00:00 2001 From: Lauris Skraucis Date: Fri, 12 Apr 2024 17:49:47 +0200 Subject: [PATCH] fix: v2 create schedule with availabilities (#14551) * fix: v2 schedule with availabilities creation * driveby: remove permissions from public event-types endpoint --- .../event-types/controllers/event-types.controller.ts | 1 - .../inputs/create-availability.input.ts | 11 ++++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/apps/api/v2/src/ee/event-types/controllers/event-types.controller.ts b/apps/api/v2/src/ee/event-types/controllers/event-types.controller.ts index 22abc2ef18..a54436f32d 100644 --- a/apps/api/v2/src/ee/event-types/controllers/event-types.controller.ts +++ b/apps/api/v2/src/ee/event-types/controllers/event-types.controller.ts @@ -91,7 +91,6 @@ export class EventTypesController { } @Get("/:username/public") - @Permissions([EVENT_TYPE_READ]) async getPublicEventTypes(@Param("username") username: string): Promise { const eventTypes = await this.eventTypesService.getEventTypesPublicByUsername(username); diff --git a/apps/api/v2/src/modules/availabilities/inputs/create-availability.input.ts b/apps/api/v2/src/modules/availabilities/inputs/create-availability.input.ts index a0db94fecc..f03698705b 100644 --- a/apps/api/v2/src/modules/availabilities/inputs/create-availability.input.ts +++ b/apps/api/v2/src/modules/availabilities/inputs/create-availability.input.ts @@ -19,12 +19,17 @@ export class CreateAvailabilityInput { } function transformStringToDate(value: string, key: string): Date { - const parts = value.split(":"); + // note(Lauris): incoming value is ISO8061 e.g. 2025-0412T13:17:56.324Z + const dateTimeParts = value.split("T"); + + const timePart = dateTimeParts[1].split(".")[0]; // Removes milliseconds + const parts = timePart.split(":"); if (parts.length !== 3) { - throw new BadRequestException(`Invalid ${key} format. Expected format: HH:MM:SS. Received ${value}`); + throw new BadRequestException( + `Invalid time format. Expected format(ISO8061): 2025-0412T13:17:56.324Z. Received: ${value}` + ); } - const [hours, minutes, seconds] = parts.map(Number); if (hours < 0 || hours > 23) {