From 6af473a48608521c288ed11e50522e10dfac5461 Mon Sep 17 00:00:00 2001 From: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Date: Fri, 8 Aug 2025 16:37:08 +0530 Subject: [PATCH] fix: prevent makeBodyVisible timeout from running after test teardown (#22972) * fix: prevent makeBodyVisible timeout from running after test teardown - Add timeout tracking to makeBodyVisible function to enable cleanup - Add vi.clearAllTimers() to test teardown to clear recursive timeouts - Prevents 'ReferenceError: document is not defined' in CI tests Fixes intermittent test failures where makeBodyVisible recursive timeout continues running after test environment is torn down. Co-Authored-By: anik@cal.com * simplify: use only vi.clearAllTimers() to fix timeout issue Based on code review feedback, test if vi.clearAllTimers() alone is sufficient without modifying makeBodyVisible function. - Reverted makeBodyVisible function changes - Kept only vi.clearAllTimers() in test teardown - Verified with multiple test runs and type checking Co-Authored-By: anik@cal.com --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- packages/embeds/embed-core/src/__tests__/embed-iframe.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/embeds/embed-core/src/__tests__/embed-iframe.test.ts b/packages/embeds/embed-core/src/__tests__/embed-iframe.test.ts index 05c833afdd..ad382f3b3a 100644 --- a/packages/embeds/embed-core/src/__tests__/embed-iframe.test.ts +++ b/packages/embeds/embed-core/src/__tests__/embed-iframe.test.ts @@ -11,6 +11,7 @@ afterEach(() => { vi.clearAllMocks(); vi.resetModules(); vi.useRealTimers(); + vi.clearAllTimers(); }); describe("embedStore.router.ensureQueryParamsInUrl", async () => {