From 6c620e37a6a1b0196018513a34afc42d74ef6297 Mon Sep 17 00:00:00 2001 From: Obaidullah Ishfaq Date: Wed, 21 Jan 2026 23:12:54 +0500 Subject: [PATCH] refactor: remove redundant filtering in service (#25874) * refactor: remove redundant filtering and return filtered users from service * Simplify user retrieval by returning users directly * Fix formatting issue in users.service.ts * Filter out null users in getDynamicEventType --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> --- apps/api/v2/src/modules/users/services/users.service.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/apps/api/v2/src/modules/users/services/users.service.ts b/apps/api/v2/src/modules/users/services/users.service.ts index 3a1e3cc9a3..bdb8b7c6b4 100644 --- a/apps/api/v2/src/modules/users/services/users.service.ts +++ b/apps/api/v2/src/modules/users/services/users.service.ts @@ -28,14 +28,7 @@ export class UsersService { const users = await Promise.all( usernames.map((username) => this.usersRepository.findByUsername(username, orgSlug, orgId)) ); - const usersFiltered: User[] = []; - - for (const user of users) { - if (user) { - usersFiltered.push(user); - } - } - + return users; }