From 79a0071d65e28095b950fb599840a8106648f618 Mon Sep 17 00:00:00 2001 From: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Date: Thu, 26 Jun 2025 00:29:03 +0530 Subject: [PATCH] fix: e2e tests failure (#22043) * fix: delete dilog button not visible * fix: test failure --- apps/web/playwright/fixtures/users.ts | 2 +- .../routing-forms/playwright/tests/basic.e2e.ts | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/apps/web/playwright/fixtures/users.ts b/apps/web/playwright/fixtures/users.ts index e68360cba2..fb224859f1 100644 --- a/apps/web/playwright/fixtures/users.ts +++ b/apps/web/playwright/fixtures/users.ts @@ -395,7 +395,7 @@ export const createUsersFixture = ( }, { id: "a8ba9aab-4567-489a-bcde-f1823f71b4ad", - action: { type: "externalRedirectUrl", value: "https://cal.com/peer" }, + action: { type: "externalRedirectUrl", value: `${WEBAPP_URL}/pro` }, queryValue: { id: "a8ba9aab-4567-489a-bcde-f1823f71b4ad", type: "group", diff --git a/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts b/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts index 8b15e42005..bf0d631f0c 100644 --- a/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts +++ b/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts @@ -1,6 +1,7 @@ import type { Locator, Page } from "@playwright/test"; import { expect } from "@playwright/test"; +import { WEBAPP_URL } from "@calcom/lib/constants"; import { prisma } from "@calcom/prisma"; import { AttributeType, MembershipRole, SchedulingType } from "@calcom/prisma/enums"; import type { Fixtures } from "@calcom/web/playwright/lib/fixtures"; @@ -262,7 +263,7 @@ test.describe("Routing Forms", () => { option: 2, page, }); - await page.fill("[name=externalRedirectUrl]", "https://cal.com/peer"); + await page.fill("[name=externalRedirectUrl]", `${WEBAPP_URL}/pro`); await saveCurrentForm(page); const { fields } = await addAllTypesOfFieldsAndSaveForm(formId, page, { @@ -290,7 +291,7 @@ test.describe("Routing Forms", () => { await page.click('button[type="submit"]'); await page.waitForURL((url) => { - return url.hostname.includes("cal.com"); + return url.pathname.endsWith("/pro"); }); const url = new URL(page.url()); @@ -509,7 +510,7 @@ test.describe("Routing Forms", () => { await page.goto(`/router?form=${routingForm.id}&Test field=external-redirect`); await page.waitForURL((url) => { - return url.hostname.includes("cal.com") && url.searchParams.get("Test field") === "external-redirect"; + return url.pathname.endsWith("/pro") && url.searchParams.get("Test field") === "external-redirect"; }); await page.goto(`/router?form=${routingForm.id}&Test field=custom-page`); @@ -576,7 +577,7 @@ test.describe("Routing Forms", () => { routingType = await page.locator('[data-testid="chosen-route-title"]').innerText(); route = await page.locator('[data-testid="test-routing-result"]').innerText(); expect(routingType).toBe("External Redirect"); - expect(route).toBe("https://cal.com/peer"); + expect(route).toBe(`${WEBAPP_URL}/pro`); await page.click('[data-testid="close-results-button"]'); // Multiselect(Legacy) @@ -925,7 +926,7 @@ test.describe("Routing Forms", () => { option: 2, page, }); - await page.fill("[name=externalRedirectUrl]", "https://cal.com/peer"); + await page.fill("[name=externalRedirectUrl]", `${WEBAPP_URL}/pro`); await saveCurrentForm(page); return { formId, @@ -978,7 +979,7 @@ test.describe("Routing Forms", () => { await page.fill('[data-testid="form-field-short-text"]', "test"); await page.click('button[type="submit"]'); await page.waitForURL((url) => { - return url.hostname.includes("cal.com"); + return url.pathname.endsWith("/pro"); }); }; @@ -1059,7 +1060,7 @@ async function fillSeededForm(page: Page, routingFormId: string) { await fillAllOptionsBasedFields(); page.click('button[type="submit"]'); await page.waitForURL((url) => { - return url.hostname.includes("cal.com"); + return url.pathname.endsWith("/pro"); }); })();