From 79e914b0fb5211d4f0104aa79de666f5201ebf6c Mon Sep 17 00:00:00 2001 From: zomars Date: Mon, 29 May 2023 18:28:40 -0700 Subject: [PATCH] Prevents page.pause reaching main --- apps/web/playwright/booking-pages.e2e.ts | 1 - apps/web/playwright/booking-seats.e2e.ts | 1 - apps/web/playwright/hash-my-url.e2e.ts | 1 - packages/config/eslint-preset.js | 1 + 4 files changed, 1 insertion(+), 3 deletions(-) diff --git a/apps/web/playwright/booking-pages.e2e.ts b/apps/web/playwright/booking-pages.e2e.ts index 5c72236154..f35f871279 100644 --- a/apps/web/playwright/booking-pages.e2e.ts +++ b/apps/web/playwright/booking-pages.e2e.ts @@ -65,7 +65,6 @@ testBothBookers.describe("pro user", () => { }); test("pro user's page has at least 2 visible events", async ({ page }) => { - // await page.pause(); const $eventTypes = page.locator("[data-testid=event-types] > *"); expect(await $eventTypes.count()).toBeGreaterThanOrEqual(2); }); diff --git a/apps/web/playwright/booking-seats.e2e.ts b/apps/web/playwright/booking-seats.e2e.ts index 940d566d54..723c7866ad 100644 --- a/apps/web/playwright/booking-seats.e2e.ts +++ b/apps/web/playwright/booking-seats.e2e.ts @@ -427,7 +427,6 @@ testBothBookers.describe("Booking with Seats", (bookerVariant) => { 'p[data-testid="attendee-email-second+seats@cal.com"]' ); await expect(foundSecondAttendeeAsOwner).toHaveCount(1); - await page.pause(); await page.goto("auth/logout"); // Now we cancel the booking as the first attendee diff --git a/apps/web/playwright/hash-my-url.e2e.ts b/apps/web/playwright/hash-my-url.e2e.ts index b948019bd1..921a933c52 100644 --- a/apps/web/playwright/hash-my-url.e2e.ts +++ b/apps/web/playwright/hash-my-url.e2e.ts @@ -15,7 +15,6 @@ test.fixme("hash my url", () => { await users.deleteAll(); }); test("generate url hash", async ({ page }) => { - // await page.pause(); await page.goto("/event-types"); // We wait until loading is finished await page.waitForSelector('[data-testid="event-types"]'); diff --git a/packages/config/eslint-preset.js b/packages/config/eslint-preset.js index aae6eb0a93..0d364f0b73 100644 --- a/packages/config/eslint-preset.js +++ b/packages/config/eslint-preset.js @@ -22,6 +22,7 @@ module.exports = { "@next/next/no-img-element": "off", "@next/next/no-html-link-for-pages": "off", "jsx-a11y/role-supports-aria-props": "off", // @see https://github.com/vercel/next.js/issues/27989#issuecomment-897638654 + "playwright/no-page-pause": "error", "react/jsx-curly-brace-presence": ["error", { props: "never", children: "never" }], "react/self-closing-comp": ["error", { component: true, html: true }], "@typescript-eslint/no-unused-vars": [