From 8831ff13c7b2dc84d48730fb760f8325c908dd73 Mon Sep 17 00:00:00 2001
From: Keith Williams <keithwillcode@gmail.com>
Date: Thu, 23 May 2024 14:00:56 -0400
Subject: [PATCH] chore: Skip flaky tests that have been failing often (#15161)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* chore: Skip flaky tests that have been failing often

* Update basic.e2e.ts

* Skipped another test

* Only run on legacy routes as a test

* Removing future routes from build

* Updated the remove script

* Fixing command

* Bring back the future routes

* Skipped another

---------

Co-authored-by: Omar López <zomars@me.com>
---
 apps/web/playwright/event-types.e2e.ts                    | 4 +++-
 apps/web/playwright/login.e2e.ts                          | 5 ++++-
 apps/web/playwright/profile.e2e.ts                        | 8 ++++++--
 packages/embeds/embed-react/playwright/tests/basic.e2e.ts | 4 +++-
 4 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/apps/web/playwright/event-types.e2e.ts b/apps/web/playwright/event-types.e2e.ts
index 9bfba641d2..0dd203fb2b 100644
--- a/apps/web/playwright/event-types.e2e.ts
+++ b/apps/web/playwright/event-types.e2e.ts
@@ -247,7 +247,9 @@ testBothFutureAndLegacyRoutes.describe("Event Types tests", () => {
         expect(await linkElement.getAttribute("href")).toBe(testUrl);
       });
 
-      test("Can remove location from multiple locations that are saved", async ({ page }) => {
+      // TODO: This test is extremely flaky and has been failing a lot, blocking many PRs. Fix this.
+      // eslint-disable-next-line playwright/no-skipped-test
+      test.skip("Can remove location from multiple locations that are saved", async ({ page }) => {
         await gotoFirstEventType(page);
 
         // Add Attendee Phone Number location
diff --git a/apps/web/playwright/login.e2e.ts b/apps/web/playwright/login.e2e.ts
index 60fb1938c8..6796669c06 100644
--- a/apps/web/playwright/login.e2e.ts
+++ b/apps/web/playwright/login.e2e.ts
@@ -13,7 +13,10 @@ testBothFutureAndLegacyRoutes.describe("user can login & logout succesfully", as
   test.afterAll(async ({ users }) => {
     await users.deleteAll();
   });
-  test("login flow user & logout using dashboard", async ({ page, users }) => {
+
+  // TODO: This test is extremely flaky and has been failing a lot, blocking many PRs. Fix this.
+  // eslint-disable-next-line playwright/no-skipped-test
+  test.skip("login flow user & logout using dashboard", async ({ page, users }) => {
     // log in trail user
     await test.step("Log in", async () => {
       const user = await users.create();
diff --git a/apps/web/playwright/profile.e2e.ts b/apps/web/playwright/profile.e2e.ts
index eb3cb66d56..cb23148cfa 100644
--- a/apps/web/playwright/profile.e2e.ts
+++ b/apps/web/playwright/profile.e2e.ts
@@ -99,7 +99,9 @@ test.describe("Update Profile", () => {
     expect(await emailInputUpdated.inputValue()).toEqual(user.email);
   });
 
-  test("Can update a users email (verification enabled)", async ({ page, users, prisma, features }) => {
+  // TODO: This test is extremely flaky and has been failing a lot, blocking many PRs. Fix this.
+  // eslint-disable-next-line playwright/no-skipped-test
+  test.skip("Can update a users email (verification enabled)", async ({ page, users, prisma, features }) => {
     const emailVerificationEnabled = features.get("email-verification");
     // eslint-disable-next-line playwright/no-conditional-in-test, playwright/no-skipped-test
     if (!emailVerificationEnabled?.enabled) test.skip();
@@ -372,7 +374,9 @@ test.describe("Update Profile", () => {
     expect(await page.getByTestId("profile-form-email-1-unverified-badge").isVisible()).toEqual(false);
   });
 
-  test("Can resend verification link if the secondary email is unverified", async ({
+  // TODO: This test is extremely flaky and has been failing a lot, blocking many PRs. Fix this.
+  // eslint-disable-next-line playwright/no-skipped-test
+  test.skip("Can resend verification link if the secondary email is unverified", async ({
     page,
     users,
     prisma,
diff --git a/packages/embeds/embed-react/playwright/tests/basic.e2e.ts b/packages/embeds/embed-react/playwright/tests/basic.e2e.ts
index 300a99f1ca..5ebffbe1bd 100644
--- a/packages/embeds/embed-react/playwright/tests/basic.e2e.ts
+++ b/packages/embeds/embed-react/playwright/tests/basic.e2e.ts
@@ -44,7 +44,9 @@ test.describe("React Embed", () => {
     });
   });
 
-  test.describe("Element Click Popup", () => {
+  // TODO: This test is extremely flaky and has been failing a lot, blocking many PRs. Fix this.
+  // eslint-disable-next-line playwright/no-skipped-test
+  test.describe.skip("Element Click Popup", () => {
     test("should verify that the iframe got created with correct URL - namespaced", async ({
       page,
       embeds,