From 9a12b5a0ac377f1aba0fa360b6de1682761258ea Mon Sep 17 00:00:00 2001
From: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Date: Mon, 28 Nov 2022 16:27:07 +0100
Subject: [PATCH] fix e2e tests (#5726)

* fix e2e tests

* remove not needed waitForNavigation

Co-authored-by: CarinaWolli <wollencarina@gmail.com>
---
 apps/web/pages/success.tsx                       | 2 +-
 apps/web/playwright/booking-pages.e2e.ts         | 9 ++-------
 apps/web/playwright/dynamic-booking-pages.e2e.ts | 9 ++-------
 3 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/apps/web/pages/success.tsx b/apps/web/pages/success.tsx
index 808f64d4b0..f834f96665 100644
--- a/apps/web/pages/success.tsx
+++ b/apps/web/pages/success.tsx
@@ -361,7 +361,7 @@ export default function Success(props: SuccessProps) {
                 <div className="mt-6 mb-8 text-center last:mb-0">
                   <h3
                     className="text-2xl font-semibold leading-6 text-neutral-900 dark:text-white"
-                    data-testid="success-headline"
+                    data-testid={isCancelled ? "cancelled-headline" : ""}
                     id="modal-headline">
                     {needsConfirmation && !isCancelled
                       ? props.recurringBookings
diff --git a/apps/web/playwright/booking-pages.e2e.ts b/apps/web/playwright/booking-pages.e2e.ts
index 50fc99d0d2..fbfab86433 100644
--- a/apps/web/playwright/booking-pages.e2e.ts
+++ b/apps/web/playwright/booking-pages.e2e.ts
@@ -114,14 +114,9 @@ test.describe("pro user", () => {
     // --- fill form
     await page.locator('[data-testid="cancel"]').click();
 
-    await page.waitForNavigation({
-      url: (url) => {
-        return url.pathname.startsWith("/success");
-      },
-    });
-    const successHeadling = await page.locator('[data-testid="success-headline"]').innerText();
+    const cancelledHeadline = await page.locator('[data-testid="cancelled-headline"]').innerText();
 
-    await expect(successHeadling).toBe("This event is cancelled");
+    await expect(cancelledHeadline).toBe("This event is cancelled");
 
     await page.goto(`/${pro.username}`);
     await bookFirstEvent(page);
diff --git a/apps/web/playwright/dynamic-booking-pages.e2e.ts b/apps/web/playwright/dynamic-booking-pages.e2e.ts
index 221f4a58ec..bf4e7e0f58 100644
--- a/apps/web/playwright/dynamic-booking-pages.e2e.ts
+++ b/apps/web/playwright/dynamic-booking-pages.e2e.ts
@@ -54,14 +54,9 @@ test("dynamic booking", async ({ page, users }) => {
     // --- fill form
     await page.locator('[data-testid="cancel"]').click();
 
-    await page.waitForNavigation({
-      url: (url) => {
-        return url.pathname.startsWith("/success");
-      },
-    });
-    const successHeadling = await page.locator('[data-testid="success-headline"]').innerText();
+    const cancelledHeadline = await page.locator('[data-testid="cancelled-headline"]').innerText();
 
-    await expect(successHeadling).toBe("This event is cancelled");
+    await expect(cancelledHeadline).toBe("This event is cancelled");
   });
 
   await users.deleteAll();