From 9cad7086d7f89f89325e97e984dc89ff4242b531 Mon Sep 17 00:00:00 2001 From: Hariom Balhara Date: Wed, 8 Feb 2023 21:50:13 +0530 Subject: [PATCH] Give trackingId a default value because if user doesnt interact with trackingId input it is not set (#6945) --- packages/app-store/fathom/zod.ts | 2 +- packages/app-store/ga4/zod.ts | 2 +- packages/app-store/plausible/zod.ts | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/app-store/fathom/zod.ts b/packages/app-store/fathom/zod.ts index a9f8ba3d56..674bf3405d 100644 --- a/packages/app-store/fathom/zod.ts +++ b/packages/app-store/fathom/zod.ts @@ -4,7 +4,7 @@ import { eventTypeAppCardZod } from "../eventTypeAppCardZod"; export const appDataSchema = eventTypeAppCardZod.merge( z.object({ - trackingId: z.string(), + trackingId: z.string().default("").optional(), }) ); diff --git a/packages/app-store/ga4/zod.ts b/packages/app-store/ga4/zod.ts index a9f8ba3d56..674bf3405d 100644 --- a/packages/app-store/ga4/zod.ts +++ b/packages/app-store/ga4/zod.ts @@ -4,7 +4,7 @@ import { eventTypeAppCardZod } from "../eventTypeAppCardZod"; export const appDataSchema = eventTypeAppCardZod.merge( z.object({ - trackingId: z.string(), + trackingId: z.string().default("").optional(), }) ); diff --git a/packages/app-store/plausible/zod.ts b/packages/app-store/plausible/zod.ts index 05ffb12b4a..674bf3405d 100644 --- a/packages/app-store/plausible/zod.ts +++ b/packages/app-store/plausible/zod.ts @@ -4,9 +4,7 @@ import { eventTypeAppCardZod } from "../eventTypeAppCardZod"; export const appDataSchema = eventTypeAppCardZod.merge( z.object({ - // FIXME: Due to some reason autogenerated zod schema at prisma/zod/eventtype.ts fails typecheck on using `.default()`. It somehow thinks that trackingId can be undefined - // z.lazy has something to do with it. Figure it out later. - trackingId: z.string().default("") as unknown as z.ZodString, + trackingId: z.string().default("").optional(), }) );