From 9d481454bf22bd39676d3622c57d77310235d9a0 Mon Sep 17 00:00:00 2001 From: Romit <85230081+romitg2@users.noreply.github.com> Date: Mon, 27 Apr 2026 00:46:20 +0530 Subject: [PATCH] cleanup(test): remove team bookings handler integration coverage (#29017) --- .../bookings/get.handler.integration-test.ts | 85 ++----------------- 1 file changed, 5 insertions(+), 80 deletions(-) diff --git a/packages/trpc/server/routers/viewer/bookings/get.handler.integration-test.ts b/packages/trpc/server/routers/viewer/bookings/get.handler.integration-test.ts index 89abd7b376..da727524b6 100644 --- a/packages/trpc/server/routers/viewer/bookings/get.handler.integration-test.ts +++ b/packages/trpc/server/routers/viewer/bookings/get.handler.integration-test.ts @@ -1,19 +1,16 @@ import prisma from "@calcom/prisma"; import kysely from "@calcom/kysely"; -import type { Booking, EventType, Team, User } from "@calcom/prisma/client"; -import { BookingStatus, MembershipRole } from "@calcom/prisma/enums"; +import type { Booking, EventType, User } from "@calcom/prisma/client"; +import { BookingStatus } from "@calcom/prisma/enums"; import { afterAll, beforeAll, describe, expect, it } from "vitest"; import { getBookings } from "./get.handler"; let user1: User; let user2: User; -let team1: Team; let eventType1: EventType; let booking1: Booking; let booking2: Booking; let booking3: Booking; -let booking4: Booking; -let teamEventType: EventType; const timestamp = Date.now(); @@ -35,29 +32,6 @@ describe("getBookings - integration", () => { }, }); - team1 = await prisma.team.create({ - data: { - name: `GetBookings Team ${timestamp}`, - slug: `getbookings-team-${timestamp}`, - members: { - create: { - userId: user1.id, - role: MembershipRole.ADMIN, - accepted: true, - }, - }, - }, - }); - - await prisma.membership.create({ - data: { - userId: user2.id, - teamId: team1.id, - role: MembershipRole.MEMBER, - accepted: true, - }, - }); - eventType1 = await prisma.eventType.create({ data: { title: `GetBookings Event ${timestamp}`, @@ -127,52 +101,19 @@ describe("getBookings - integration", () => { }, }, }); - - teamEventType = await prisma.eventType.create({ - data: { - title: `GetBookings Team Event ${timestamp}`, - slug: `getbookings-team-event-${timestamp}`, - length: 30, - teamId: team1.id, - }, - }); - - const futureDate4 = new Date(Date.now() + 10 * 24 * 60 * 60 * 1000); - booking4 = await prisma.booking.create({ - data: { - uid: `getbookings-booking4-${timestamp}`, - title: "Team Booking - multi branch", - startTime: futureDate4, - endTime: new Date(futureDate4.getTime() + 30 * 60 * 1000), - userId: user1.id, - eventTypeId: teamEventType.id, - status: BookingStatus.ACCEPTED, - attendees: { - create: { - email: user1.email, - name: user1.name ?? "User 1", - timeZone: "UTC", - }, - }, - }, - }); }); afterAll(async () => { try { - const bookingIds = [booking1?.id, booking2?.id, booking3?.id, booking4?.id].filter(Boolean); + const bookingIds = [booking1?.id, booking2?.id, booking3?.id].filter(Boolean); if (bookingIds.length > 0) { await prisma.attendee.deleteMany({ where: { bookingId: { in: bookingIds } } }); await prisma.booking.deleteMany({ where: { id: { in: bookingIds } } }); } - const eventTypeIds = [eventType1?.id, teamEventType?.id].filter(Boolean); + const eventTypeIds = [eventType1?.id].filter(Boolean); if (eventTypeIds.length > 0) { await prisma.eventType.deleteMany({ where: { id: { in: eventTypeIds } } }); } - const teamIds = [team1?.id].filter(Boolean); - if (teamIds.length > 0) { - await prisma.team.deleteMany({ where: { id: { in: teamIds } } }); - } const userIds = [user1?.id, user2?.id].filter(Boolean); if (userIds.length > 0) { await prisma.user.deleteMany({ where: { id: { in: userIds } } }); @@ -242,7 +183,7 @@ describe("getBookings - integration", () => { skip: 0, }); - const expectedBookingIds = [booking1.id, booking2.id, booking3.id, booking4.id]; + const expectedBookingIds = [booking1.id, booking2.id, booking3.id]; const returnedIds = resultUser1.bookings.map((b) => b.id); for (const id of expectedBookingIds) { expect(returnedIds).toContain(id); @@ -250,22 +191,6 @@ describe("getBookings - integration", () => { expect(resultUser1.totalCount).toBe(resultUser1.bookings.length); }); - it("should count booking4 exactly once in totalCount even though it matches multiple union branches", async () => { - const result = await getBookings({ - user: { id: user1.id, email: user1.email, orgId: null }, - prisma, - kysely, - bookingListingByStatus: ["upcoming"], - filters: {}, - take: 50, - skip: 0, - }); - - const booking4Occurrences = result.bookings.filter((b) => b.id === booking4.id); - expect(booking4Occurrences).toHaveLength(1); - expect(result.totalCount).toBe(result.bookings.length); - }); - it("should respect pagination with correct ordering", async () => { const page1 = await getBookings({ user: { id: user1.id, email: user1.email, orgId: null },