refactor: calEventParser CalendarEvent ISP (#25890)
* refactor: calEventParser CalendarEvent ISP
* update
* fix: complete CalEventParser ISP refactoring - update call sites and fix type errors
- Update getUid call sites to pass only uid instead of whole CalendarEvent
- Update getLocation call sites to pass narrow shape with videoCallData, additionalInformation, location, uid
- Update narrow input shapes to accept null for location (matching CalendarEvent type)
- Update recurringEvent type to accept RecurringEvent | null instead of boolean
- Update videoCallData type to be more flexible ({ type?: string; url?: string })
- Fix ManageLink.tsx to pass recurringEvent directly instead of converting to boolean
Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>
* test: update CalEventParser tests to use narrow input shapes
- Update getPublicVideoCallUrl test to pass uid instead of calEvent
- Update getVideoCallPassword tests to pass videoCallData instead of calEvent
Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>
* few fix
* fix type error
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
This commit is contained in:
co-authored by
anik@cal.com
Devin AI
Morgan
parent
c42d60256d
commit
9fcddbf27b
@@ -189,7 +189,12 @@ class BiginCrmService implements CRM {
|
||||
Start_DateTime: toISO8601String(new Date(event.startTime)),
|
||||
End_DateTime: toISO8601String(new Date(event.endTime)),
|
||||
Description: event.additionalNotes,
|
||||
Venue: getLocation(event),
|
||||
Venue: getLocation({
|
||||
videoCallData: event.videoCallData,
|
||||
additionalInformation: event.additionalInformation,
|
||||
location: event.location,
|
||||
uid: event.uid,
|
||||
}),
|
||||
Who_Id: contacts[0].id,
|
||||
};
|
||||
|
||||
@@ -249,7 +254,12 @@ class BiginCrmService implements CRM {
|
||||
Start_DateTime: toISO8601String(new Date(event.startTime)),
|
||||
End_DateTime: toISO8601String(new Date(event.endTime)),
|
||||
Description: event.additionalNotes,
|
||||
Location: getLocation(event),
|
||||
Location: getLocation({
|
||||
videoCallData: event.videoCallData,
|
||||
additionalInformation: event.additionalInformation,
|
||||
location: event.location,
|
||||
uid: event.uid,
|
||||
}),
|
||||
};
|
||||
|
||||
return axios
|
||||
|
||||
Reference in New Issue
Block a user