From a839630ca30a80ce1bc81c31aed772cf9db462ea Mon Sep 17 00:00:00 2001
From: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
Date: Fri, 23 May 2025 12:40:27 +0530
Subject: [PATCH] test: fix few e2e flakes (#21408)

* fix flakes

* update

* Update booking.e2e.ts

* update

* Update booking.e2e.ts

* Update booking.e2e.ts
---
 apps/web/playwright/bookings-list.e2e.ts        | 6 +++++-
 apps/web/playwright/fixtures/users.ts           | 2 +-
 apps/web/playwright/organization/booking.e2e.ts | 6 ++++--
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/apps/web/playwright/bookings-list.e2e.ts b/apps/web/playwright/bookings-list.e2e.ts
index 5fe00b7b66..df4fe17200 100644
--- a/apps/web/playwright/bookings-list.e2e.ts
+++ b/apps/web/playwright/bookings-list.e2e.ts
@@ -461,10 +461,14 @@ test.describe("Bookings", () => {
 
     await addFilter(page, "userId");
     await openFilter(page, "userId");
+    const bookingsGetResponse2 = page.waitForResponse((response) =>
+      /\/api\/trpc\/bookings\/get.*/.test(response.url())
+    );
+
     await page
       .locator(`[data-testid="select-filter-options-userId"] [role="option"]:has-text("${anotherUser}")`)
       .click();
-    await page.waitForResponse((response) => /\/api\/trpc\/bookings\/get.*/.test(response.url()));
+    await bookingsGetResponse2;
 
     await expect(page.locator('[data-testid="booking-item"]')).toHaveCount(0);
   });
diff --git a/apps/web/playwright/fixtures/users.ts b/apps/web/playwright/fixtures/users.ts
index 55569252ae..d42e9a4416 100644
--- a/apps/web/playwright/fixtures/users.ts
+++ b/apps/web/playwright/fixtures/users.ts
@@ -1044,7 +1044,7 @@ export async function login(
   const signInLocator = loginLocator.locator('[type="submit"]');
 
   //login
-  await page.goto("/");
+  await page.goto("/auth/login");
   await page.waitForSelector("text=Welcome back");
 
   await emailLocator.fill(user.email ?? `${user.username}@example.com`);
diff --git a/apps/web/playwright/organization/booking.e2e.ts b/apps/web/playwright/organization/booking.e2e.ts
index e53186147c..043e3a01ca 100644
--- a/apps/web/playwright/organization/booking.e2e.ts
+++ b/apps/web/playwright/organization/booking.e2e.ts
@@ -431,9 +431,11 @@ test.describe("Bookings", () => {
 
           // Cancel the booking
           await page.goto(`/booking/${bookingUid}`);
+          await page.waitForLoadState("networkidle");
           await page.getByTestId("cancel").click();
-          await page.getByTestId("confirm_cancel").click();
-          await page.waitForResponse((response) => response.url().includes("/api/cancel"));
+          await submitAndWaitForResponse(page, "/api/cancel", {
+            action: () => page.locator('[data-testid="confirm_cancel"]').click(),
+          });
 
           // Logout and go back to booking page
           await page.goto("/auth/logout");