From abb4fd307fe21f2a2b0f02fd5bd82019ab4a54a4 Mon Sep 17 00:00:00 2001 From: Somay Chauhan Date: Wed, 18 Sep 2024 22:44:23 +0530 Subject: [PATCH] refactor: event setup tab web wrapper (#16672) * chore: EventTypeWebWrapper base pr * fixup! chore: EventTypeWebWrapper base pr * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * wip * fix: error * Event type atom wrapper handles app dir * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * remove console log * refactor: event-type-atom (setup tab) * review comments * update: better naming * fixup! review comments * revert: defaultMenuIsOpen --will create a separate PR --------- Co-authored-by: Morgan Vernay Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> --- .../components/tabs/setup/EventSetupTab.tsx | 11 +++++------ .../event-types/wrappers/EventSetupTabWebWrapper.tsx | 8 ++++++++ .../event-types/wrappers/EventTypeWebWrapper.tsx | 2 +- 3 files changed, 14 insertions(+), 7 deletions(-) create mode 100644 packages/platform/atoms/event-types/wrappers/EventSetupTabWebWrapper.tsx diff --git a/packages/features/eventtypes/components/tabs/setup/EventSetupTab.tsx b/packages/features/eventtypes/components/tabs/setup/EventSetupTab.tsx index a7e6adc890..016cb968a7 100644 --- a/packages/features/eventtypes/components/tabs/setup/EventSetupTab.tsx +++ b/packages/features/eventtypes/components/tabs/setup/EventSetupTab.tsx @@ -15,12 +15,11 @@ import { slugify } from "@calcom/lib/slugify"; import turndown from "@calcom/lib/turndownService"; import { Label, Select, SettingsToggle, Skeleton, TextField, Editor } from "@calcom/ui"; -export const EventSetupTab = ( - props: Pick< - EventTypeSetupProps, - "eventType" | "locationOptions" | "team" | "teamMembers" | "destinationCalendar" - > -) => { +export type EventSetupTabProps = Pick< + EventTypeSetupProps, + "eventType" | "locationOptions" | "team" | "teamMembers" | "destinationCalendar" +>; +export const EventSetupTab = (props: EventSetupTabProps) => { const { t } = useLocale(); const formMethods = useFormContext(); const { eventType, team } = props; diff --git a/packages/platform/atoms/event-types/wrappers/EventSetupTabWebWrapper.tsx b/packages/platform/atoms/event-types/wrappers/EventSetupTabWebWrapper.tsx new file mode 100644 index 0000000000..432a21d27c --- /dev/null +++ b/packages/platform/atoms/event-types/wrappers/EventSetupTabWebWrapper.tsx @@ -0,0 +1,8 @@ +import type { EventSetupTabProps } from "@calcom/features/eventtypes/components/tabs/setup/EventSetupTab"; +import { EventSetupTab } from "@calcom/features/eventtypes/components/tabs/setup/EventSetupTab"; + +const EventSetupTabWebWrapper = (props: EventSetupTabProps) => { + return ; +}; + +export default EventSetupTabWebWrapper; diff --git a/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx b/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx index 8c5f6ca961..690f6037dd 100644 --- a/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx +++ b/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx @@ -32,7 +32,7 @@ const AssignmentWarningDialog = dynamic( const EventSetupTab = dynamic(() => // import web wrapper when it's ready - import("@calcom/features/eventtypes/components/tabs/setup/EventSetupTab").then((mod) => mod.EventSetupTab) + import("./EventSetupTabWebWrapper").then((mod) => mod) ); const EventAvailabilityTab = dynamic(() =>