From ac3fb0a1cd8a57ba9c17a6b5a1aab14013fe9849 Mon Sep 17 00:00:00 2001 From: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Date: Fri, 31 May 2024 12:57:20 -0400 Subject: [PATCH] fix: Typo in `deleteCredential` handler (#15281) * Fix typo * Added optional chaining --- packages/core/crmManager/crmManager.test.ts | 3 ++- .../getAllCredentials.test.ts | 7 ++++--- .../routers/loggedInViewer/deleteCredential.handler.ts | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/core/crmManager/crmManager.test.ts b/packages/core/crmManager/crmManager.test.ts index 0973d476ac..62143d771d 100644 --- a/packages/core/crmManager/crmManager.test.ts +++ b/packages/core/crmManager/crmManager.test.ts @@ -1,8 +1,9 @@ +import { mockCrmApp } from "@calcom/web/test/utils/bookingScenario/bookingScenario"; + import type { TFunction } from "next-i18next"; import { describe, expect, test, vi } from "vitest"; import { getCrm } from "@calcom/app-store/_utils/getCrm"; -import { mockCrmApp } from "@calcom/web/test/utils/bookingScenario/bookingScenario"; import CrmManager from "./crmManager"; diff --git a/packages/features/bookings/lib/getAllCredentialsForUsersOnEvent/getAllCredentials.test.ts b/packages/features/bookings/lib/getAllCredentialsForUsersOnEvent/getAllCredentials.test.ts index 1f76809d09..70a6d76d0f 100644 --- a/packages/features/bookings/lib/getAllCredentialsForUsersOnEvent/getAllCredentials.test.ts +++ b/packages/features/bookings/lib/getAllCredentialsForUsersOnEvent/getAllCredentials.test.ts @@ -1,6 +1,3 @@ -import { describe, test, expect, vi } from "vitest"; - -import { UserRepository } from "@calcom/lib/server/repository/user"; import { createCredentials, addTeamsToDb, @@ -8,6 +5,10 @@ import { addUsersToDb, } from "@calcom/web/test/utils/bookingScenario/bookingScenario"; +import { describe, test, expect, vi } from "vitest"; + +import { UserRepository } from "@calcom/lib/server/repository/user"; + // vi.mock("@calcom/lib/server/repository/user", () => { // return { // enrichUserWithItsProfile diff --git a/packages/trpc/server/routers/loggedInViewer/deleteCredential.handler.ts b/packages/trpc/server/routers/loggedInViewer/deleteCredential.handler.ts index 8dd1bd6805..f2fc7b6c96 100644 --- a/packages/trpc/server/routers/loggedInViewer/deleteCredential.handler.ts +++ b/packages/trpc/server/routers/loggedInViewer/deleteCredential.handler.ts @@ -345,7 +345,7 @@ export const deleteCredentialHandler = async ({ ctx, input }: DeleteCredentialOp }); } } else if ( - (appStoreMetadata[credential.app?.slug as keyof typeof appStoreMetadata].extendsFeature = "EventType") + appStoreMetadata[credential.app?.slug as keyof typeof appStoreMetadata]?.extendsFeature === "EventType" ) { const metadata = EventTypeMetaDataSchema.parse(eventType.metadata); const appSlug = credential.app?.slug;