chore: disable apps with missing required keys (#27012)
* ci(companion): add separate typecheck workflow to catch type errors This adds a new companion-typecheck.yml workflow that runs TypeScript type checking for the companion app. This would have caught the missing useEffect import issue in PR #26931. Changes: - Add new companion-typecheck.yml workflow file - Update pr.yml to call the new workflow when companion files change - Add typecheck-companion to the required jobs list Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * add lint checks * test * remove * update typecheck * address review * chore:- hide apps with missing required keys from app store * update * Delete packages/app-store/_utils/hasRequiredAppKeys.test.ts * Update validateAppKeys.ts * Update validateAppKeys.ts * Update validateAppKeys.test.ts --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
5 files changed
+215
-3
No files matched your search
@@ -6,6 +6,7 @@ import dotEnv from "dotenv";
|
||||
import path from "node:path"
|
||||
|
||||
import { appStoreMetadata } from "@calcom/app-store/appStoreMetaData";
|
||||
import { shouldEnableApp } from "@calcom/app-store/_utils/validateAppKeys";
|
||||
import prisma from "@calcom/prisma";
|
||||
import type { Prisma } from "@calcom/prisma/client";
|
||||
import { AppCategories } from "@calcom/prisma/enums";
|
||||
@@ -48,8 +49,9 @@ async function createApp(
|
||||
},
|
||||
});
|
||||
|
||||
// We need to enable seeded apps as they are used in tests.
|
||||
const data = { slug, dirName, categories, keys, enabled: true };
|
||||
// Only enable apps if they have valid keys (or don't require keys)
|
||||
const enabled = shouldEnableApp(dirName, keys as Prisma.JsonValue);
|
||||
const data = { slug, dirName, categories, keys, enabled };
|
||||
|
||||
if (!foundApp) {
|
||||
await prisma.app.create({
|
||||
|
||||
Reference in new issue
Block a user