From b1bbbcee90e3ccc34f14228c8023d80a1bde322f Mon Sep 17 00:00:00 2001
From: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Date: Fri, 24 May 2024 00:36:30 +0530
Subject: [PATCH] fix: signing_up_terms i18n (#15156)

Co-authored-by: Keith Williams <keithwillcode@gmail.com>
---
 apps/web/pages/signup.tsx                     | 36 ++++++++++---------
 apps/web/public/static/locales/en/common.json |  2 +-
 .../BookEventForm/BookEventForm.tsx           | 30 ++++++++++------
 3 files changed, 39 insertions(+), 29 deletions(-)

diff --git a/apps/web/pages/signup.tsx b/apps/web/pages/signup.tsx
index 7bfa0a60bf..a01d18f46f 100644
--- a/apps/web/pages/signup.tsx
+++ b/apps/web/pages/signup.tsx
@@ -538,23 +538,25 @@ export default function Signup({
                   </Link>
                 </div>
                 <div className="text-subtle ">
-                  <Trans i18nKey="signing_up_terms">
-                    By proceeding, you agree to our{" "}
-                    <Link
-                      className="text-emphasis hover:underline"
-                      href={`${WEBSITE_URL}/terms`}
-                      target="_blank">
-                      Terms
-                    </Link>{" "}
-                    and{" "}
-                    <Link
-                      className="text-emphasis hover:underline"
-                      href={`${WEBSITE_URL}/privacy`}
-                      target="_blank">
-                      Privacy Policy
-                    </Link>
-                    .
-                  </Trans>
+                  <Trans
+                    i18nKey="signing_up_terms"
+                    components={[
+                      <Link
+                        className="text-emphasis hover:underline"
+                        key="terms"
+                        href={`${WEBSITE_URL}/terms`}
+                        target="_blank">
+                        Terms
+                      </Link>,
+                      <Link
+                        className="text-emphasis hover:underline"
+                        key="privacy"
+                        href={`${WEBSITE_URL}/privacy`}
+                        target="_blank">
+                        Privacy Policy.
+                      </Link>,
+                    ]}
+                  />
                 </div>
               </div>
             </div>
diff --git a/apps/web/public/static/locales/en/common.json b/apps/web/public/static/locales/en/common.json
index 2ec5493f9a..baa0df45da 100644
--- a/apps/web/public/static/locales/en/common.json
+++ b/apps/web/public/static/locales/en/common.json
@@ -2442,7 +2442,7 @@
   "lowest_rated_members": "Members with lowest rated meetings",
   "csat_score": "CSAT Score",
   "lockedSMS": "Locked SMS",
-  "signing_up_terms": "By proceeding, you agree to our <1>Terms</1> and <2>Privacy Policy</2>.",
+  "signing_up_terms": "By proceeding, you agree to our <0>Terms</0> and <1>Privacy Policy</1>.",
   "always_show_x_days": "Always {{x}} days available",
   "unable_to_subscribe_to_the_platform": "An error occurred while trying to subscribe to the platform plan, please try again later",
   "updating_oauth_client_error": "An error occurred while updating the OAuth client, please try again later",
diff --git a/packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx b/packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx
index 7dd9f8da4d..d5d09ebc7e 100644
--- a/packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx
+++ b/packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx
@@ -114,17 +114,25 @@ export const BookEventForm = ({
         )}
         {!isPlatform && IS_CALCOM && (
           <div className="text-subtle my-3 w-full text-xs opacity-80">
-            <Trans i18nKey="signing_up_terms">
-              By proceeding, you agree to our
-              <Link className="text-emphasis hover:underline" href={`${WEBSITE_URL}/terms`} target="_blank">
-                Terms
-              </Link>{" "}
-              and{" "}
-              <Link className="text-emphasis hover:underline" href={`${WEBSITE_URL}/privacy`} target="_blank">
-                Privacy Policy
-              </Link>
-              .
-            </Trans>
+            <Trans
+              i18nKey="signing_up_terms"
+              components={[
+                <Link
+                  className="text-emphasis hover:underline"
+                  key="terms"
+                  href={`${WEBSITE_URL}/terms`}
+                  target="_blank">
+                  Terms
+                </Link>,
+                <Link
+                  className="text-emphasis hover:underline"
+                  key="privacy"
+                  href={`${WEBSITE_URL}/privacy`}
+                  target="_blank">
+                  Privacy Policy.
+                </Link>,
+              ]}
+            />
           </div>
         )}
         <div className="modalsticky mt-auto flex justify-end space-x-2 rtl:space-x-reverse">