From b53abe93bce10844b0f3f4322d0b9124153a5e59 Mon Sep 17 00:00:00 2001 From: Benny Joo Date: Fri, 25 Oct 2024 14:51:33 -0400 Subject: [PATCH] feat: display number of rows in routing form reporting (#17334) * add rows and row to english common.json * feat: display number of rows in routing form reporting --- apps/web/public/static/locales/en/common.json | 2 ++ .../routing-forms/pages/reporting/[...appPages].tsx | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/apps/web/public/static/locales/en/common.json b/apps/web/public/static/locales/en/common.json index 9cd873ae6d..df788d17cf 100644 --- a/apps/web/public/static/locales/en/common.json +++ b/apps/web/public/static/locales/en/common.json @@ -2699,5 +2699,7 @@ "confirm_reassign_unavailable": "Manual Reassign to unavailable host", "reassign_unavailable_team_member_description": "Are you sure you want to reassign this booking to an unavailable host?", "yes_reassign": "Yes, reassign", + "row": "row", + "rows": "rows", "ADD_NEW_STRINGS_ABOVE_THIS_LINE_TO_PREVENT_MERGE_CONFLICTS": "↑↑↑↑↑↑↑↑↑↑↑↑↑ Add your new strings above here ↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑" } diff --git a/packages/app-store/routing-forms/pages/reporting/[...appPages].tsx b/packages/app-store/routing-forms/pages/reporting/[...appPages].tsx index c372a04c22..715cd169c5 100644 --- a/packages/app-store/routing-forms/pages/reporting/[...appPages].tsx +++ b/packages/app-store/routing-forms/pages/reporting/[...appPages].tsx @@ -61,9 +61,15 @@ const Result = ({ formId, jsonLogicQuery }: { formId: string; jsonLogicQuery: Js return
Error loading report {error?.message}
; } headers.current = (data?.pages && data?.pages[0]?.headers) || headers.current; + const numberOfRows = data?.pages.reduce((total, page) => total + (page.responses?.length || 0), 0); return (
+ {!isPending && ( +
+ {`${numberOfRows} ` + (numberOfRows === 1 ? t("row") : t("rows"))} +
+ )}