From d6f6be7d50c480a08f85ec3423200726e76a7d43 Mon Sep 17 00:00:00 2001 From: Emmanuel Isenah <86387828+Armadillidiid@users.noreply.github.com> Date: Sat, 15 Nov 2025 21:20:50 +0100 Subject: [PATCH] fix: correct square image validation logic in resizeBase64Image (#25130) The validation was comparing image height to itself instead of comparing height to width, causing the square check to always pass even for non-square images. Co-authored-by: Dhairyashil Shinde <93669429+dhairyashiil@users.noreply.github.com> --- packages/lib/server/resizeBase64Image.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/lib/server/resizeBase64Image.ts b/packages/lib/server/resizeBase64Image.ts index 548b62c431..da911016e2 100644 --- a/packages/lib/server/resizeBase64Image.ts +++ b/packages/lib/server/resizeBase64Image.ts @@ -26,7 +26,7 @@ export async function resizeBase64Image( maxSize = 96 * 4, } = opts ?? {}; const image = await jimp.read(buffer); - if (image.getHeight() !== image.getHeight()) { + if (image.getHeight() !== image.getWidth()) { // this could be handled later throw new Error("Image is not a square"); }