chore: IsTeamInOrg guard and decorator apiv2 (#15567)

This commit is contained in:
Morgan authored and GitHub committed 2024-06-26 07:32:49 +00:00
1 parent d431607125
commit ec755b142c
5 files changed
+124

No files matched your search

@@ -22,7 +22,10 @@ describe("Organizations Team Endpoints", () => {
let userRepositoryFixture: UserRepositoryFixture;
let organizationsRepositoryFixture: TeamRepositoryFixture;
let teamsRepositoryFixture: TeamRepositoryFixture;
let org: Team;
let team: Team;
const userEmail = "org-teams-controller-e2e@api.com";
let user: User;
@@ -37,6 +40,7 @@ describe("Organizations Team Endpoints", () => {
userRepositoryFixture = new UserRepositoryFixture(moduleRef);
organizationsRepositoryFixture = new TeamRepositoryFixture(moduleRef);
teamsRepositoryFixture = new TeamRepositoryFixture(moduleRef);
user = await userRepositoryFixture.create({
email: userEmail,
@@ -48,6 +52,12 @@ describe("Organizations Team Endpoints", () => {
isOrganization: true,
});
team = await teamsRepositoryFixture.create({
name: "Test org team",
isOrganization: false,
parent: { connect: { id: org.id } },
});
app = moduleRef.createNestApplication();
bootstrap(app as NestExpressApplication);
@@ -72,6 +82,26 @@ describe("Organizations Team Endpoints", () => {
});
});
it("should fail if org does not exist", async () => {
return request(app.getHttpServer()).get(`/v2/organizations/120494059/teams`).expect(403);
});
it("should get the team of the org", async () => {
return request(app.getHttpServer())
.get(`/v2/organizations/${org.id}/teams/${team.id}`)
.expect(200)
.then((response) => {
const responseBody: ApiSuccessResponse<Team> = response.body;
expect(responseBody.status).toEqual(SUCCESS_STATUS);
expect(responseBody.data.id).toEqual(team.id);
expect(responseBody.data.parentId).toEqual(team.parentId);
});
});
it("should fail if the team does not exist", async () => {
return request(app.getHttpServer()).get(`/v2/organizations/${org.id}/teams/123132145`).expect(403);
});
afterAll(async () => {
await userRepositoryFixture.deleteByEmail(user.email);
await organizationsRepositoryFixture.delete(org.id);
@@ -1,7 +1,9 @@
import { API_VERSIONS_VALUES } from "@/lib/api-versions";
import { GetOrg } from "@/modules/auth/decorators/get-org/get-org.decorator";
import { GetTeam } from "@/modules/auth/decorators/get-team/get-team.decorator";
import { ApiAuthGuard } from "@/modules/auth/guards/api-auth/api-auth.guard";
import { IsOrgGuard } from "@/modules/auth/guards/organizations/is-org.guard";
import { IsTeamInOrg } from "@/modules/auth/guards/teams/is-team-in-org.guard";
import { Controller, UseGuards, Get, Param, ParseIntPipe } from "@nestjs/common";
import { ApiTags as DocsTags } from "@nestjs/swagger";
@@ -28,4 +30,20 @@ export class OrganizationsTeamsController {
data: [],
};
}
@UseGuards(IsTeamInOrg)
@Get("/:teamId")
async getTeam(
@Param("orgId", ParseIntPipe) orgId: number,
@Param("teamId", ParseIntPipe) teamId: number,
@GetOrg() organization: Team,
@GetTeam() team: Team,
@GetOrg("name") orgName: string
): Promise<ApiResponse<Team>> {
console.log(teamId, orgId, organization, team, orgName);
return {
status: SUCCESS_STATUS,
data: team,
};
}
}