* refactor: FailedBookingsByField to use Insights Routing Service
- Move getFailedBookingsByRoutingFormGroup logic to InsightsRoutingBaseService
- Replace legacy getWhereForTeamOrAllTeams with getBaseConditions()
- Add failedBookingsByFieldInputSchema with date filtering support
- Update tRPC endpoint to use createInsightsRoutingService pattern
- Update component to pass startDate/endDate parameters
- Remove legacy method from routing-events.ts
Follows same pattern as PR #23031 for RoutedToPerPeriod refactoring
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* fix: use useInsightsRoutingParameters hook in FailedBookingsByField
- Add missing import for useInsightsRoutingParameters
- Update component to follow same pattern as PR #23031
- Add columnFilters support to failedBookingsByFieldInputSchema
- Maintain routingFormId parameter from useInsightsParameters
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* refactor: remove separate routingFormId parameter
- Remove routingFormId parameter from getFailedBookingsByFieldData method
- Update component to only use insightsRoutingParameters
- Remove routingFormId from failedBookingsByFieldInputSchema
- Let getBaseConditions handle all filtering including routing form filtering
- Simplify tRPC endpoint to not pass separate routingFormId
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* clean up
* fix
* refactor: use RoutingFormResponseDenormalized directly in getFailedBookingsByFieldData
- Replace complex CTE approach with direct denormalized table query
- Join with App_RoutingForms_Form to access field definitions from JSON
- Use RoutingFormResponseField for response values
- Filter failed bookings with bookingUid IS NULL
- Maintain same data structure for UI compatibility
- Follow existing service patterns for authorization and date filtering
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* fixing failed bookings query
* fix query
* fix integration test
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* fix: refactor RoutedToPerPeriod to use Insights Routing Service
* clean up
* debounce search and increase stale time
* fix wrongn conflict merge
* clean up DownloadButton
* fix query error
* address feedback
* apply feedback
* remove unnecessary CTE
* fix limit
* make startDate and endDate required
* fix type
* remove irrelevant test case
* address feedback
* refactor: improve most booked & least booked
* add 2 new charts and trpc handlers
* update arg
* update comment
* completed booking filter
* update
* add change in component level and remove unused translations
* current time and accepted status logic handler
* resize some charts
* restore some i18n
* restore i18n
* restore i18n
---------
Co-authored-by: Eunjae Lee <hey@eunjae.dev>
* refactor: convert findQualifiedHostsWithDelegationCredentials to service class with DI
- Create QualifiedHostsService class following UserAvailabilityService pattern
- Add IQualifiedHostsService interface with prisma and bookingRepo dependencies
- Create DI module and container for qualified hosts service
- Update filterHostsBySameRoundRobinHost to accept prisma as parameter
- Update all usage sites to use the new service:
- loadAndValidateUsers.ts
- slots/util.ts
- test mocks in _post.test.ts
- Maintain backward compatibility with original function export
- Fix type issues in team properties (rrResetInterval, rrTimestampBasis)
Co-Authored-By: morgan@cal.com <morgan@cal.com>
* fix: update filterHostsBySameRoundRobinHost test to include prisma parameter
- Add missing prisma parameter to all test function calls
- Resolves unit test failure caused by function signature change
Co-Authored-By: morgan@cal.com <morgan@cal.com>
* fix: resolve type issues in FilterHostsService
- Import PrismaClient type instead of using unknown
- Fix type compatibility for BookingRepository constructor
- Update test mocks to use proper BookingRepository type
- Ensure all DI dependencies are properly typed
Co-Authored-By: morgan@cal.com <morgan@cal.com>
* refactor: rename DI files to CamelCase and update imports
- Rename all files in packages/lib/di from kebab-case to CamelCase
- Update 22 external files with import statements to use new file names
- Update internal DI module files with corrected imports
- Maintain consistency with TypeScript naming conventions
Co-Authored-By: morgan@cal.com <morgan@cal.com>
* chore: bump platform libs
* chore: bump platform libs
* fix: remove obsolete vitest mock after service class refactoring
- Remove obsolete mock for old function module
- Keep correct mock for new DI container
- Resolves CI unit test failures
Co-Authored-By: morgan@cal.com <morgan@cal.com>
* fix: correct import path for calAIPhone zod-utils module
Co-Authored-By: morgan@cal.com <morgan@cal.com>
* fix: Booker active booking limit can't be switched off (#23005)
* refactor: Get rid of `getServerSideProps` for /getting-started pages (#23003)
* refactor
* fix type check
* fix: Remove Reporting page within Routing Forms (#22990)
* fix error in handleNewBooking (#23011)
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
* Documentation edits made through Mintlify web editor (#23007)
Co-authored-by: mintlify[bot] <109931778+mintlify[bot]@users.noreply.github.com>
* fix: Contact support button position changed from absolute to fixed (#23002)
* feat: Add private links to API (#22943)
* --init
* address change requests
* adding further changes
* address feedback
* further changes
* further clean-up
* clean up
* fix module import and others
* add guards
* remove unnecessary comments
* remove unnecessary comments
* cleanup
* sort coderabbig suggestions
* improve check
* chore: bump platform libraries
---------
Co-authored-by: Lauris Skraucis <lauris.skraucis@gmail.com>
Co-authored-by: supalarry <laurisskraucis@gmail.com>
* chore: release v5.5.15
* chore: bump platform libs
* chore: bump platform libs
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: morgan@cal.com <morgan@cal.com>
Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
Co-authored-by: Benny Joo <sldisek783@gmail.com>
Co-authored-by: Sahitya Chandra <sahityajb@gmail.com>
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Co-authored-by: mintlify[bot] <109931778+mintlify[bot]@users.noreply.github.com>
Co-authored-by: Ayush Kumar <kumarayushkumar@protonmail.com>
Co-authored-by: Syed Ali Shahbaz <52925846+alishaz-polymath@users.noreply.github.com>
Co-authored-by: Lauris Skraucis <lauris.skraucis@gmail.com>
Co-authored-by: supalarry <laurisskraucis@gmail.com>
Co-authored-by: emrysal <me@alexvanandel.com>
* refactor: use dependency injection for InsightsBookingService
- Add DI tokens for InsightsBookingService and module
- Rename InsightsBookingService to InsightsBookingBaseService
- Create InsightsBookingService DI interface with create method
- Add DI module and container for InsightsBookingService
- Update tRPC router to use getInsightsBookingService DI container
- Update test file to use InsightsBookingBaseService
- Update documentation to reflect new DI pattern
Follows the same dependency injection pattern established for InsightsRoutingService in PR #22677
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* refactor: restore createInsightsBookingService helper using DI internally
- Keep createInsightsBookingService helper function for cleaner API
- Use getInsightsBookingService DI container internally
- Maintain same function signature and behavior
- All existing calls continue to work unchanged
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* refactor: rename service files with proper capitalization
- Rename insightsBookingBase.ts to InsightsBookingBaseService.ts
- Rename insightsBookingDI.ts to InsightsBookingDIService.ts
- Update all import statements to use new file names
- Maintain existing handler functionality using createInsightsBookingService(ctx, input)
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* revert some changes
* rename
* update doc
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* refactor: event trends chart on /insights to use InsightsBookingService
* extract service instantiation
* remove unused code
* rename from eventsTimeline to eventTrends
* clean up
---------
Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
* feat: add formatPeriodStraightforward method for comprehensive date formatting
- Add new formatPeriodStraightforward method that always shows full date information
- Update DateRange interface to include formattedDateStraightforward field
- Modify getDateRanges to generate both formatted versions
- Add comprehensive unit tests for the new straightforward formatting
- Maintain backward compatibility with existing formatPeriod method
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* refactor: rename formatPeriodStraightforward to formatPeriodFull
- Rename method from formatPeriodStraightforward to formatPeriodFull
- Rename interface field from formattedDateStraightforward to formattedDateFull
- Update all test cases to use new method name
- All tests continue to pass with new naming
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* test: add comprehensive getDateRanges formatting comparison tests
- Add 7 new test cases that call getDateRanges directly
- Demonstrate side-by-side comparison of formattedDate vs formattedDateFull
- Cover daily, weekly, and monthly view formatting differences
- Include real-world usage examples showing practical benefits
- All 65 tests pass including new formatting comparison tests
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* refactor: extract formattedDate arrays in getDateRanges comparison tests
- Refactor all 6 tests in 'getDateRanges - Formatting Comparison' suite
- Extract formattedDate and formattedDateFull arrays separately
- Use clean expect statements for easier visual review
- Remove startDate/endDate checks as requested
- Maintain all existing test scenarios and expected values
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* clean up
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Benny Joo <sldisek783@gmail.com>
* feat: add attendee data to CSV export with seated event support
- Add up to 3 attendees to CSV export in 'name (email)' format
- Use booking.seatsReferences for seated events, booking.attendees for regular events
- Maintain backward compatibility with existing bookerEmail/bookerName fields
- Add attendee1, attendee2, attendee3 columns to CSV output
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* fix: restore missing comment as requested in PR review
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* Update packages/features/insights/server/events.ts
* feat: remove duplicate booker columns from CSV export
- Remove bookerEmail and bookerName columns as they duplicate attendee data
- Remove noShowGuest field which was based on booker data
- Remove unused booker field from bookingMap
- Keep only attendee1, attendee2, attendee3 columns with name (email) format
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* feat: restore noShowGuest field to CSV export
- Add noShowGuest field mapping from first attendee's noShow property
- Maintain existing attendee1, attendee2, attendee3 columns
- Default to false when no attendees exist
- Works with both seated events and regular events
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
* rename column
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: eunjae@cal.com <hey@eunjae.dev>
* feat: optimize Prisma queries by replacing findFirst with findUnique where applicable
- Replace findFirst/findFirstOrThrow with findUnique/findUniqueOrThrow for queries using unique constraints
- Maintain existing functionality and error handling behavior
- Focus on queries using primary keys and unique index fields from schema
- Revert problematic changes that caused test failures to maintain stability
Co-Authored-By: benny@cal.com <benny@cal.com>
* revert: exclude API files from Prisma query optimizations per user request
- Reverted all 55 API-related files to their original state
- Kept all non-API Prisma query optimizations intact
- API files include apps/api/v1, apps/api/v2, apps/web/app/api, and packages/app-store/*/api
- Non-API optimizations remain for packages/lib, packages/features, apps/web (non-api), etc.
Co-Authored-By: benny@cal.com <benny@cal.com>
* feat: optimize membership query in attributeUtils to use findUnique with userId_teamId constraint
Co-Authored-By: benny@cal.com <benny@cal.com>
* revert: exclude test files from Prisma query optimizations per user request
Co-Authored-By: benny@cal.com <benny@cal.com>
* revert: revert attributeUtils.ts to use findFirst for test compatibility
Co-Authored-By: benny@cal.com <benny@cal.com>
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: benny@cal.com <benny@cal.com>
Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
* test: Add unit tests for buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Export buildBaseWhereCondition function instead of copying it
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Remove implementation detail checks from tests
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* test: Fix tests to match actual function behavior
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* test: Fix test issues with buildBaseWhereCondition
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* test: Update tests to match actual function behavior
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* fix: Address security issues in buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Simplify buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Simplify code and remove isEmptyResponse property
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Use array of conditions approach for buildBaseWhereCondition
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Make buildBaseWhereCondition implementation consistent and update tests
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* fix: Fix incorrect usage of buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* chore: Revert yarn.lock changes
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* fix: Comment out non-existent Sentry API method to fix type error
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* Revert "fix: Comment out non-existent Sentry API method to fix type error"
This reverts commit 44c21a7396a518c63047b33967cd8af7e6e4f268.
* remove unnecessary if-statement
* fix: replace bookingTimeStatus with bookingTimeStatusDenormalized
* change column
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: eunjae@cal.com <eunjae@cal.com>
* test: Add unit tests for buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Export buildBaseWhereCondition function instead of copying it
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Remove implementation detail checks from tests
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* test: Fix tests to match actual function behavior
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* test: Fix test issues with buildBaseWhereCondition
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* test: Update tests to match actual function behavior
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* fix: Address security issues in buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Simplify buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Simplify code and remove isEmptyResponse property
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Use array of conditions approach for buildBaseWhereCondition
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* refactor: Make buildBaseWhereCondition implementation consistent and update tests
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* fix: Fix incorrect usage of buildBaseWhereCondition function
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* chore: Revert yarn.lock changes
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* fix: Comment out non-existent Sentry API method to fix type error
Co-Authored-By: eunjae@cal.com <eunjae@cal.com>
* Revert "fix: Comment out non-existent Sentry API method to fix type error"
This reverts commit 44c21a7396a518c63047b33967cd8af7e6e4f268.
* remove unnecessary if-statement
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: eunjae@cal.com <eunjae@cal.com>
Co-authored-by: Eunjae Lee <hey@eunjae.dev>
* Refactors related to enabling typescript 5.3.3 in @calcom/trpc
* Also skip respective tests (obviously logic is broken)
* This causes problems for some reason, revert
* Bring back QueryCell as it's used by atoms
Found via `codespell -q 3 -S "*.svg,./apps/web/public/static/locales,./packages/app-store/stripepayment/lib/currencyOptions.ts,./packages/lib/freeEmailDomainCheck/freeEmailDomains.ts" -L afterall,atleast,datea,fo,incase,ist,nam,notin,optionel,perview,reccuring`
Closes#19219
Eunjae LeeandDevin AI
Anirban SinghaandKartik Saini
Bandhan MajumderandEunjae Lee
Shaunak DasandUdit Takkar
Vincent Lamandamrit
luzpaz
Syed Ali Shahbaz
