Files
Benny JooandDevin AI f5d345b133 refactor: remove @calcom/web imports from @calcom/features and add @calcom/testing package (#26480)
* fix: remove @calcom/web imports from packages/features to eliminate circular dependency

- Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts
- Migrate useGeo hook to packages/features/geo/GeoContext.tsx
- Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts
- Migrate Calendar component to packages/features/calendars/weeklyview/components/
- Move test utilities (bookingScenario, fixtures) to packages/features/test/
- Update all imports in packages/features to use new locations
- Add re-exports in apps/web for backward compatibility

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: delete original implementation files and fix type issues

- Delete original calendar component files in apps/web (keep only re-export stubs)
- Migrate OutOfOfficeInSlots to packages/features/bookings/components
- Convert apps/web OutOfOfficeInSlots to re-export stub
- Fix className vs class issue in Calendar.tsx
- Fix @calcom/trpc import violation in user-table.ts by using structural type

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing isGroup and contains fields to UserTableUser attributes type

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update customRole type to match actual Prisma Role model

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix build

* fix

* fix

* cleanup weeklyview

* fix

* refactor to mv MemberPermissions to types package

* add types dependency to features

* fix

* fix

* fix

* fix

* fix

* fix

* rename

* rename

* migrate

* migrate

* migrate

* fix

* fix

* fix

* refactor: move test utilities from packages/features/test to tests/libs

- Move bookingScenario utilities to tests/libs/bookingScenario
- Move fixtures to tests/libs/fixtures
- Update all imports in packages/features test files to use new location
- Update all imports in apps/web test files to use new location
- Eliminates duplication of test utilities between packages/features and apps/web

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: correct relative import paths for tests/libs in test files

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: replace test utility implementations with re-exports to tests/libs

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: fix test import paths and move signup handler tests to apps/web

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features

- Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency
- Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib
- Restore signup handlers and tests to packages/features/auth/signup/handlers
- Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update recurring-event.test.ts imports to use tests/libs path

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: delete test re-export files and update imports to use tests/libs directly

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update remaining test imports to use tests/libs directly

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update handleRecurringEventBooking calls to match function signature (1 arg)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* remove

* migrate tests

* migrate tests

* refactor: update test mock imports by removing  and using async  for mock creators.

* fix type errors

* fix: add type assertion for MockUser in p2002.test-suite.ts

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* feat: create @calcom/testing package and migrate tests from /tests directory

- Created new @calcom/testing package in /packages/testing
- Moved all files from /tests to /packages/testing
- Updated all imports across the codebase to use @calcom/testing alias
- Removed /tests directory at root level

This allows other packages like @calcom/features and @calcom/web to import
testing utilities using the @calcom/testing alias instead of relative paths.

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* fix

* fix: add missing useBookings export to @calcom/atoms package

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* chore: add @calcom/testing as explicit devDependency to packages that use it

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: move setupVitest.ts into @calcom/testing package

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* chore: add biome rules to restrict @calcom/testing imports

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* rename libs to lib

* rename libs to lib

* add rule

* add rule

* refactor: remove @calcom/features imports from @calcom/testing

- Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts
- Replace ProfileRepository.generateProfileUid() with uuidv4()
- Clone Tracking type into @calcom/testing/src/lib/types.ts
- Update imports in expects.ts and getMockRequestDataForBooking.ts
- Move source files into src/ folder
- Move CalendarManager mock to @calcom/features

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add explicit exports for nested paths in @calcom/testing

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* improve

* improve

* fix

* fix

* fix type checks

* fix type checks

* fix type checks

* fix tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-01-08 16:59:11 +09:00

400 lines
9.3 KiB
TypeScript

/* eslint-disable @typescript-eslint/ban-ts-comment */
// @ts-nocheck
// TODO: Bring this test back with the correct setup (no illegal imports)
import prismock from "@calcom/testing/lib/__mocks__/prisma";
import { describe, it, beforeEach, vi, expect } from "vitest";
import { MembershipRole } from "@calcom/prisma/enums";
import type { TrpcSessionUser } from "../../../types";
import { bulkDeleteUsersHandler } from "./bulkDeleteUsers.handler";
const getBaseUserInfo = (
team: { id: number; name: string; slug: string },
orgId: number,
role: MembershipRole
): Pick<
ReturnType<typeof getOrganizer>,
"teams" | "organizationId" | "schedules" | "completedOnboarding"
> => {
return {
completedOnboarding: true,
organizationId: orgId,
schedules: [TestData.schedules.IstWorkHours],
teams: [
{
membership: {
role,
accepted: true,
},
team,
},
],
};
};
describe.skip("Bulk Delete Users handler", () => {
beforeEach(() => {
vi.clearAllMocks();
});
it(`should:
1: Remove memberships of users
2: Update user info
3: Remove profiles of users
4: Not remove user events of removed users
5: Remove host assignment from child team events of removed users
6: Remove managed events of removed users
`, async () => {
const org = {
id: 1,
name: "Parent org",
slug: "parent-org",
};
await addTeamsToDb([org]);
const team = {
id: 2,
name: "Team 1",
slug: "team-1",
parentId: org.id,
};
const orgOwner = getOrganizer({
id: 101,
name: "teamOwner",
email: "owner@user.com",
...getBaseUserInfo(team, org.id, "OWNER"),
organizationId: 1,
});
await prismock.membership.create({
data: {
userId: orgOwner.id,
teamId: 1,
role: MembershipRole.OWNER,
accepted: true,
},
});
const userToBeRemoved1 = getOrganizer({
id: 102,
name: "memberUser1",
email: "member1@user.com",
...getBaseUserInfo(team, org.id, "MEMBER"),
});
const userToBeRemoved1Event1: ScenarioData["eventTypes"][0] = {
id: 1,
title: "User 1 Event 1",
slug: "user1-event1",
slotInterval: 30,
length: 30,
userId: userToBeRemoved1.id,
};
const userToBeRemoved2 = getOrganizer({
id: 103,
name: "memberUser2",
email: "member2@user.com",
...getBaseUserInfo(team, org.id, "MEMBER"),
});
const userToBeRemoved2Event1: ScenarioData["eventTypes"][0] = {
id: 2,
title: "User 2 Event 1",
slug: "user2-event1",
slotInterval: 30,
length: 30,
userId: userToBeRemoved2.id,
};
const userNotToBeRemoved = getOrganizer({
id: 104,
name: "memberUser3",
email: "member3@user.com",
...getBaseUserInfo(team, org.id, "MEMBER"),
});
const userNotToBeRemovedEvent1: ScenarioData["eventTypes"][0] = {
id: 3,
title: "User 3 Event 1",
slug: "user3-event1",
slotInterval: 30,
length: 30,
userId: userNotToBeRemoved.id,
};
const roundRobinEvent: ScenarioData["eventTypes"][0] = {
id: 4,
title: "Round Robin Event",
slug: "round-robin-event",
schedulingType: "ROUND_ROBIN",
slotInterval: 30,
length: 30,
teamId: team.id,
hosts: [
{
userId: userToBeRemoved1.id,
},
{
userId: userToBeRemoved2.id,
},
{
userId: orgOwner.id,
},
{
userId: userNotToBeRemoved.id,
},
],
};
const parentManagedEvent: ScenarioData["eventTypes"][0] = {
id: 5,
title: "Parent Managed Event",
slug: "parent-managed-event",
teamId: team.id,
slotInterval: 30,
length: 30,
};
const user1ToBeRemovedManagedEvent: ScenarioData["eventTypes"][0] = {
id: 6,
title: "User 1 Managed Event",
slug: "user1-managed-event",
slotInterval: 30,
length: 30,
userId: userToBeRemoved1.id,
parent: {
id: parentManagedEvent.id,
},
};
const user2ToBeRemovedManagedEvent: ScenarioData["eventTypes"][0] = {
id: 7,
title: "User 2 Managed Event",
slug: "user2-managed-event",
slotInterval: 30,
length: 30,
userId: userToBeRemoved2.id,
parent: {
id: parentManagedEvent.id,
},
};
const userNotToBeRemovedManagedEvent: ScenarioData["eventTypes"][0] = {
id: 8,
title: "User 3 Managed Event",
slug: "user3-managed-event",
slotInterval: 30,
length: 30,
userId: userNotToBeRemoved.id,
parent: {
id: parentManagedEvent.id,
},
};
parentManagedEvent.children = {
connect: [
{
id: user1ToBeRemovedManagedEvent.id,
},
{
id: user2ToBeRemovedManagedEvent.id,
},
{
id: userNotToBeRemovedManagedEvent.id,
},
],
};
await createBookingScenario(
getScenarioData(
{
eventTypes: [
userToBeRemoved1Event1,
userToBeRemoved2Event1,
roundRobinEvent,
parentManagedEvent,
user1ToBeRemovedManagedEvent,
user2ToBeRemovedManagedEvent,
userNotToBeRemovedManagedEvent,
userNotToBeRemovedEvent1,
],
organizer: orgOwner,
usersApartFromOrganizer: [userToBeRemoved1, userToBeRemoved2, userNotToBeRemoved],
},
{ id: 1 }
)
);
const { id, name, organizationId } = orgOwner;
const ctx = {
user: {
id,
name,
organizationId,
} as NonNullable<TrpcSessionUser>,
};
const membersToRemove = [userToBeRemoved2.id, userToBeRemoved1.id];
const res = await bulkDeleteUsersHandler({
ctx,
input: {
userIds: membersToRemove,
},
});
expect(res.success).toBe(true);
expect(res.usersDeleted).toBe(2);
//Memberships of removed users should be deleted
const remainingMemberships = await prismock.membership.findMany({
where: {
teamId: team.id,
},
select: {
userId: true,
},
});
expect(remainingMemberships).toEqual([{ userId: orgOwner.id }, { userId: userNotToBeRemoved.id }]);
//User info should be updated of removed users
const removedUsers = await prismock.user.findMany({
where: {
id: {
in: membersToRemove,
},
},
select: {
id: true,
organizationId: true,
username: true,
completedOnboarding: true,
},
});
expect(removedUsers).toEqual([
{
organizationId: null,
id: userToBeRemoved1.id,
username: null,
completedOnboarding: false,
},
{
id: userToBeRemoved2.id,
organizationId: null,
username: null,
completedOnboarding: false,
},
]);
//Only the profiles of the removed users should be removed
const remainingProfiles = await prismock.profile.findMany({
where: {
organizationId: org.id,
},
select: {
userId: true,
},
});
expect(remainingProfiles).toEqual([{ userId: orgOwner.id }, { userId: userNotToBeRemoved.id }]);
//User events of org members should not be removed
const userEvents = await prismock.eventType.findMany({
where: {
userId: {
in: [...membersToRemove, userNotToBeRemoved.id],
},
teamId: null,
parentId: null,
},
select: {
id: true,
title: true,
slug: true,
},
});
expect(userEvents.length).toBe(3);
// Host assignment from child team events of removed users should be deleted
const teamEvent = await prismock.eventType.findFirst({
where: {
id: roundRobinEvent.id,
},
select: {
hosts: {
select: {
userId: true,
},
},
},
});
expect(teamEvent?.hosts.length).toBe(2);
//Managed events of removed users should be deleted
const managedEvents = await prismock.eventType.findMany({
where: {
parent: {
id: parentManagedEvent.id,
},
},
select: {
id: true,
},
});
expect(managedEvents).toEqual([{ id: userNotToBeRemovedManagedEvent.id }]);
});
it("should throw error when user is not ADMIN/OWNER of the organization", async () => {
const team = {
id: 1,
name: "Test Team",
slug: "test-team",
};
const memberUser = getOrganizer({
id: 101,
name: "memberUser",
email: "member@user.com",
...getBaseUserInfo(team, 1, "MEMBER"),
});
await createBookingScenario(
getScenarioData({
eventTypes: [
{
id: 1,
slotInterval: 30,
length: 30,
users: [{ id: 101 }],
},
],
organizer: memberUser,
})
);
const { id, name, organizationId } = memberUser;
const ctx = {
user: {
id,
name,
organizationId,
} as NonNullable<TrpcSessionUser>,
};
await expect(
bulkDeleteUsersHandler({
ctx: ctx,
input: {
userIds: [],
},
})
).rejects.toThrowError("UNAUTHORIZED");
});
});