Files
Anirban SinghaandBandhan Majumder 0d164da8dd fix: implement missing password validation (#27634)
* fix: validate password presence and requirements

* chore: add error code for invalid passwords

* chore: avoid trimming password

* chore: add test for password validation

* fix: update password to delete user

* fix: create user password following protocol

* test: simplify deleteMeHandler password validation tests

* fix: address coderabbit

* fix: modify login params for failing tests

* fix: failing e2e tests

---------

Co-authored-by: Bandhan Majumder <133476557+bandhan-majumder@users.noreply.github.com>
2026-06-22 10:37:09 +05:30

101 lines
3.3 KiB
TypeScript

import { ErrorCode } from "@calcom/features/auth/lib/ErrorCode";
import { verifyPassword } from "@calcom/features/auth/lib/verifyPassword";
import { deleteUser } from "@calcom/features/users/lib/deleteUser";
import { symmetricDecrypt } from "@calcom/lib/crypto";
import { isPasswordValid } from "@calcom/lib/auth/isPasswordValid";
import { HttpError } from "@calcom/lib/http-error";
import { totpAuthenticatorCheck } from "@calcom/lib/totp";
import { prisma } from "@calcom/prisma";
import { IdentityProvider } from "@calcom/prisma/enums";
import type { TrpcSessionUser } from "@calcom/trpc/server/types";
import type { TDeleteMeInputSchema } from "./deleteMe.schema";
export type DeleteMeOptions = {
ctx: {
user: NonNullable<TrpcSessionUser>;
};
input: TDeleteMeInputSchema;
};
export const deleteMeHandler = async ({ ctx, input }: DeleteMeOptions) => {
if (!input.password || input.password.trim().length === 0) {
throw new HttpError({ statusCode: 400, message: ErrorCode.UserMissingPassword });
}
const password = input.password;
const strict = ctx.user.role !== "USER";
if (!isPasswordValid(password, false, strict)) {
throw new HttpError({
statusCode: 400,
message: ErrorCode.PasswordPolicyViolation,
});
}
// Check if input.password is correct
const user = await prisma.user.findUnique({
where: {
email: ctx.user.email.toLowerCase(),
},
select: {
identityProvider: true,
twoFactorEnabled: true,
twoFactorSecret: true,
password: true,
email: true,
metadata: true,
id: true,
},
});
if (!user) {
throw new HttpError({ statusCode: 404, message: ErrorCode.UserNotFound });
}
if (user.identityProvider !== IdentityProvider.CAL) {
throw new HttpError({ statusCode: 400, message: ErrorCode.ThirdPartyIdentityProviderEnabled });
}
if (!user.password?.hash) {
throw new HttpError({ statusCode: 400, message: ErrorCode.UserMissingPassword });
}
const isCorrectPassword = await verifyPassword(password, user.password.hash);
if (!isCorrectPassword) {
throw new HttpError({ statusCode: 403, message: ErrorCode.IncorrectPassword });
}
if (user.twoFactorEnabled) {
if (!input.totpCode) {
throw new HttpError({ statusCode: 400, message: ErrorCode.SecondFactorRequired });
}
if (!user.twoFactorSecret) {
console.error(`Two factor is enabled for user ${user.id} but they have no secret`);
throw new Error(ErrorCode.InternalServerError);
}
if (!process.env.CALENDSO_ENCRYPTION_KEY) {
console.error(`"Missing encryption key; cannot proceed with two factor login."`);
throw new Error(ErrorCode.InternalServerError);
}
const secret = symmetricDecrypt(user.twoFactorSecret, process.env.CALENDSO_ENCRYPTION_KEY);
if (secret.length !== 32) {
console.error(
`Two factor secret decryption failed. Expected key with length 32 but got ${secret.length}`
);
throw new Error(ErrorCode.InternalServerError);
}
// If user has 2fa enabled, check if input.totpCode is correct
const isValidToken = totpAuthenticatorCheck(input.totpCode, secret);
if (!isValidToken) {
throw new HttpError({ statusCode: 403, message: ErrorCode.IncorrectTwoFactorCode });
}
}
await deleteUser(user);
return;
};