* fix: integer to text comparison in routing insights query Add explicit integer array cast to prevent PostgreSQL type mismatch error when comparing bookingUserId (integer) with user_id array values in getRoutedToPerPeriodData query * add e2e tests * refactor: remove LoadingInsight component and handle loading in ChartCard - Enhanced ChartCard to render default loading UI when isPending is true - Replaced all LoadingInsight usages with ChartCard that accepts isPending/isError props - Removed LoadingInsight component and updated exports - Updated 16 chart components to use the new pattern - ChartCard now shows spinner and skeleton title during loading state Co-Authored-By: [email protected] <[email protected]> * fix: make children prop optional in ChartCard when isPending is true Co-Authored-By: [email protected] <[email protected]> * refactor: remove unused loadingState prop from ChartCard - Remove loadingState prop and ChartLoadingState type export - Simplify computedLoadingState to derive state only from isPending/isError - No functional changes - loadingState was not being used by any components - data-loading-state attribute behavior remains unchanged for E2E tests Co-Authored-By: [email protected] <[email protected]> * refactor: remove duplicate isPending early returns from chart components - Update all 16 chart components to use single ChartCard return pattern - Gate children rendering with !isPending && isSuccess && data checks - Prevents data processing code from executing during loading state - Improves code consistency and maintainability across all charts Co-Authored-By: [email protected] <[email protected]> * refactor: remove redundant !isPending check from chart conditionals - Simplify conditional rendering to use just 'isSuccess && data' or 'isSuccess' - In TanStack Query, isSuccess and isPending are mutually exclusive - The !isPending check was redundant since isSuccess already implies !isPending - Applied to all 16 chart components for consistency - Components with safe defaults (data ?? []) use just 'isSuccess' - Components requiring data check use 'isSuccess && data' Co-Authored-By: [email protected] <[email protected]> * revert the mistake * apply feedback * apply feedback * fix e2e --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
52 lines
1.5 KiB
TypeScript
52 lines
1.5 KiB
TypeScript
"use client";
|
|
|
|
import { useInsightsRoutingParameters } from "@calcom/features/insights/hooks/useInsightsRoutingParameters";
|
|
import { useLocale } from "@calcom/lib/hooks/useLocale";
|
|
import { trpc } from "@calcom/trpc";
|
|
|
|
import { useToggleableLegend } from "../../hooks/useToggleableLegend";
|
|
import { ChartCard } from "../ChartCard";
|
|
import { RoutingFunnelContent, legend } from "./RoutingFunnelContent";
|
|
import { RoutingFunnelSkeleton } from "./RoutingFunnelSkeleton";
|
|
|
|
export function RoutingFunnel() {
|
|
const { t } = useLocale();
|
|
const insightsRoutingParams = useInsightsRoutingParameters();
|
|
const { enabledLegend, toggleSeries } = useToggleableLegend(legend);
|
|
const { data, isSuccess, isLoading, isError } = trpc.viewer.insights.getRoutingFunnelData.useQuery(
|
|
insightsRoutingParams,
|
|
{
|
|
staleTime: 30000,
|
|
trpc: {
|
|
context: { skipBatch: true },
|
|
},
|
|
}
|
|
);
|
|
|
|
if (isLoading || !isSuccess || !data) {
|
|
return (
|
|
<ChartCard
|
|
title={t("routing_funnel")}
|
|
legend={legend}
|
|
enabledLegend={enabledLegend}
|
|
onSeriesToggle={toggleSeries}
|
|
isPending={isLoading}
|
|
isError={isError}>
|
|
<RoutingFunnelSkeleton />
|
|
</ChartCard>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<ChartCard
|
|
title={t("routing_funnel")}
|
|
legend={legend}
|
|
enabledLegend={enabledLegend}
|
|
onSeriesToggle={toggleSeries}
|
|
isPending={isLoading}
|
|
isError={isError}>
|
|
<RoutingFunnelContent data={data} enabledLegend={enabledLegend} />
|
|
</ChartCard>
|
|
);
|
|
}
|