cal.diy

0 Fork 0

Files

T

Benny JooandDevin AI 404d46c991 refactor: Move trpc-dependent components from features to web [2] (#26420 )

* fix

* move event types components to web

* update import paths

* mv apps components

* migrate form builder

* fix

* mv sso

* fix

* mv

* update import paths

* update import paths

* mv

* mv

* mv

* fix

* update Booker

* fix

* fix

* fix

* fix

* mv video

* mv embed components to web

* update import paths

* mv calendar weekly view components

* update import paths

* fix

* fixp

* fix

* fix

* fix

* fix: update FormBuilder imports to use @calcom/features/form-builder

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update broken import paths after file migrations

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: correct import paths for platform atoms and moved components

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: apply CSS type fixes and add missing atoms exports

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: resolve type errors in test files after component migrations

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: resolve remaining type errors in test files

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* migrate

* fix: resolve type errors in test and mock files

- Add missing bookingForm, bookerFormErrorRef, instantConnectCooldownMs to Booker.test.tsx bookings prop
- Add all required BookerEvent properties to event.mock.ts
- Add vi import from vitest to all mock files
- Fix date parameter types in packages/dayjs/__mocks__/index.ts
- Add verificationCode and setVerificationCode to test-utils.tsx mock store
- Remove children.type access in Section.tsx mock to fix type error
- Fix lint issues: remove unused React imports, use import type where needed, add return types
- Add biome-ignore comments for pre-existing lint warnings in test files

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* migrate

* migrate

* migrate

* update import paths

* update import paths

* update import paths

* fix

* migrate data table

* migrate data table

* fix

* fix

* fix

* migrate insights components

* migrate insights components

* fix

* mv

* update import paths

* fix

* fix

* fix

* fix

* fix

* fix: resolve type errors in test mocks

- Booker.test.tsx: Add all required UseFormReturn methods to bookingForm mock
- event.mock.ts: Fix entity, subsetOfHosts, instantMeetingParameters, fieldTranslations, image types
- dayjs/__mocks__/index.ts: Use Object.assign for proper typing of mock properties
- Section.tsx: Change 'class' to 'className' in JSX with biome-ignore comment

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing hasDataErrors and dataErrors to bookings.errors mock

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing loadingStates properties to bookings mock

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing slots properties (setTentativeSelectedTimeslots, tentativeSelectedTimeslots, slotReservationId)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update quickAvailabilityChecks to include utcEndIso and use valid status type

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing bookerForm properties (formName, beforeVerifyEmail, formErrors)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing UseFormReturn properties to bookerForm.bookingForm mock

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add hasFormErrors and formErrors to bookerForm.formErrors mock

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add hasFormErrors and formErrors to bookerForm.errors mock

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing isError property to mockEvent

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: use complete BookerEvent mock in Booker.test.tsx

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: use branded bookingFields type in event mock

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing schedule mock properties (isError, isSuccess, isLoading, dataUpdatedAt)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* revert

* fix

* fix

* fix

* fix build

* fix

* fix

* fix

* fix: correct AddMembersWithSwitch test wrapper to use initial assignAllTeamMembers value

- Fixed test wrapper to initialize useState with componentProps.assignAllTeamMembers
  instead of hardcoded false, allowing tests to properly test different states
- Updated test expectations for ALL_TEAM_MEMBERS_ENABLED_AND_SEGMENT_NOT_APPLICABLE
  state to match actual component behavior (toggle should be present and checked)
- Fixed 'should show Segment when toggled on' test to start with assignAllTeamMembers: false
  to properly test the flow of enabling it
- Added explicit types to satisfy biome lint requirements

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: use JSX.Element instead of React.JSX.Element for type compatibility

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

2026-01-05 12:53:51 -03:00

__mocks__

refactor: Move trpc-dependent components from features to web [2] (#26420 )

2026-01-05 12:53:51 -03:00

__tests__

refactor: Move trpc-dependent components from features to web [2] (#26420 )

2026-01-05 12:53:51 -03:00

components

refactor: Move trpc-dependent components from features to web [2] (#26420 )

2026-01-05 12:53:51 -03:00

utils

add-tests- usePrefetch (#23918 )

2025-12-12 07:39:57 -03:00

BookerStoreProvider.tsx

fix: multiple widgets for Booker atom (#22925 )

2025-08-14 17:57:59 +05:30

config.ts

fix: typos in packages/ (#21216 )

2025-05-12 09:30:43 +01:00

framer-features.tsx

perf: Lazy load framer motion stuff as much as we can (#10876 )

2023-08-24 13:40:01 -07:00

index.ts

refactor: Move trpc-dependent components from features to web [2] (#26420 )

2026-01-05 12:53:51 -03:00

README.md

feat: Introduce a 'slot no longer available' message (#18935 )

2025-02-26 16:49:26 +02:00

store.ts

feat: add defaultPhoneCountry prop with ISO 3166-1 alpha-2 type safety (#25204 )

2025-11-17 15:56:10 +00:00

types.ts

chore: Upgrade prisma to 6.7.0 (#21264 )

2025-09-11 15:27:50 +01:00

useSlotReservationId.ts

fix: #10973 back button not working as expected in embed (#11073 )

2023-09-05 15:40:09 +05:30

README.md

Strategies to prevent error during booking

The getSchedule call, fetches only those slots that are bookable including not showing the slots that are reserved by someone else.
- The booking call and the get scheduled call share the same availability checking logic to avoid scenario where getSchedule considers a slot as available but Booking call doesn't consider it available.
Even though a slot might be available, multiple people might have opened the same booking page and might want to book the same slot.
- We have a reservation system in place that avoid showing a slot that is reserved by someone to other people.
- The getSchedule call itself considers the reservations and doesn't show those slots.
- When two persons open the same booking page at the same time, they might will see the same slots.
  - If Person1 selects slot1, it will be reserved by Person1. Person2 still sees the slot(because getSchedule is refetched after a long time(in minutes)). But when Person2 selects the same slot1, he will go to "Slot no-longer available" state.
    - Also when the Person2, comes back to the slots listing page, he will see the slot as unavailable now. It works because getSchedule would have been fetched by that time which happened when he selected the slot earlier.
We don't check for reservation during the confirm booking call, because a reservation has lower priority then the actual booking.

"Slot no-longer available" state

When a slot is no longer available, we disable the "Confirm" button which does the booking.
We show a message to the user that he should select a different slot.
To ensure that we can go to this state, whenever applicable, we do the following:
- getSchedule fetching. It prevents the unavailable slot to not appear in the list.
  - Fetched on window focus to handle the users who have the page opened for some time then come back to it
  - Fetched every 5 mins(configurable by .env) as well to handle users who are just there on the page for a long time.
  - Fetched on selecting a slot.
- isReservation query. It prevents the unavailable slot to be not bookable by the User
  - Fetched on regular quick intervals(currently every 10s(configurable by .env)). Even though it doesn't detect actual busy/booked slots, it still avoids the attempted booking of a reserved slot.