Files
cal.diy/packages/trpc/server/routers/viewer/teams/getUserConnectedApps.handler.ts
T
4920abdaf7 feat: optimize Prisma queries by replacing findFirst with findUnique where applicable (#21826)
* feat: optimize Prisma queries by replacing findFirst with findUnique where applicable

- Replace findFirst/findFirstOrThrow with findUnique/findUniqueOrThrow for queries using unique constraints
- Maintain existing functionality and error handling behavior
- Focus on queries using primary keys and unique index fields from schema
- Revert problematic changes that caused test failures to maintain stability

Co-Authored-By: benny@cal.com <benny@cal.com>

* revert: exclude API files from Prisma query optimizations per user request

- Reverted all 55 API-related files to their original state
- Kept all non-API Prisma query optimizations intact
- API files include apps/api/v1, apps/api/v2, apps/web/app/api, and packages/app-store/*/api
- Non-API optimizations remain for packages/lib, packages/features, apps/web (non-api), etc.

Co-Authored-By: benny@cal.com <benny@cal.com>

* feat: optimize membership query in attributeUtils to use findUnique with userId_teamId constraint

Co-Authored-By: benny@cal.com <benny@cal.com>

* revert: exclude test files from Prisma query optimizations per user request

Co-Authored-By: benny@cal.com <benny@cal.com>

* revert: revert attributeUtils.ts to use findFirst for test compatibility

Co-Authored-By: benny@cal.com <benny@cal.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: benny@cal.com <benny@cal.com>
Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
2025-06-17 09:52:02 +03:00

161 lines
4.0 KiB
TypeScript

import { Prisma } from "@prisma/client";
import { getAppFromSlug } from "@calcom/app-store/utils";
import { prisma } from "@calcom/prisma";
import type { AppCategories } from "@calcom/prisma/enums";
import type { TrpcSessionUser } from "@calcom/trpc/server/types";
import type { TGetUserConnectedAppsInputSchema } from "./getUserConnectedApps.schema";
type GetUserConnectedAppsOptions = {
ctx: {
user: NonNullable<TrpcSessionUser>;
};
input: TGetUserConnectedAppsInputSchema;
};
const credentialSelect = Prisma.validator<Prisma.CredentialSelect>()({
userId: true,
app: {
select: {
slug: true,
categories: true,
},
},
destinationCalendars: {
select: {
externalId: true,
},
},
});
type Credential = Prisma.CredentialGetPayload<{ select: typeof credentialSelect }>;
type Apps = {
name: string | null;
logo: string | null;
externalId: string | null;
app: { slug: string; categories: AppCategories[] } | null;
};
// This should improve performance saving already app data found.
const appDataMap = new Map();
const checkCanUserAccessConnectedApps = async (
user: NonNullable<TrpcSessionUser>,
teamId: number,
userIds: number[]
) => {
// Check if the user is a member of the team or an admin/owner of the org
const team = await prisma.team.findUnique({
where: { id: teamId },
select: {
id: true,
parent: {
select: {
id: true,
},
},
},
});
if (!team) {
throw new Error("Team not found");
}
const isMember = await prisma.membership.findUnique({
where: {
userId_teamId: {
userId: user.id,
teamId: teamId,
},
},
});
const isOrgAdminOrOwner =
team.parent &&
(await prisma.membership.findFirst({
where: {
userId: user.id,
teamId: team.parent.id,
OR: [{ role: "ADMIN" }, { role: "OWNER" }],
},
}));
if (!isMember && !isOrgAdminOrOwner) {
throw new Error("User is not authorized to access this team's connected apps");
}
// Check if all userIds belong to the team
const teamMembers = await prisma.membership.findMany({
where: {
teamId,
userId: {
in: userIds,
},
},
select: {
userId: true,
},
});
if (teamMembers.length !== userIds.length) {
const teamMemberIds = teamMembers.map((member) => member.userId);
const invalidUserIds = userIds.filter((id) => !teamMemberIds.includes(id));
if (invalidUserIds.length > 0) {
throw new Error(`Some user IDs do not belong to the team: ${invalidUserIds.join(", ")}`);
}
}
};
export const getUserConnectedAppsHandler = async ({ ctx, input }: GetUserConnectedAppsOptions) => {
const { userIds, teamId } = input;
await checkCanUserAccessConnectedApps(ctx.user, teamId, userIds);
const credentialsPromises: Promise<Credential[]>[] = [];
const userConnectedAppsMap: Record<number, Apps[]> = {};
for (const userId of userIds) {
const cred = prisma.credential.findMany({
where: {
userId,
},
select: credentialSelect,
});
credentialsPromises.push(cred);
}
const credentialsList = await Promise.all(credentialsPromises);
for (const credentials of credentialsList) {
const userId = credentials[0]?.userId;
if (userId) {
userConnectedAppsMap[userId] = credentials?.map((cred) => {
const appSlug = cred.app?.slug;
let appData = appDataMap.get(appSlug);
if (!appData) {
appData = getAppFromSlug(appSlug);
appDataMap.set(appSlug, appData);
}
const isCalendar = cred?.app?.categories?.includes("calendar") ?? false;
const externalId = isCalendar ? cred.destinationCalendars?.[0]?.externalId : null;
return {
name: appData?.name ?? null,
logo: appData?.logo ?? null,
app: cred.app,
externalId: externalId ?? null,
};
});
}
}
return userConnectedAppsMap;
};
export default getUserConnectedAppsHandler;