* fix: remove @calcom/web imports from packages/features to eliminate circular dependency - Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts - Migrate useGeo hook to packages/features/geo/GeoContext.tsx - Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts - Migrate Calendar component to packages/features/calendars/weeklyview/components/ - Move test utilities (bookingScenario, fixtures) to packages/features/test/ - Update all imports in packages/features to use new locations - Add re-exports in apps/web for backward compatibility Co-Authored-By: [email protected] <[email protected]> * fix: delete original implementation files and fix type issues - Delete original calendar component files in apps/web (keep only re-export stubs) - Migrate OutOfOfficeInSlots to packages/features/bookings/components - Convert apps/web OutOfOfficeInSlots to re-export stub - Fix className vs class issue in Calendar.tsx - Fix @calcom/trpc import violation in user-table.ts by using structural type Co-Authored-By: [email protected] <[email protected]> * fix: add missing isGroup and contains fields to UserTableUser attributes type Co-Authored-By: [email protected] <[email protected]> * fix: update customRole type to match actual Prisma Role model Co-Authored-By: [email protected] <[email protected]> * fix build * fix * fix * cleanup weeklyview * fix * refactor to mv MemberPermissions to types package * add types dependency to features * fix * fix * fix * fix * fix * fix * rename * rename * migrate * migrate * migrate * fix * fix * fix * refactor: move test utilities from packages/features/test to tests/libs - Move bookingScenario utilities to tests/libs/bookingScenario - Move fixtures to tests/libs/fixtures - Update all imports in packages/features test files to use new location - Update all imports in apps/web test files to use new location - Eliminates duplication of test utilities between packages/features and apps/web Co-Authored-By: [email protected] <[email protected]> * fix: correct relative import paths for tests/libs in test files Co-Authored-By: [email protected] <[email protected]> * refactor: replace test utility implementations with re-exports to tests/libs Co-Authored-By: [email protected] <[email protected]> * fix: fix test import paths and move signup handler tests to apps/web Co-Authored-By: [email protected] <[email protected]> * fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features - Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency - Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib - Restore signup handlers and tests to packages/features/auth/signup/handlers - Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx Co-Authored-By: [email protected] <[email protected]> * fix: update recurring-event.test.ts imports to use tests/libs path Co-Authored-By: [email protected] <[email protected]> * refactor: delete test re-export files and update imports to use tests/libs directly Co-Authored-By: [email protected] <[email protected]> * fix: update remaining test imports to use tests/libs directly Co-Authored-By: [email protected] <[email protected]> * fix: update handleRecurringEventBooking calls to match function signature (1 arg) Co-Authored-By: [email protected] <[email protected]> * remove * migrate tests * migrate tests * refactor: update test mock imports by removing and using async for mock creators. * fix type errors * fix: add type assertion for MockUser in p2002.test-suite.ts Co-Authored-By: [email protected] <[email protected]> * fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path Co-Authored-By: [email protected] <[email protected]> * feat: create @calcom/testing package and migrate tests from /tests directory - Created new @calcom/testing package in /packages/testing - Moved all files from /tests to /packages/testing - Updated all imports across the codebase to use @calcom/testing alias - Removed /tests directory at root level This allows other packages like @calcom/features and @calcom/web to import testing utilities using the @calcom/testing alias instead of relative paths. Co-Authored-By: [email protected] <[email protected]> * fix * fix * fix: add missing useBookings export to @calcom/atoms package Co-Authored-By: [email protected] <[email protected]> * fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms Co-Authored-By: [email protected] <[email protected]> * chore: add @calcom/testing as explicit devDependency to packages that use it Co-Authored-By: [email protected] <[email protected]> * refactor: move setupVitest.ts into @calcom/testing package Co-Authored-By: [email protected] <[email protected]> * fix * chore: add biome rules to restrict @calcom/testing imports Co-Authored-By: [email protected] <[email protected]> * fix * rename libs to lib * rename libs to lib * add rule * add rule * refactor: remove @calcom/features imports from @calcom/testing - Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts - Replace ProfileRepository.generateProfileUid() with uuidv4() - Clone Tracking type into @calcom/testing/src/lib/types.ts - Update imports in expects.ts and getMockRequestDataForBooking.ts - Move source files into src/ folder - Move CalendarManager mock to @calcom/features Co-Authored-By: [email protected] <[email protected]> * fix: add explicit exports for nested paths in @calcom/testing Co-Authored-By: [email protected] <[email protected]> * improve * improve * fix * fix * fix type checks * fix type checks * fix type checks * fix tests --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
491 lines
12 KiB
TypeScript
491 lines
12 KiB
TypeScript
import prismaMock from "@calcom/testing/lib/__mocks__/prismaMock";
|
|
|
|
import { describe, expect, it, beforeEach, vi } from "vitest";
|
|
|
|
import { RetryableError } from "@calcom/lib/crmManager/errors";
|
|
import { BookingStatus } from "@calcom/prisma/enums";
|
|
|
|
import { createCRMEvent } from "../createCRMEvent";
|
|
|
|
interface User {
|
|
id: number;
|
|
email: string;
|
|
name: string;
|
|
}
|
|
|
|
interface EventTypeMetadata {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: boolean;
|
|
credentialId: number;
|
|
appCategories: string[];
|
|
};
|
|
};
|
|
}
|
|
|
|
interface Booking {
|
|
id: number;
|
|
uid: string;
|
|
status: BookingStatus;
|
|
title: string;
|
|
startTime: Date;
|
|
endTime: Date;
|
|
user: User;
|
|
eventType: {
|
|
metadata: EventTypeMetadata;
|
|
};
|
|
}
|
|
|
|
interface CRMCredential {
|
|
id: number;
|
|
type: string;
|
|
key: {
|
|
access_token?: string;
|
|
refresh_token?: string;
|
|
expiry_date?: number;
|
|
key1?: string;
|
|
};
|
|
userId: number;
|
|
}
|
|
|
|
interface CRMManagerInterface {
|
|
createEvent: (event: unknown) => Promise<{ id: string }>;
|
|
}
|
|
|
|
vi.mock("../lib/buildCalendarEvent", () => ({
|
|
default: vi.fn().mockResolvedValue({
|
|
title: "Test Event",
|
|
description: "Test Description",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
}),
|
|
}));
|
|
|
|
const mockCreateEvent = vi.fn().mockResolvedValue({ id: "sf-event-123" });
|
|
vi.mock("@calcom/features/crmManager/crmManager", () => ({
|
|
default: class MockCrmManager {
|
|
private credential: CRMCredential;
|
|
|
|
constructor(credential: CRMCredential) {
|
|
this.credential = credential;
|
|
}
|
|
|
|
createEvent = mockCreateEvent;
|
|
|
|
getManager(): CRMManagerInterface {
|
|
return {
|
|
createEvent: this.createEvent,
|
|
};
|
|
}
|
|
},
|
|
}));
|
|
|
|
describe("createCRMEvent", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
mockCreateEvent.mockClear();
|
|
// Clear Prisma mocks
|
|
prismaMock.booking.findUnique.mockReset();
|
|
prismaMock.credential.findUnique.mockReset();
|
|
prismaMock.bookingReference.createMany.mockReset();
|
|
prismaMock.bookingReference.findMany.mockReset();
|
|
});
|
|
|
|
it("should successfully create a Salesforce CRM event", async () => {
|
|
const mockBooking: Booking = {
|
|
id: 1,
|
|
uid: "booking-123",
|
|
status: BookingStatus.ACCEPTED,
|
|
title: "Test Booking",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
user: {
|
|
id: 1,
|
|
email: "[email protected]",
|
|
name: "Test User",
|
|
},
|
|
eventType: {
|
|
metadata: {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: true,
|
|
credentialId: 1,
|
|
appCategories: ["crm"],
|
|
},
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
const mockCredential: CRMCredential = {
|
|
id: 1,
|
|
type: "salesforce_crm",
|
|
key: {
|
|
access_token: "mock_token",
|
|
refresh_token: "mock_refresh",
|
|
expiry_date: new Date().getTime() + 3600000,
|
|
},
|
|
userId: 1,
|
|
};
|
|
|
|
// Set up Prisma mocks with proper return values
|
|
prismaMock.booking.findUnique.mockResolvedValueOnce(mockBooking);
|
|
prismaMock.credential.findUnique.mockResolvedValueOnce(mockCredential);
|
|
prismaMock.credential.findMany.mockResolvedValueOnce([mockCredential]);
|
|
prismaMock.bookingReference.createMany.mockResolvedValueOnce({ count: 1 });
|
|
prismaMock.bookingReference.findMany.mockResolvedValueOnce([]);
|
|
const payload = JSON.stringify({
|
|
bookingUid: "booking-123",
|
|
});
|
|
|
|
await createCRMEvent(payload);
|
|
|
|
expect(mockCreateEvent).toHaveBeenCalled();
|
|
expect(prismaMock.bookingReference.createMany).toHaveBeenCalledWith({
|
|
data: [
|
|
{
|
|
type: "salesforce_crm",
|
|
uid: "sf-event-123",
|
|
meetingId: "sf-event-123",
|
|
credentialId: 1,
|
|
bookingId: 1,
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it("should throw error for invalid payload", async () => {
|
|
const invalidPayload = JSON.stringify({
|
|
invalidField: "test",
|
|
});
|
|
|
|
await expect(createCRMEvent(invalidPayload)).rejects.toThrow("malformed payload in createCRMEvent");
|
|
});
|
|
|
|
it("should throw error when booking is not found", async () => {
|
|
prismaMock.booking.findUnique.mockResolvedValue(null);
|
|
|
|
const payload = JSON.stringify({
|
|
bookingUid: "non-existent-booking",
|
|
});
|
|
|
|
await expect(createCRMEvent(payload)).rejects.toThrow("booking not found");
|
|
});
|
|
|
|
it("should handle case when Salesforce CRM is not enabled", async () => {
|
|
const mockBooking: Booking = {
|
|
id: 1,
|
|
uid: "booking-123",
|
|
status: BookingStatus.ACCEPTED,
|
|
title: "Test Booking",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
user: {
|
|
id: 1,
|
|
email: "[email protected]",
|
|
name: "Test User",
|
|
},
|
|
eventType: {
|
|
metadata: {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: false,
|
|
credentialId: 1,
|
|
appCategories: ["crm"],
|
|
},
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
|
prismaMock.credential.findMany.mockResolvedValueOnce([]);
|
|
|
|
const payload = JSON.stringify({
|
|
bookingUid: "booking-123",
|
|
});
|
|
|
|
await createCRMEvent(payload);
|
|
|
|
expect(prismaMock.bookingReference.createMany).toHaveBeenCalledWith({
|
|
data: [],
|
|
});
|
|
});
|
|
|
|
it("should not throw if there is 'Credential not found' error", async () => {
|
|
const mockBooking: Booking = {
|
|
id: 1,
|
|
uid: "booking-123",
|
|
status: BookingStatus.ACCEPTED,
|
|
title: "Test Booking",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
user: {
|
|
id: 1,
|
|
email: "[email protected]",
|
|
name: "Test User",
|
|
},
|
|
eventType: {
|
|
metadata: {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: true,
|
|
credentialId: 1,
|
|
appCategories: ["crm"],
|
|
},
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
|
prismaMock.credential.findUnique.mockResolvedValue(null);
|
|
prismaMock.credential.findMany.mockResolvedValueOnce([]);
|
|
prismaMock.bookingReference.findMany.mockResolvedValueOnce([]);
|
|
|
|
mockCreateEvent.mockRejectedValue(new Error("Salesforce API error"));
|
|
|
|
const payload = JSON.stringify({
|
|
bookingUid: "booking-123",
|
|
});
|
|
|
|
await createCRMEvent(payload);
|
|
|
|
expect(prismaMock.bookingReference.createMany).toHaveBeenCalledWith({
|
|
data: [],
|
|
});
|
|
});
|
|
|
|
it("should throw(and thus retry) if there is RetryableError from `createEvent`", async () => {
|
|
const mockBooking: Booking = {
|
|
id: 1,
|
|
uid: "booking-123",
|
|
status: BookingStatus.ACCEPTED,
|
|
title: "Test Booking",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
user: {
|
|
id: 1,
|
|
email: "[email protected]",
|
|
name: "Test User",
|
|
},
|
|
eventType: {
|
|
metadata: {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: true,
|
|
credentialId: 1,
|
|
appCategories: ["crm"],
|
|
},
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
const mockCredential: CRMCredential = {
|
|
id: 1,
|
|
type: "salesforce_crm",
|
|
key: { key1: "value1" },
|
|
userId: 1,
|
|
};
|
|
|
|
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
|
prismaMock.credential.findUnique.mockResolvedValue(mockCredential);
|
|
prismaMock.credential.findMany.mockResolvedValueOnce([mockCredential]);
|
|
prismaMock.bookingReference.findMany.mockResolvedValueOnce([]);
|
|
|
|
mockCreateEvent.mockRejectedValue(new RetryableError("Salesforce API Retryable error"));
|
|
|
|
const payload = JSON.stringify({
|
|
bookingUid: "booking-123",
|
|
});
|
|
|
|
await expect(createCRMEvent(payload)).rejects.toThrow("Salesforce API Retryable error");
|
|
});
|
|
|
|
it("should not throw(and thus not retry) if there is non-RetryableError from `createEvent`", async () => {
|
|
const mockBooking: Booking = {
|
|
id: 1,
|
|
uid: "booking-123",
|
|
status: BookingStatus.ACCEPTED,
|
|
title: "Test Booking",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
user: {
|
|
id: 1,
|
|
email: "[email protected]",
|
|
name: "Test User",
|
|
},
|
|
eventType: {
|
|
metadata: {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: true,
|
|
credentialId: 1,
|
|
appCategories: ["crm"],
|
|
},
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
const mockCredential: CRMCredential = {
|
|
id: 1,
|
|
type: "salesforce_crm",
|
|
key: { key1: "value1" },
|
|
userId: 1,
|
|
};
|
|
|
|
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
|
prismaMock.credential.findUnique.mockResolvedValue(mockCredential);
|
|
prismaMock.credential.findMany.mockResolvedValueOnce([mockCredential]);
|
|
prismaMock.bookingReference.findMany.mockResolvedValueOnce([]);
|
|
|
|
mockCreateEvent.mockRejectedValue(new Error("Salesforce API error"));
|
|
|
|
const payload = JSON.stringify({
|
|
bookingUid: "booking-123",
|
|
});
|
|
|
|
await createCRMEvent(payload);
|
|
|
|
expect(prismaMock.bookingReference.createMany).toHaveBeenCalledWith({
|
|
data: [],
|
|
});
|
|
});
|
|
|
|
it("should process second app evenif first app throws error in processing", async () => {
|
|
const mockBooking: Booking = {
|
|
id: 1,
|
|
uid: "booking-123",
|
|
status: BookingStatus.ACCEPTED,
|
|
title: "Test Booking",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
user: {
|
|
id: 1,
|
|
email: "[email protected]",
|
|
name: "Test User",
|
|
},
|
|
eventType: {
|
|
metadata: {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: true,
|
|
credentialId: 1,
|
|
appCategories: ["crm"],
|
|
},
|
|
hubspot: {
|
|
enabled: true,
|
|
credentialId: 2,
|
|
appCategories: ["crm"],
|
|
},
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
const mockSalesforceCredential: CRMCredential = {
|
|
id: 1,
|
|
type: "salesforce_crm",
|
|
key: { key1: "value1" },
|
|
userId: 1,
|
|
};
|
|
|
|
const mockHubspotCredential: CRMCredential = {
|
|
id: 2,
|
|
type: "hubspot",
|
|
key: { key1: "value1" },
|
|
userId: 1,
|
|
};
|
|
|
|
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
|
|
|
// First call returns Salesforce credential and second call returns Hubspot credential
|
|
prismaMock.credential.findUnique
|
|
.mockResolvedValueOnce(mockSalesforceCredential)
|
|
.mockResolvedValueOnce(mockHubspotCredential);
|
|
|
|
prismaMock.credential.findMany.mockResolvedValueOnce([
|
|
mockSalesforceCredential,
|
|
mockHubspotCredential,
|
|
]);
|
|
|
|
prismaMock.bookingReference.findMany.mockResolvedValueOnce([]);
|
|
|
|
// Throw error for first app and resolve for second app
|
|
mockCreateEvent
|
|
.mockRejectedValueOnce(new Error("Salesforce API error"))
|
|
.mockResolvedValueOnce({ id: "hubspot-event-123" });
|
|
|
|
const payload = JSON.stringify({
|
|
bookingUid: "booking-123",
|
|
});
|
|
|
|
await createCRMEvent(payload);
|
|
|
|
expect(prismaMock.bookingReference.createMany).toHaveBeenCalledWith({
|
|
data: [
|
|
{
|
|
type: "hubspot",
|
|
uid: "hubspot-event-123",
|
|
meetingId: "hubspot-event-123",
|
|
credentialId: 2,
|
|
bookingId: 1,
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it("should skip a credential from creatingEvent if bookingReference already exists(Helpful in case of retry)", async () => {
|
|
const mockBooking: Booking = {
|
|
id: 1,
|
|
uid: "booking-123",
|
|
status: BookingStatus.ACCEPTED,
|
|
title: "Test Booking",
|
|
startTime: new Date(),
|
|
endTime: new Date(),
|
|
user: {
|
|
id: 1,
|
|
email: "[email protected]",
|
|
name: "Test User",
|
|
},
|
|
eventType: {
|
|
metadata: {
|
|
apps: {
|
|
salesforce: {
|
|
enabled: true,
|
|
credentialId: 1,
|
|
appCategories: ["crm"],
|
|
},
|
|
},
|
|
},
|
|
},
|
|
};
|
|
|
|
const mockSalesforceCredential: CRMCredential = {
|
|
id: 1,
|
|
type: "salesforce_crm",
|
|
key: { key1: "value1" },
|
|
userId: 1,
|
|
};
|
|
|
|
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
|
prismaMock.credential.findUnique.mockResolvedValueOnce(mockSalesforceCredential);
|
|
prismaMock.credential.findMany.mockResolvedValueOnce([mockSalesforceCredential]);
|
|
prismaMock.bookingReference.findMany.mockResolvedValueOnce([
|
|
{ id: 1, type: "salesforce_crm", uid: "sf-event-123", credentialId: 1, bookingId: 1 },
|
|
]);
|
|
|
|
const payload = JSON.stringify({
|
|
bookingUid: "booking-123",
|
|
});
|
|
|
|
await createCRMEvent(payload);
|
|
|
|
expect(prismaMock.bookingReference.createMany).toHaveBeenCalledWith({
|
|
data: [],
|
|
});
|
|
});
|
|
});
|