* fix: remove @calcom/web imports from packages/features to eliminate circular dependency - Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts - Migrate useGeo hook to packages/features/geo/GeoContext.tsx - Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts - Migrate Calendar component to packages/features/calendars/weeklyview/components/ - Move test utilities (bookingScenario, fixtures) to packages/features/test/ - Update all imports in packages/features to use new locations - Add re-exports in apps/web for backward compatibility Co-Authored-By: [email protected] <[email protected]> * fix: delete original implementation files and fix type issues - Delete original calendar component files in apps/web (keep only re-export stubs) - Migrate OutOfOfficeInSlots to packages/features/bookings/components - Convert apps/web OutOfOfficeInSlots to re-export stub - Fix className vs class issue in Calendar.tsx - Fix @calcom/trpc import violation in user-table.ts by using structural type Co-Authored-By: [email protected] <[email protected]> * fix: add missing isGroup and contains fields to UserTableUser attributes type Co-Authored-By: [email protected] <[email protected]> * fix: update customRole type to match actual Prisma Role model Co-Authored-By: [email protected] <[email protected]> * fix build * fix * fix * cleanup weeklyview * fix * refactor to mv MemberPermissions to types package * add types dependency to features * fix * fix * fix * fix * fix * fix * rename * rename * migrate * migrate * migrate * fix * fix * fix * refactor: move test utilities from packages/features/test to tests/libs - Move bookingScenario utilities to tests/libs/bookingScenario - Move fixtures to tests/libs/fixtures - Update all imports in packages/features test files to use new location - Update all imports in apps/web test files to use new location - Eliminates duplication of test utilities between packages/features and apps/web Co-Authored-By: [email protected] <[email protected]> * fix: correct relative import paths for tests/libs in test files Co-Authored-By: [email protected] <[email protected]> * refactor: replace test utility implementations with re-exports to tests/libs Co-Authored-By: [email protected] <[email protected]> * fix: fix test import paths and move signup handler tests to apps/web Co-Authored-By: [email protected] <[email protected]> * fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features - Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency - Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib - Restore signup handlers and tests to packages/features/auth/signup/handlers - Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx Co-Authored-By: [email protected] <[email protected]> * fix: update recurring-event.test.ts imports to use tests/libs path Co-Authored-By: [email protected] <[email protected]> * refactor: delete test re-export files and update imports to use tests/libs directly Co-Authored-By: [email protected] <[email protected]> * fix: update remaining test imports to use tests/libs directly Co-Authored-By: [email protected] <[email protected]> * fix: update handleRecurringEventBooking calls to match function signature (1 arg) Co-Authored-By: [email protected] <[email protected]> * remove * migrate tests * migrate tests * refactor: update test mock imports by removing and using async for mock creators. * fix type errors * fix: add type assertion for MockUser in p2002.test-suite.ts Co-Authored-By: [email protected] <[email protected]> * fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path Co-Authored-By: [email protected] <[email protected]> * feat: create @calcom/testing package and migrate tests from /tests directory - Created new @calcom/testing package in /packages/testing - Moved all files from /tests to /packages/testing - Updated all imports across the codebase to use @calcom/testing alias - Removed /tests directory at root level This allows other packages like @calcom/features and @calcom/web to import testing utilities using the @calcom/testing alias instead of relative paths. Co-Authored-By: [email protected] <[email protected]> * fix * fix * fix: add missing useBookings export to @calcom/atoms package Co-Authored-By: [email protected] <[email protected]> * fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms Co-Authored-By: [email protected] <[email protected]> * chore: add @calcom/testing as explicit devDependency to packages that use it Co-Authored-By: [email protected] <[email protected]> * refactor: move setupVitest.ts into @calcom/testing package Co-Authored-By: [email protected] <[email protected]> * fix * chore: add biome rules to restrict @calcom/testing imports Co-Authored-By: [email protected] <[email protected]> * fix * rename libs to lib * rename libs to lib * add rule * add rule * refactor: remove @calcom/features imports from @calcom/testing - Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts - Replace ProfileRepository.generateProfileUid() with uuidv4() - Clone Tracking type into @calcom/testing/src/lib/types.ts - Update imports in expects.ts and getMockRequestDataForBooking.ts - Move source files into src/ folder - Move CalendarManager mock to @calcom/features Co-Authored-By: [email protected] <[email protected]> * fix: add explicit exports for nested paths in @calcom/testing Co-Authored-By: [email protected] <[email protected]> * improve * improve * fix * fix * fix type checks * fix type checks * fix type checks * fix tests --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
313 lines
11 KiB
TypeScript
313 lines
11 KiB
TypeScript
import prismock from "@calcom/testing/lib/__mocks__/prisma";
|
|
import "../__mocks__/features.repository";
|
|
import "../__mocks__/getGoogleAppKeys";
|
|
import {
|
|
setCredentialsMock,
|
|
calendarListMock,
|
|
getLastCreatedJWT,
|
|
getLastCreatedOAuth2Client,
|
|
setLastCreatedJWT,
|
|
setLastCreatedOAuth2Client,
|
|
calendarMock,
|
|
adminMock,
|
|
MOCK_JWT_TOKEN,
|
|
MOCK_OAUTH2_TOKEN,
|
|
} from "../__mocks__/googleapis";
|
|
|
|
import { expect, test, beforeEach, vi, describe } from "vitest";
|
|
import "vitest-fetch-mock";
|
|
|
|
import type { CredentialForCalendarServiceWithEmail } from "@calcom/types/Credential";
|
|
|
|
import CalendarService from "../CalendarService";
|
|
import {
|
|
createMockJWTInstance,
|
|
createInMemoryDelegationCredentialForCalendarService,
|
|
defaultDelegatedCredential,
|
|
createCredentialForCalendarService,
|
|
} from "./utils";
|
|
|
|
function expectJWTInstanceToBeCreated() {
|
|
expect(getLastCreatedJWT()).toBeDefined();
|
|
expect(setCredentialsMock).not.toHaveBeenCalled();
|
|
}
|
|
|
|
function expectOAuth2InstanceToBeCreated() {
|
|
expect(setCredentialsMock).toHaveBeenCalled();
|
|
expect(getLastCreatedJWT()).toBeNull();
|
|
}
|
|
|
|
function mockSuccessfulCalendarListFetch() {
|
|
calendarListMock.mockImplementation(() => {
|
|
return {
|
|
data: { items: [] },
|
|
};
|
|
});
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
setCredentialsMock.mockClear();
|
|
calendarMock.calendar_v3.Calendar.mockClear();
|
|
adminMock.admin_directory_v1.Admin.mockClear();
|
|
|
|
setLastCreatedJWT(null);
|
|
setLastCreatedOAuth2Client(null);
|
|
createMockJWTInstance({});
|
|
});
|
|
|
|
async function expectNoCredentialsInDb() {
|
|
const credentials = await prismock.credential.findMany({});
|
|
expect(credentials).toHaveLength(0);
|
|
}
|
|
|
|
async function expectCredentialsInDb(credentials: CredentialForCalendarServiceWithEmail[]) {
|
|
const credentialsInDb = await prismock.credential.findMany({});
|
|
expect(credentialsInDb.length).toBe(credentials.length);
|
|
expect(credentialsInDb).toEqual(expect.arrayContaining(credentials));
|
|
}
|
|
|
|
describe("GoogleCalendarService credential handling", () => {
|
|
describe("Delegation Credential", () => {
|
|
test("uses JWT auth with impersonation when listCalendars is called and creates a new credential in DB with the key as JWT token if it doesn't exist", async () => {
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: "[email protected]" },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
mockSuccessfulCalendarListFetch();
|
|
expectNoCredentialsInDb();
|
|
const calendarService = new CalendarService(credentialWithDelegation);
|
|
await calendarService.listCalendars();
|
|
expectJWTInstanceToBeCreated();
|
|
await expectCredentialsInDb([
|
|
expect.objectContaining({
|
|
delegationCredentialId: credentialWithDelegation.delegationCredentialId,
|
|
key: MOCK_JWT_TOKEN,
|
|
userId: credentialWithDelegation.userId,
|
|
}),
|
|
]);
|
|
});
|
|
|
|
test("uses JWT auth with impersonation when listCalendars is called and updates the credential in DB with the new JWT token if it exists", async () => {
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: "[email protected]" },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
mockSuccessfulCalendarListFetch();
|
|
const existingCredential = await prismock.credential.create({
|
|
data: {
|
|
type: "google_calendar",
|
|
delegationCredentialId: credentialWithDelegation.delegationCredentialId,
|
|
userId: credentialWithDelegation.userId,
|
|
key: {
|
|
access_token: "CURRENT_ACCESS_TOKEN",
|
|
},
|
|
},
|
|
});
|
|
const calendarService = new CalendarService(credentialWithDelegation);
|
|
await calendarService.listCalendars();
|
|
expectJWTInstanceToBeCreated();
|
|
await expectCredentialsInDb([
|
|
expect.objectContaining({
|
|
id: existingCredential.id,
|
|
delegationCredentialId: credentialWithDelegation.delegationCredentialId,
|
|
key: MOCK_JWT_TOKEN,
|
|
userId: credentialWithDelegation.userId,
|
|
}),
|
|
]);
|
|
});
|
|
|
|
test("JWT token is reused when not expired when listCalendars is called again on a new instance of CalendarService", async () => {
|
|
const jwtTokenThatHasNotExpired = {
|
|
...MOCK_JWT_TOKEN,
|
|
expiry_date: Date.now() + 1000 * 60 * 60 * 24,
|
|
};
|
|
createMockJWTInstance({
|
|
tokenExpiryDate: jwtTokenThatHasNotExpired.expiry_date,
|
|
});
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: "[email protected]" },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
console.log("TESTS: credentialWithDelegation", credentialWithDelegation);
|
|
|
|
mockSuccessfulCalendarListFetch();
|
|
await expectNoCredentialsInDb();
|
|
console.log("TESTS: First instance of CalendarService");
|
|
const calendarService1 = new CalendarService({
|
|
...credentialWithDelegation,
|
|
});
|
|
await calendarService1.listCalendars();
|
|
await expectCredentialsInDb([
|
|
expect.objectContaining({
|
|
delegationCredentialId: credentialWithDelegation.delegationCredentialId,
|
|
key: jwtTokenThatHasNotExpired,
|
|
userId: credentialWithDelegation.userId,
|
|
}),
|
|
]);
|
|
|
|
const existingCredential = await prismock.credential.findFirst({
|
|
where: {
|
|
delegationCredentialId: credentialWithDelegation.delegationCredentialId,
|
|
userId: credentialWithDelegation.userId,
|
|
},
|
|
});
|
|
expect(existingCredential).toBeDefined();
|
|
console.log("TESTS: Second instance of CalendarService");
|
|
createMockJWTInstance({
|
|
authorizeError: {
|
|
response: {
|
|
data: {
|
|
error: "I_WOULD_ERROR_IF_YOU_USE_ME",
|
|
},
|
|
},
|
|
},
|
|
});
|
|
const calendarService2 = new CalendarService({
|
|
...credentialWithDelegation,
|
|
});
|
|
await calendarService2.listCalendars();
|
|
await expectCredentialsInDb([
|
|
expect.objectContaining({
|
|
// Same credential should be reused
|
|
id: existingCredential?.id,
|
|
delegationCredentialId: credentialWithDelegation.delegationCredentialId,
|
|
key: jwtTokenThatHasNotExpired,
|
|
}),
|
|
]);
|
|
});
|
|
});
|
|
|
|
describe("Non-Delegation Credential", () => {
|
|
test("uses OAuth2 auth when listCalendars is called", async () => {
|
|
const regularCredential = await createCredentialForCalendarService();
|
|
mockSuccessfulCalendarListFetch();
|
|
const calendarService = new CalendarService(regularCredential);
|
|
await calendarService.listCalendars();
|
|
|
|
expectOAuth2InstanceToBeCreated();
|
|
|
|
expect(calendarMock.calendar_v3.Calendar).toHaveBeenCalledWith({
|
|
auth: getLastCreatedOAuth2Client(),
|
|
});
|
|
await expectCredentialsInDb([
|
|
expect.objectContaining({
|
|
id: regularCredential.id,
|
|
key: MOCK_OAUTH2_TOKEN,
|
|
}),
|
|
]);
|
|
});
|
|
});
|
|
|
|
describe("Delegation Credential Error handling", () => {
|
|
test("handles clientId not added to Google Workspace Admin Console error", async () => {
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: "[email protected]" },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
createMockJWTInstance({
|
|
authorizeError: {
|
|
response: {
|
|
data: {
|
|
error: "unauthorized_client",
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
const calendarService = new CalendarService(credentialWithDelegation);
|
|
|
|
await expect(calendarService.listCalendars()).rejects.toThrow(
|
|
"Make sure that the Client ID for the delegation credential is added to the Google Workspace Admin Console"
|
|
);
|
|
});
|
|
|
|
test("handles DelegationCredential authorization errors appropriately", async () => {
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: "[email protected]" },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
createMockJWTInstance({
|
|
authorizeError: {
|
|
response: {
|
|
data: {
|
|
error: "unauthorized_client",
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
const calendarService = new CalendarService(credentialWithDelegation);
|
|
|
|
await expect(calendarService.listCalendars()).rejects.toThrow(
|
|
"Make sure that the Client ID for the delegation credential is added to the Google Workspace Admin Console"
|
|
);
|
|
});
|
|
|
|
test("handles invalid_grant error (user not in workspace) appropriately", async () => {
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: "[email protected]" },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
createMockJWTInstance({
|
|
authorizeError: {
|
|
response: {
|
|
data: {
|
|
error: "invalid_grant",
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
const calendarService = new CalendarService(credentialWithDelegation);
|
|
|
|
await expect(calendarService.listCalendars()).rejects.toThrow(
|
|
`User ${credentialWithDelegation.user?.email} might not exist in Google Workspace`
|
|
);
|
|
});
|
|
|
|
test("handles DelegationCredential authorization errors appropriately", async () => {
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: "[email protected]" },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
createMockJWTInstance({
|
|
authorizeError: new Error("Some unexpected error"),
|
|
});
|
|
|
|
const calendarService = new CalendarService(credentialWithDelegation);
|
|
|
|
await expect(calendarService.listCalendars()).rejects.toThrow(
|
|
"Error authorizing delegation credential"
|
|
);
|
|
});
|
|
|
|
test("On missing user email for DelegationCredential, it should fallback to OAuth2 auth", async () => {
|
|
const credentialWithDelegation = await createInMemoryDelegationCredentialForCalendarService({
|
|
user: { email: null },
|
|
delegatedTo: defaultDelegatedCredential,
|
|
delegationCredentialId: "delegation-credential-id-1",
|
|
});
|
|
|
|
const calendarService = new CalendarService(credentialWithDelegation);
|
|
mockSuccessfulCalendarListFetch();
|
|
await calendarService.listCalendars();
|
|
expectOAuth2InstanceToBeCreated();
|
|
});
|
|
});
|
|
});
|