* fix: integer to text comparison in routing insights query Add explicit integer array cast to prevent PostgreSQL type mismatch error when comparing bookingUserId (integer) with user_id array values in getRoutedToPerPeriodData query * add e2e tests * refactor: remove LoadingInsight component and handle loading in ChartCard - Enhanced ChartCard to render default loading UI when isPending is true - Replaced all LoadingInsight usages with ChartCard that accepts isPending/isError props - Removed LoadingInsight component and updated exports - Updated 16 chart components to use the new pattern - ChartCard now shows spinner and skeleton title during loading state Co-Authored-By: [email protected] <[email protected]> * fix: make children prop optional in ChartCard when isPending is true Co-Authored-By: [email protected] <[email protected]> * refactor: remove unused loadingState prop from ChartCard - Remove loadingState prop and ChartLoadingState type export - Simplify computedLoadingState to derive state only from isPending/isError - No functional changes - loadingState was not being used by any components - data-loading-state attribute behavior remains unchanged for E2E tests Co-Authored-By: [email protected] <[email protected]> * refactor: remove duplicate isPending early returns from chart components - Update all 16 chart components to use single ChartCard return pattern - Gate children rendering with !isPending && isSuccess && data checks - Prevents data processing code from executing during loading state - Improves code consistency and maintainability across all charts Co-Authored-By: [email protected] <[email protected]> * refactor: remove redundant !isPending check from chart conditionals - Simplify conditional rendering to use just 'isSuccess && data' or 'isSuccess' - In TanStack Query, isSuccess and isPending are mutually exclusive - The !isPending check was redundant since isSuccess already implies !isPending - Applied to all 16 chart components for consistency - Components with safe defaults (data ?? []) use just 'isSuccess' - Components requiring data check use 'isSuccess && data' Co-Authored-By: [email protected] <[email protected]> * revert the mistake * apply feedback * apply feedback * fix e2e --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
186 lines
5.2 KiB
TypeScript
186 lines
5.2 KiB
TypeScript
"use client";
|
|
|
|
import { useLocale } from "@calcom/lib/hooks/useLocale";
|
|
import { trpc } from "@calcom/trpc";
|
|
import classNames from "@calcom/ui/classNames";
|
|
import { SkeletonText } from "@calcom/ui/components/skeleton";
|
|
|
|
import { useInsightsBookingParameters } from "../../hooks/useInsightsBookingParameters";
|
|
import { ChartCard } from "../ChartCard";
|
|
import { KPICard } from "../KPICard";
|
|
|
|
export const BookingKPICards = () => {
|
|
const { t } = useLocale();
|
|
const insightsBookingParams = useInsightsBookingParameters();
|
|
|
|
const { data, isSuccess, isPending, isError } = trpc.viewer.insights.bookingKPIStats.useQuery(
|
|
insightsBookingParams,
|
|
{
|
|
staleTime: 180000,
|
|
refetchOnWindowFocus: false,
|
|
trpc: {
|
|
context: { skipBatch: true },
|
|
},
|
|
}
|
|
);
|
|
|
|
const eventCategories: {
|
|
title: string;
|
|
index: "created" | "completed" | "rescheduled" | "cancelled";
|
|
}[] = [
|
|
{
|
|
title: t("events_created"),
|
|
index: "created",
|
|
},
|
|
{
|
|
title: t("events_completed"),
|
|
index: "completed",
|
|
},
|
|
{
|
|
title: t("events_rescheduled"),
|
|
index: "rescheduled",
|
|
},
|
|
{
|
|
title: t("events_cancelled"),
|
|
index: "cancelled",
|
|
},
|
|
];
|
|
|
|
const performanceCategories: {
|
|
title: string;
|
|
index: "rating" | "no_show" | "no_show_guest" | "csat";
|
|
}[] = [
|
|
{
|
|
title: t("event_ratings"),
|
|
index: "rating",
|
|
},
|
|
{
|
|
title: t("event_no_show"),
|
|
index: "no_show",
|
|
},
|
|
{
|
|
title: t("event_no_show_guest"),
|
|
index: "no_show_guest",
|
|
},
|
|
{
|
|
title: t("csat_score"),
|
|
index: "csat",
|
|
},
|
|
];
|
|
|
|
if (isPending) {
|
|
return (
|
|
<LoadingKPICards
|
|
eventCategories={eventCategories}
|
|
performanceCategories={performanceCategories}
|
|
isPending={isPending}
|
|
isError={isError}
|
|
/>
|
|
);
|
|
}
|
|
|
|
if (!isSuccess || !data) return null;
|
|
|
|
return (
|
|
<div className="stack-y-4">
|
|
<ChartCard title={t("events")} isPending={isPending} isError={isError}>
|
|
<StatContainer>
|
|
{eventCategories.map((item, index) => (
|
|
<StatItem key={item.title} index={index}>
|
|
<KPICard
|
|
title={item.title}
|
|
previousMetricData={data[item.index]}
|
|
previousDateRange={data.previousRange}
|
|
/>
|
|
</StatItem>
|
|
))}
|
|
</StatContainer>
|
|
</ChartCard>
|
|
|
|
<ChartCard title={t("performance")} isPending={isPending} isError={isError}>
|
|
<StatContainer>
|
|
{performanceCategories.map((item, index) => (
|
|
<StatItem key={item.title} index={index}>
|
|
<KPICard
|
|
title={item.title}
|
|
previousMetricData={data[item.index]}
|
|
previousDateRange={data.previousRange}
|
|
/>
|
|
</StatItem>
|
|
))}
|
|
</StatContainer>
|
|
</ChartCard>
|
|
</div>
|
|
);
|
|
};
|
|
|
|
const LoadingKPICards = (props: {
|
|
eventCategories: { title: string; index: string }[];
|
|
performanceCategories: { title: string; index: string }[];
|
|
isPending: boolean;
|
|
isError: boolean;
|
|
}) => {
|
|
const { eventCategories, performanceCategories, isPending, isError } = props;
|
|
const { t } = useLocale();
|
|
|
|
return (
|
|
<div className="stack-y-4">
|
|
<ChartCard title={t("events")} isPending={isPending} isError={isError}>
|
|
<StatContainer>
|
|
{eventCategories.map((item, index) => (
|
|
<StatItem key={item.title} index={index}>
|
|
<div>
|
|
<SkeletonText className="mb-2 h-4 w-24" />
|
|
<div className="items-baseline justify-start space-x-3 truncate">
|
|
<SkeletonText className="h-8 w-16" />
|
|
</div>
|
|
<div className="mt-4 justify-start space-x-2">
|
|
<SkeletonText className="h-4 w-20" />
|
|
</div>
|
|
</div>
|
|
</StatItem>
|
|
))}
|
|
</StatContainer>
|
|
</ChartCard>
|
|
|
|
<ChartCard title={t("performance")} isPending={isPending} isError={isError}>
|
|
<StatContainer>
|
|
{performanceCategories.map((item, index) => (
|
|
<StatItem key={item.title} index={index}>
|
|
<div>
|
|
<SkeletonText className="mb-2 h-4 w-24" />
|
|
<div className="items-baseline justify-start space-x-3 truncate">
|
|
<SkeletonText className="h-8 w-16" />
|
|
</div>
|
|
<div className="mt-4 justify-start space-x-2">
|
|
<SkeletonText className="h-4 w-20" />
|
|
</div>
|
|
</div>
|
|
</StatItem>
|
|
))}
|
|
</StatContainer>
|
|
</ChartCard>
|
|
</div>
|
|
);
|
|
};
|
|
|
|
// StatContainer: wraps the grid
|
|
function StatContainer({ children }: { children: React.ReactNode }) {
|
|
return <div className="group grid grid-cols-1 sm:grid-cols-2 md:grid-cols-4">{children}</div>;
|
|
}
|
|
|
|
// StatItem: handles border logic
|
|
function StatItem({ index, children }: { index: number; children: React.ReactNode }) {
|
|
return (
|
|
<div
|
|
className={classNames(
|
|
"border-muted flex-1 p-4",
|
|
index === 0 && "border-b sm:border-r md:border-b-0 md:border-r",
|
|
index === 1 && "border-b sm:border-r-0 md:border-b-0 md:border-r",
|
|
index === 2 && "border-b sm:border-b-0 sm:border-r md:border-b-0"
|
|
)}>
|
|
{children}
|
|
</div>
|
|
);
|
|
}
|