Use trackingId only for trackingDomain as thats the only variable supported (#6856)

This commit is contained in:
Hariom Balhara authored and GitHub committed 2023-02-02 15:13:42 +00:00
1 parent c96d258f5e
commit 50c8959cfa
7 files changed
+6 -25

No files matched your search

@@ -22,6 +22,7 @@ export default function BookingPageTagManager({
return null;
}
const parseValue = <T extends string | undefined>(val: T): T =>
//TODO: Support more template variables.
val ? (val.replace(/\{TRACKING_ID\}/g, trackingId) as T) : val;
return tag.scripts.map((script, index) => {
@@ -20,7 +20,6 @@ export const InstallAppButtonMap = {
larkcalendar: dynamic(() => import("./larkcalendar/components/InstallAppButton")),
office365calendar: dynamic(() => import("./office365calendar/components/InstallAppButton")),
office365video: dynamic(() => import("./office365video/components/InstallAppButton")),
plausible: dynamic(() => import("./plausible/components/InstallAppButton")),
riverside: dynamic(() => import("./riverside/components/InstallAppButton")),
tandemvideo: dynamic(() => import("./tandemvideo/components/InstallAppButton")),
vital: dynamic(() => import("./vital/components/InstallAppButton")),
@@ -9,7 +9,7 @@ import { appDataSchema } from "../zod";
const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({ app }) {
const [getAppData, setAppData] = useAppContextWithSchema<typeof appDataSchema>();
const trackedDomain = getAppData("trackedDomain");
const trackingId = getAppData("trackingId");
const [enabled, setEnabled] = useState(getAppData("enabled"));
return (
@@ -26,9 +26,9 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({
switchChecked={enabled}>
<TextField
name="Tracked Domain"
value={trackedDomain}
value={trackingId}
onChange={(e) => {
setAppData("trackedDomain", e.target.value);
setAppData("trackingId", e.target.value);
}}
/>
</AppCard>
@@ -1,18 +0,0 @@
import type { InstallAppButtonProps } from "@calcom/app-store/types";
import useAddAppMutation from "../../_utils/useAddAppMutation";
export default function InstallAppButton(props: InstallAppButtonProps) {
const mutation = useAddAppMutation("plausible_analytics");
return (
<>
{props.render({
onClick() {
mutation.mutate("");
},
loading: mutation.isLoading,
})}
</>
);
}
@@ -1 +0,0 @@
export { default as InstallAppButton } from "./InstallAppButton";
+1 -1
View File
@@ -17,7 +17,7 @@
{
"src": "https://plausible.io/js/script.js",
"attrs": {
"data-domain": "{TRACKED_DOMAIN}"
"data-domain": "{TRACKING_ID}"
}
}
]
+1 -1
View File
@@ -4,7 +4,7 @@ import { eventTypeAppCardZod } from "../eventTypeAppCardZod";
export const appDataSchema = eventTypeAppCardZod.merge(
z.object({
trackedDomain: z.string(),
trackingId: z.string(),
})
);