fix: add artifact handling for API v2 E2E tests (#26249)

* fix: add artifact handling for API v2 E2E tests

- Add jest-junit reporter to generate JUnit XML test results
- Update workflow to upload from correct path (apps/api/v2/test-results)
- Add if-no-files-found: ignore and retention-days: 30 for consistency

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* Apply suggestion from @keithwillcode

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

.github/workflows/e2e-api-v2.yml

@@ -88,4 +88,6 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: test-results-api-v2-shard-${{ matrix.shard }}
-          path: test-results
+          path: apps/api/v2/test-results
+          if-no-files-found: ignore
+          retention-days: 7

apps/api/v2/jest-e2e.ts

@@ -32,7 +32,17 @@ const config: Config = {
   },
   setupFiles: ["<rootDir>/test/setEnvVars.ts", "jest-date-mock"],
   setupFilesAfterEnv: ["<rootDir>/test/jest.setup-e2e.ts"],
-  reporters: ["default", "jest-summarizing-reporter"],
+  reporters: [
+    "default",
+    "jest-summarizing-reporter",
+    [
+      "jest-junit",
+      {
+        outputDirectory: "./test-results",
+        outputName: "junit.xml",
+      },
+    ],
+  ],
   workerIdleMemoryLimit: "512MB",
   maxWorkers,
   testPathIgnorePatterns: ["/dist/", "/node_modules/"],

apps/api/v2/package.json

@@ -103,6 +103,7 @@
     "concurrently": "9.1.2",
     "jest": "29.7.0",
     "jest-date-mock": "1.0.10",
+    "jest-junit": "^16.0.0",
     "node-mocks-http": "1.16.2",
     "prettier": "2.8.7",
     "source-map-support": "0.5.21",

yarn.lock

@@ -1912,6 +1912,7 @@ __metadata:
     ioredis: "npm:5.3.2"
     jest: "npm:29.7.0"
     jest-date-mock: "npm:1.0.10"
+    jest-junit: "npm:^16.0.0"
     lodash: "npm:4.17.21"
     luxon: "npm:3.4.4"
     nest-winston: "npm:1.9.4"
@@ -28173,6 +28174,18 @@ __metadata:
   languageName: node
   linkType: hard
 
+"jest-junit@npm:^16.0.0":
+  version: 16.0.0
+  resolution: "jest-junit@npm:16.0.0"
+  dependencies:
+    mkdirp: "npm:^1.0.4"
+    strip-ansi: "npm:^6.0.1"
+    uuid: "npm:^8.3.2"
+    xml: "npm:^1.0.1"
+  checksum: 10/2c33ee8bfd0c83b9aa1f8ba5905084890d5f519d294ccc2829d778ac860d5adffffec75d930f44f1d498aa8370c783e0aa6a632d947fb7e81205f0e7b926669d
+  languageName: node
+  linkType: hard
+
 "jest-leak-detector@npm:^29.7.0":
   version: 29.7.0
   resolution: "jest-leak-detector@npm:29.7.0"
@@ -42477,6 +42490,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"xml@npm:^1.0.1":
+  version: 1.0.1
+  resolution: "xml@npm:1.0.1"
+  checksum: 10/6c4c31a1308e45732e5ac6b50edbca0e8f7abe5cb5de10215d8e3c688819fe7c7706e056f6fb59b1a23fdf1000c2d7a8bba0a89e94aa1796cd2376d9a5ba401e
+  languageName: node
+  linkType: hard
+
 "xmlbuilder@npm:15.1.1, xmlbuilder@npm:^15.1.1":
   version: 15.1.1
   resolution: "xmlbuilder@npm:15.1.1"