fix: remove sticky positioning from page headers in pages on scroll (#27242)
* fix: remove sticky positioning from page headers in pages using ShellMain
* correct fix (mostly)
* fix: disable sticky headers on routing forms and members pages
Applied disableSticky={true} to remaining affected pages:
- Routing Forms page
- Organization Members view
- Platform Members view
---------
Co-authored-by: Dhairyashil <dhairyashil10101010@gmail.com>
This commit is contained in:
co-authored by
Dhairyashil
parent
3e30a5c3ea
commit
72d6fcb371
@@ -149,6 +149,7 @@ export default function RoutingForms({ appUrl }: { appUrl: string }) {
|
||||
return (
|
||||
<LicenseRequired>
|
||||
<ShellMain
|
||||
disableSticky={true}
|
||||
heading={t("routing")}
|
||||
CTA={
|
||||
hasPaidPlan && forms?.length ? (
|
||||
|
||||
+1
@@ -10,6 +10,7 @@ export default async function Layout({ children }: { children: React.ReactNode }
|
||||
return (
|
||||
<Shell
|
||||
withoutMain={false}
|
||||
disableSticky={true}
|
||||
heading={t("organization_members")}
|
||||
subtitle={t("organization_description")}
|
||||
headerClassName="hidden md:block"
|
||||
|
||||
@@ -23,6 +23,7 @@ export default async function Layout({ children }: { children: React.ReactNode }
|
||||
/>
|
||||
</div>
|
||||
}
|
||||
disableSticky={true}
|
||||
title={t("platform_members")}
|
||||
subtitle={t("platform_members_description")}
|
||||
withoutMain={false}
|
||||
|
||||
@@ -56,6 +56,7 @@ function WorkflowsPage({ filteredList }: PageProps) {
|
||||
<Shell withoutMain>
|
||||
<LicenseRequired>
|
||||
<ShellMain
|
||||
disableSticky={true}
|
||||
heading={t("workflows")}
|
||||
subtitle={t("workflows_to_automate_notifications")}
|
||||
title={t("workflows")}
|
||||
|
||||
@@ -87,6 +87,7 @@ export type LayoutProps = {
|
||||
afterHeading?: ReactNode;
|
||||
smallHeading?: boolean;
|
||||
isPlatformUser?: boolean;
|
||||
disableSticky?: boolean;
|
||||
};
|
||||
|
||||
const KBarWrapper = ({ children, withKBar = false }: { withKBar: boolean; children: React.ReactNode }) =>
|
||||
@@ -132,8 +133,9 @@ export function ShellMain(props: LayoutProps) {
|
||||
{(props.heading || !!props.backPath) && (
|
||||
<div
|
||||
className={classNames(
|
||||
"bg-default sticky top-0 z-10 mb-0 flex items-center md:mb-6 md:mt-0",
|
||||
props.smallHeading ? "lg:mb-7" : "lg:mb-8"
|
||||
"bg-default mb-0 flex items-center md:mb-6 md:mt-0",
|
||||
props.smallHeading ? "lg:mb-7" : "lg:mb-8",
|
||||
!props.disableSticky && "sticky top-0 z-10"
|
||||
)}>
|
||||
{!!props.backPath && (
|
||||
<Button
|
||||
|
||||
Reference in New Issue
Block a user