feat: placeholder component for user dropdown to remove layout shift (#20696)

* feat

* refactor
This commit is contained in:
Benny Joo authored and GitHub committed 2025-04-15 15:17:14 -04:00
1 parent 89772a0dac
commit 77b656024a
1 file changed
+6 -6
@@ -39,7 +39,7 @@ interface UserDropdownProps {
export function UserDropdown({ small }: UserDropdownProps) {
const { isPlatformUser } = useGetUserAttributes();
const { t } = useLocale();
const { data: user } = useMeQuery();
const { data: user, isPending } = useMeQuery();
const pathname = usePathname();
const isPlatformPages = pathname?.startsWith("/settings/platform");
useEffect(() => {
@@ -65,13 +65,13 @@ export function UserDropdown({ small }: UserDropdownProps) {
// Prevent rendering dropdown if user isn't available.
// We don't want to show nameless user.
if (!user) {
if (!user && !isPending) {
return null;
}
return (
<Dropdown open={menuOpen}>
<DropdownMenuTrigger asChild onClick={() => setMenuOpen((menuOpen) => !menuOpen)}>
<DropdownMenuTrigger asChild onClick={() => setMenuOpen((menuOpen) => !menuOpen)} disabled={isPending}>
<button
data-testid="user-dropdown-trigger-button"
className={classNames(
@@ -85,8 +85,8 @@ export function UserDropdown({ small }: UserDropdownProps) {
)}>
<Avatar
size={small ? "xs" : "xsm"}
imageSrc={`${user.avatarUrl || user.avatar}`}
alt={user.username || "Nameless User"}
imageSrc={user?.avatarUrl ?? user?.avatar}
alt={user?.username ? `${user.username} Avatar` : "Nameless User Avatar"}
className="overflow-hidden"
/>
<span
@@ -100,7 +100,7 @@ export function UserDropdown({ small }: UserDropdownProps) {
<span className="flex flex-grow items-center gap-2">
<span className="w-24 flex-shrink-0 text-sm leading-none">
<span className="text-emphasis block truncate py-0.5 font-medium leading-normal">
{user.name || "Nameless User"}
{isPending ? "Loading..." : user?.name ?? "Nameless User"}
</span>
</span>
<Icon