fix(ui): change phone booking display from Organizer Phone Number to Phone Call (#27636)
* fix(ui): change phone booking display from Organizer Phone Number to Phone Call The label \"Organizer Phone Number\" was confusing for attendees on the booking page, as it exposed internal terminology. Replaced with the more user-friendly \"Phone Call\" label across the booking UI, companion app, and test assertions. Closes #13010 * fix: remove duplicate phone_call i18n key The phone_call key already existed in en/common.json (line 1685, Cal.ai Voice Agent section). Removed the duplicate entry we added. Found by ai-codex review.
This commit is contained in:
@@ -47,7 +47,7 @@ vi.mock("@calcom/features/form/components/LocationSelect", () => {
|
||||
});
|
||||
|
||||
const AttendeePhoneNumberLabel = "Attendee phone number";
|
||||
const OrganizerPhoneLabel = "Organizer phone number";
|
||||
const OrganizerPhoneLabel = "Phone call";
|
||||
const CampfireLabel = "Campfire";
|
||||
const ZoomVideoLabel = "Zoom Video";
|
||||
const OrganizerDefaultConferencingAppLabel = "Organizer's default app";
|
||||
@@ -202,7 +202,7 @@ describe("EditLocationDialog", () => {
|
||||
});
|
||||
|
||||
describe("Team Booking Case", () => {
|
||||
it("should not show Attendee Phone Number but show Organizer Phone Number and dynamic link Conferencing apps", async () => {
|
||||
it("should not show Attendee Phone Number but show Phone Call option and dynamic link Conferencing apps", async () => {
|
||||
render(<EditLocationDialog {...mockProps} booking={{ location: "Office" }} teamId={1} />);
|
||||
|
||||
expect(screen.queryByText(AttendeePhoneNumberLabel)).not.toBeInTheDocument();
|
||||
|
||||
@@ -365,7 +365,7 @@ test.describe("Event Types tests", () => {
|
||||
await page.getByTestId(removeButtomId).nth(0).click();
|
||||
await page.getByTestId(removeButtomId).nth(0).click();
|
||||
|
||||
// Add Multiple Organizer Phone Number options
|
||||
// Add Multiple Phone Call location options
|
||||
await page.getByTestId("location-select").last().click();
|
||||
await page.getByTestId("location-select-item-userPhone").click();
|
||||
|
||||
|
||||
@@ -62,7 +62,7 @@ export const defaultLocations = [
|
||||
{ label: "Organizer Address", type: "inPerson" as const },
|
||||
{ label: "Link Meeting", type: "link" as const },
|
||||
{ label: "Attendee Phone Number", type: "phone" as const },
|
||||
{ label: "Organizer Phone Number", type: "userPhone" as const },
|
||||
{ label: "Phone Call", type: "userPhone" as const },
|
||||
];
|
||||
|
||||
export const tabs = [
|
||||
|
||||
@@ -71,7 +71,7 @@ export const defaultLocations: DefaultLocation[] = [
|
||||
},
|
||||
{
|
||||
type: DefaultLocationType.UserPhone,
|
||||
label: "Organizer Phone Number",
|
||||
label: "Phone Call",
|
||||
iconUrl: "https://app.cal.com/phone.svg",
|
||||
category: "phone",
|
||||
organizerInputType: "phone",
|
||||
|
||||
@@ -83,7 +83,7 @@ export function mapApiLocationToItem(apiLocation: ApiLocation): LocationItem {
|
||||
id,
|
||||
type: "phone",
|
||||
phone: apiLocation.phone || "",
|
||||
displayName: "Organizer Phone Number",
|
||||
displayName: "Phone Call",
|
||||
iconUrl: "https://app.cal.com/phone.svg",
|
||||
public: apiLocation.public,
|
||||
};
|
||||
@@ -198,7 +198,7 @@ export function getLocationDisplayName(locationType: string, integration?: strin
|
||||
address: "In Person (Organizer Address)",
|
||||
attendeeAddress: "In Person (Attendee Address)",
|
||||
link: "Link Meeting",
|
||||
phone: "Organizer Phone Number",
|
||||
phone: "Phone Call",
|
||||
attendeePhone: "Attendee Phone Number",
|
||||
attendeeDefined: "Custom Attendee Location",
|
||||
};
|
||||
|
||||
@@ -192,7 +192,7 @@ export const defaultLocations: DefaultEventLocationType[] = [
|
||||
{
|
||||
default: true,
|
||||
type: DefaultEventLocationTypeEnum.UserPhone,
|
||||
label: "organizer_phone_number",
|
||||
label: "phone_call",
|
||||
messageForOrganizer: "Provide your phone number",
|
||||
organizerInputType: "phone",
|
||||
organizerInputLabel: "phone_number",
|
||||
@@ -209,7 +209,7 @@ const translateAbleKeys = [
|
||||
"in_person",
|
||||
"attendee_phone_number",
|
||||
"link_meeting",
|
||||
"organizer_phone_number",
|
||||
"phone_call",
|
||||
"organizer_default_conferencing_app",
|
||||
"somewhere_else",
|
||||
"custom_attendee_location",
|
||||
|
||||
Reference in New Issue
Block a user