fix: repeatedly occurring flaky tests (#20238)

* fix flaky tests

* minor tweak in ooo tests

* chore

* update: fill description at end

apps/web/playwright/bookings-list.e2e.ts

@@ -341,7 +341,11 @@ test.describe("Bookings", () => {
     //admin login
     //Select 'ThirdUser' in people filter
     await firstUser.apiLogin();
+    const bookingsGetResponse = page.waitForResponse((response) =>
+      /\/api\/trpc\/bookings\/get.*/.test(response.url())
+    );
     await page.goto(`/bookings/upcoming`);
+    await bookingsGetResponse;
 
     await page.locator('[data-testid="add-filter-button"]').click();
     await page.locator('[data-testid="add-filter-item-userId"]').click();

apps/web/playwright/out-of-office.e2e.ts

@@ -760,8 +760,8 @@ test.describe("Out of office", () => {
         (response) => response.url().includes("outOfOfficeEntriesList") && response.status() === 200
       );
       await page.goto("/settings/my-account/out-of-office");
-      await page.waitForLoadState("domcontentloaded");
       await entriesListRespPromise;
+      await page.waitForLoadState("domcontentloaded");
 
       //By Default future OOO will be displayed
       //1 OOO record should be visible for member3, end=currentDate+4days
@@ -772,10 +772,11 @@ test.describe("Out of office", () => {
       await test.step("Default filter - 'Last 7 Days'", async () => {
         await page.locator('[data-testid="add-filter-button"]').click();
         await page.locator('[data-testid="add-filter-item-dateRange"]').click();
-        await page.waitForResponse(
+        const entriesListRespPromise = page.waitForResponse(
           (response) => response.url().includes("outOfOfficeEntriesList") && response.status() === 200
         );
         await page.locator('[data-testid="add-filter-button"]').click();
+        await entriesListRespPromise;
 
         //1 OOO record should be visible for member3, end=currentDate-4days
         expect(await page.locator('[data-testid^="table-redirect-"]').count()).toBe(1);
@@ -788,10 +789,11 @@ test.describe("Out of office", () => {
       await test.step("select 'Last 30 Days'", async () => {
         await page.locator('[data-testid="filter-popover-trigger-dateRange"]').click();
         await page.locator(`[data-testid="date-range-options-t"]`).click();
-        await page.waitForResponse(
+        const entriesListRespPromise = page.waitForResponse(
           (response) => response.url().includes("outOfOfficeEntriesList") && response.status() === 200
         );
         await page.locator('[data-testid="filter-popover-trigger-dateRange"]').click();
+        await entriesListRespPromise;
 
         //2 OOO records should be visible end=currentDate-4days, end=currentDate-12days
         expect(await page.locator('[data-testid^="table-redirect-"]').count()).toBe(2);

packages/app-store/routing-forms/playwright/tests/basic.e2e.ts

@@ -828,9 +828,12 @@ async function addAllTypesOfFieldsAndSaveForm(
   page: Page,
   form: { description: string; label: string }
 ) {
+  const appRoutingFormsRespPromise = page.waitForResponse((response) =>
+    /\/api\/trpc\/appRoutingForms*/.test(response.url())
+  );
   await page.goto(`apps/routing-forms/form-edit/${formId}`);
+  await appRoutingFormsRespPromise;
   await page.click('[data-testid="add-field"]');
-  await page.fill('[data-testid="description"]', form.description);
 
   const { optionsInUi: fieldTypesList } = await verifySelectOptions(
     { selector: ".data-testid-field-type", nth: 0 },
@@ -876,6 +879,7 @@ async function addAllTypesOfFieldsAndSaveForm(
     fields.push({ identifier: identifier, label, type: fieldTypeLabel });
   }
 
+  await page.fill('[data-testid="description"]', form.description);
   await saveCurrentForm(page);
   return {
     fieldTypesList,