commonscomputer/cal.diy
4
0
Fork 0
Code Issues Pull Requests Actions 2.2k Packages Projects Releases Wiki Activity

fix: failing tests during DST transition (#19862)

Browse Source 
* make the test dst transition proof

* fix other test similarly
This commit is contained in:
Vijay
2025-03-09 00:43:42 +00:00
committed by GitHub
parent ae659b5176
commit f8af9dc17e
2 changed files with 36 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/features/bookings/lib/handleNewBooking/test/complex-schedules.test.ts
+18 -2
View File
@@ -56,19 +56,35 @@ describe("handleNewBooking", () => {
});
// Using .endOf("day") here to ensure our date doesn't change when we set the time zone
const startDateTimeOrganizerTz = dayjs(plus1DateString)
let startDateTimeOrganizerTz = dayjs(plus1DateString)
.endOf("day")
.tz(newYorkTimeZone)
.hour(23)
.minute(0)
.second(0);
const endDateTimeOrganizerTz = dayjs(plus1DateString)
let endDateTimeOrganizerTz = dayjs(plus1DateString)
.endOf("day")
.tz(newYorkTimeZone)
.startOf("day")
.add(1, "day");
const endUtcOffset = Math.abs(endDateTimeOrganizerTz.utcOffset());
const startUtcOffset = Math.abs(startDateTimeOrganizerTz.utcOffset());
//on DST transition day the utc offsets are unequal
if (startUtcOffset !== endUtcOffset) {
if (endUtcOffset > startUtcOffset) {
// -5:00 to -4:00 transition
endDateTimeOrganizerTz = endDateTimeOrganizerTz.subtract(
endUtcOffset - startUtcOffset,
"minutes"
);
} else {
// -4:00 to -5:00 transition
startDateTimeOrganizerTz = startDateTimeOrganizerTz.add(startUtcOffset - endUtcOffset, "minutes");
}
}
const schedule = {
name: "4:00PM to 11:59PM in New York",
availability: [
packages/features/bookings/lib/handleNewBooking/test/date-overrides.test.ts
+18 -2
View File
@@ -221,19 +221,35 @@ describe("handleNewBooking", () => {
});
// Using .endOf("day") here to ensure our date doesn't change when we set the time zone
const startDateTimeOrganizerTz = dayjs(plus1DateString)
let startDateTimeOrganizerTz = dayjs(plus1DateString)
.endOf("day")
.tz(newYorkTimeZone)
.hour(23)
.minute(0)
.second(0);
const endDateTimeOrganizerTz = dayjs(plus1DateString)
let endDateTimeOrganizerTz = dayjs(plus1DateString)
.endOf("day")
.tz(newYorkTimeZone)
.startOf("day")
.add(1, "day");
const endUtcOffset = Math.abs(endDateTimeOrganizerTz.utcOffset());
const startUtcOffset = Math.abs(startDateTimeOrganizerTz.utcOffset());
//on DST transition day the utc offsets are unequal
if (startUtcOffset !== endUtcOffset) {
if (endUtcOffset > startUtcOffset) {
// -5:00 to -4:00 transition
endDateTimeOrganizerTz = endDateTimeOrganizerTz.subtract(
endUtcOffset - startUtcOffset,
"minutes"
);
} else {
// -4:00 to -5:00 transition
startDateTimeOrganizerTz = startDateTimeOrganizerTz.add(startUtcOffset - endUtcOffset, "minutes");
}
}
const overrideSchedule = {
name: "11:00PM to 11:59PM in New York",
availability: [