Compare commits
134
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
2965450929 | ||
|
|
db9b9c45dc | ||
|
|
37f500526c | ||
|
|
006aecb066 | ||
|
|
0829929e98 | ||
|
|
a61148cb51 | ||
|
|
593c48c8b4 | ||
|
|
fb364971fa | ||
|
|
a2205d497d | ||
|
|
cf4e7a5d2c | ||
|
|
0e2ee3adb2 | ||
|
|
dbe8a85cf5 | ||
|
|
84210dc1b4 | ||
|
|
4061bfb3fe | ||
|
|
18059e50fa | ||
|
|
852eb346ed | ||
|
|
b7e11dc112 | ||
|
|
35a373e70a | ||
|
|
02c0b721b9 | ||
|
|
29349845f8 | ||
|
|
28cb2cff64 | ||
|
|
9cb2eb3b8c | ||
|
|
6ff20b98f4 | ||
|
|
aa618dbaa2 | ||
|
|
6e3de84067 | ||
|
|
c6b19200a9 | ||
|
|
91932212e3 | ||
|
|
f81bb92beb | ||
|
|
1d1a242a72 | ||
|
|
ad4af64036 | ||
|
+5 |
2cc7827b0e | ||
|
|
ef6618743d | ||
|
|
3601a9adf1 | ||
|
|
0cc2367556 | ||
|
|
f7b201b0b5 | ||
|
|
82063cc9a1 | ||
|
|
4b2f89d6e8 | ||
|
|
5360cb511d | ||
|
|
704bbf2757 | ||
|
|
7fef683abf | ||
|
|
63df3d9c14 | ||
|
|
32d2fd51e5 | ||
|
|
016a966057 | ||
|
|
dc967cffbe | ||
|
|
4489cb8fde | ||
|
|
babd514c64 | ||
|
|
2e5cc11f29 | ||
|
|
84bc330fa8 | ||
|
|
4cb7e4a91a | ||
|
|
d1bd05a791 | ||
|
|
96a6350143 | ||
|
|
c8bea5b143 | ||
|
|
1cdd8ebc53 | ||
|
|
d78ed21a9f | ||
|
|
4e92b6edeb | ||
|
|
7b2f811bfe | ||
|
|
7b6d5d6de3 | ||
|
|
12b418b532 | ||
|
|
3e299f9511 | ||
|
|
1b9691ddaf | ||
|
|
a11ea3dd1e | ||
|
|
b21400c613 | ||
|
|
6c936472d2 | ||
|
|
3b823670ea | ||
|
|
6b10127d97 | ||
|
|
9cd806ff61 | ||
|
|
628b169f53 | ||
|
|
19d7764e9d | ||
|
|
30061c0d58 | ||
|
|
ee073cdf35 | ||
|
|
4ff5f5f3fa | ||
|
|
f905ae7502 | ||
|
|
a1c0daa1b5 | ||
|
|
b155d736d8 | ||
|
|
e42013bee1 | ||
|
|
fde1d671fb | ||
|
|
9ccf5f3723 | ||
|
|
91ee225f14 | ||
|
|
e6a0a0fc69 | ||
|
|
e98024b08e | ||
|
|
8d54d80dee | ||
|
|
751aa62935 | ||
|
|
f149650911 | ||
|
|
f901fba0fc | ||
|
|
cd50719b03 | ||
|
|
000324c02d | ||
|
|
cc6beedfb0 | ||
|
|
1d28215c5e | ||
|
|
045ea34580 | ||
|
|
3228d8d869 | ||
|
|
6b9115dfde | ||
|
|
6259b0b3cb | ||
|
|
f991669b8d | ||
|
|
b93568359a | ||
|
|
66b52bb19f | ||
|
|
b9c49b4567 | ||
|
|
29e1dcb43c | ||
|
|
3ab676794f | ||
|
|
877fdbf46a | ||
|
|
b05e1b4589 | ||
|
|
611f76bf68 | ||
|
|
9b886036ad | ||
|
|
c88ed8cae7 | ||
|
|
098b520129 | ||
|
|
eb4eebe6f9 | ||
|
|
16a7bb7bc5 | ||
|
|
ee9699e267 | ||
|
|
7813d3739f | ||
|
|
fa47456d5f | ||
|
|
dbaa0727ae | ||
|
|
42a4a38939 | ||
|
|
97bde083ca | ||
|
|
48bd12be32 | ||
|
|
0cbc8a3816 | ||
|
|
4e1048b221 | ||
|
|
cb78692347 | ||
|
|
3784421f02 | ||
|
|
e7535b9db3 | ||
|
|
bb4260c98b | ||
|
|
9d65b6f794 | ||
|
|
4874c6c2ee | ||
|
|
30a92a4d66 | ||
|
|
04ce054cf7 | ||
|
|
e901e8d189 | ||
|
|
0aa595ddac | ||
|
|
2115a045ec | ||
|
|
f67522dbbd | ||
|
|
dc5aef0dd4 | ||
|
|
e1d7631215 | ||
|
|
05e1ad0c91 | ||
|
|
cf392562da | ||
|
|
c8de8ca681 | ||
|
|
2c91c0e309 | ||
|
|
cef007d852 |
@@ -1,5 +1,13 @@
|
||||
# Review Instructions
|
||||
|
||||
## File Naming Conventions
|
||||
|
||||
- **Repository Files**: Must include `Repository` suffix, prefix with technology if applicable (e.g., `PrismaAppRepository.ts`), use PascalCase matching exported class
|
||||
- **Service Files**: Must include `Service` suffix, use PascalCase matching exported class, avoid generic names (e.g., `MembershipService.ts`)
|
||||
- **New files**: Avoid dot-suffixes like `.service.ts` or `.repository.ts`; reserve `.test.ts`, `.spec.ts`, `.types.ts` for their specific purposes
|
||||
|
||||
## Code Quality
|
||||
|
||||
- Prefer early returns. It is recommended to throw/return early so we can ensure null-checks and prevent further nesting.
|
||||
- Prefer Composition over Prop Drilling. Instead of relying on prop drilling, let's try to take advantage of react children feature.
|
||||
- For Prisma queries:
|
||||
@@ -19,3 +27,10 @@
|
||||
- "summary" fields do not end with a period
|
||||
- "summary" fields are written in proper American english
|
||||
- When changes to API v2 or v1 are made, ensure there are no breaking changes on existing endpoints. Instead, there needs to be a newly versioned endpoint with the updated functionality but the old one must remain functional
|
||||
- For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs:
|
||||
- Split by feature boundaries: separate different features or user stories
|
||||
- Split by layer/component: frontend changes, backend changes, database migrations, and tests in separate PRs
|
||||
- Split by dependency chain: create PRs that can be merged sequentially
|
||||
- Split by file/module: group related file changes together
|
||||
- Suggested pattern: Database migrations → Backend logic → Frontend components → Integration tests
|
||||
- Benefits: easier review, faster feedback, reduced conflicts, easier rollback, better history
|
||||
|
||||
@@ -34,4 +34,7 @@ jobs:
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
|
||||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
|
||||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
|
||||
VITE_BOOKER_EMBED_OAUTH_CLIENT_ID: ${{ secrets.VITE_BOOKER_EMBED_OAUTH_CLIENT_ID }}
|
||||
VITE_BOOKER_EMBED_API_URL: ${{ secrets.VITE_BOOKER_EMBED_API_URL }}
|
||||
NEXT_PUBLIC_WEBAPP_URL: ${{ secrets.NEXT_PUBLIC_WEBAPP_URL }}
|
||||
Vendored
+2
@@ -0,0 +1,2 @@
|
||||
undecided:
|
||||
- "@calcom/prisma"
|
||||
Vendored
+3
@@ -0,0 +1,3 @@
|
||||
undecided:
|
||||
- calcom-monorepo
|
||||
- "@calcom/prisma"
|
||||
Vendored
+2
@@ -0,0 +1,2 @@
|
||||
undecided:
|
||||
- "@calcom/prisma"
|
||||
Vendored
+2
@@ -0,0 +1,2 @@
|
||||
undecided:
|
||||
- "@calcom/prisma"
|
||||
Vendored
Vendored
+3
@@ -0,0 +1,3 @@
|
||||
undecided:
|
||||
- calcom-monorepo
|
||||
- "@calcom/prisma"
|
||||
Vendored
Vendored
Vendored
+2
@@ -0,0 +1,2 @@
|
||||
undecided:
|
||||
- "@calcom/prisma"
|
||||
@@ -95,6 +95,57 @@ Write with the future in mind. If there are trade-offs, edge cases, or temporary
|
||||
</tr>
|
||||
</table>
|
||||
|
||||
## File Naming Conventions
|
||||
|
||||
To ensure consistency and make files easy to fuzzy-find, we follow the naming conventions below for **services**, **repositories**, and other class-based files.
|
||||
|
||||
### Repository Files
|
||||
|
||||
- Repository class files must include the `Repository` suffix.
|
||||
- If the repository is backed by a specific technology (e.g. Prisma), prefix the filename and class name with it.
|
||||
- File name must match the exported class exactly (PascalCase).
|
||||
|
||||
**Pattern:**
|
||||
|
||||
`Prisma<Entity>Repository.ts`
|
||||
|
||||
**Examples:**
|
||||
|
||||
```ts
|
||||
// File: PrismaAppRepository.ts
|
||||
export class PrismaAppRepository { ... }
|
||||
|
||||
// File: PrismaMembershipRepository.ts
|
||||
export class PrismaMembershipRepository { ... }
|
||||
```
|
||||
|
||||
This avoids ambiguous filenames like app.ts and improves discoverability in editors.
|
||||
|
||||
### Service Files
|
||||
|
||||
- Service class files must include the Service suffix.
|
||||
- File name should be in PascalCase, matching the exported class.
|
||||
- Keep naming specific — avoid generic names like AppService.ts.
|
||||
|
||||
**Pattern:**
|
||||
|
||||
`<Entity>Service.ts`
|
||||
|
||||
**Examples:**
|
||||
|
||||
```ts
|
||||
// File: MembershipService.ts
|
||||
export class MembershipService { ... }
|
||||
|
||||
// File: HashedLinkService.ts
|
||||
export class HashedLinkService { ... }
|
||||
```
|
||||
|
||||
**Note:**
|
||||
|
||||
- New files must avoid dot-suffixes like .service.ts or .repository.ts; these will be migrated from the existing codebase progressively.
|
||||
- We still reserve suffixes such as .test.ts, .spec.ts, and .types.ts for their respective use cases.
|
||||
|
||||
## Developing
|
||||
|
||||
[See README](https://github.com/calcom/cal.com#development)
|
||||
|
||||
@@ -80,6 +80,8 @@ That's where Cal.com comes in. Self-hosted or hosted by us. White-label by desig
|
||||
|
||||
<a href="https://producthunt.com/posts/calendso?utm_source=badge-top-post-badge&utm_medium=badge&utm_souce=badge-calendso" target="_blank"><img src="https://api.producthunt.com/widgets/embed-image/v1/top-post-badge.svg?post_id=291910&theme=light&period=monthly" alt="Cal.com - The open source Calendly alternative | Product Hunt" style="width: 250px; height: 54px;" width="250" height="54" /></a> <a href="https://producthunt.com/posts/calendso?utm_source=badge-featured&utm_medium=badge&utm_souce=badge-calendso" target="_blank"><img src="https://api.producthunt.com/widgets/embed-image/v1/featured.svg?post_id=291910&theme=light" alt="Cal.com - The open source Calendly alternative | Product Hunt" style="width: 250px; height: 54px;" width="250" height="54" /></a> <a href="https://producthunt.com/stories/how-this-open-source-calendly-alternative-rocketed-to-product-of-the-day" target="_blank"><img src="https://cal.com/maker-grant.svg" alt="Cal.com - The open source Calendly alternative | Product Hunt" style="width: 250px; height: 54px;" width="250" height="54" /></a>
|
||||
|
||||
This project is tested with browserstack
|
||||
|
||||
### Built With
|
||||
|
||||
- [Next.js](https://nextjs.org/?ref=cal.com)
|
||||
|
||||
@@ -1,4 +1,6 @@
|
||||
# Checkly Tests
|
||||
|
||||
Run as `yarn checkly test`
|
||||
Optionally, run as `yarn checkly test --record` to be able to get detailed debugging view in Checkly UI
|
||||
Run the tests for a particylar file as `yarn checkly test {filePattern}`
|
||||
Deploy the tests as `yarn checkly deploy`
|
||||
|
||||
@@ -0,0 +1,22 @@
|
||||
import { test, expect } from "@playwright/test";
|
||||
|
||||
test.describe("CSP Headers", () => {
|
||||
test("Login page should have CSP header with nonce", async ({ page }) => {
|
||||
const targetUrl = process.env.ENVIRONMENT_URL || "https://app.cal.com";
|
||||
|
||||
const response = await page.goto(`${targetUrl}/auth/login`);
|
||||
|
||||
expect(response?.status()).toBe(200);
|
||||
|
||||
const cspHeader = response?.headers()["content-security-policy"];
|
||||
expect(cspHeader).toBeTruthy();
|
||||
|
||||
// Verify nonce is present in CSP header
|
||||
const nonceMatch = cspHeader?.match(/'nonce-([^']+)'/);
|
||||
expect(nonceMatch).toBeTruthy();
|
||||
expect(nonceMatch![1]).toHaveLength(24);
|
||||
expect(nonceMatch![1]).toMatch(/==$/);
|
||||
|
||||
await page.screenshot({ path: "screenshot.jpg" });
|
||||
});
|
||||
});
|
||||
@@ -14,11 +14,21 @@ import { MembershipRole, UserPermissionRole } from "@calcom/prisma/enums";
|
||||
|
||||
import { verifyApiKey } from "./verifyApiKey";
|
||||
|
||||
vi.mock("@calcom/lib/crypto", () => ({
|
||||
symmetricDecrypt: vi.fn().mockReturnValue("mocked-decrypted-value"),
|
||||
symmetricEncrypt: vi.fn().mockReturnValue("mocked-encrypted-value"),
|
||||
}));
|
||||
|
||||
type CustomNextApiRequest = NextApiRequest & Request;
|
||||
type CustomNextApiResponse = NextApiResponse & Response;
|
||||
|
||||
beforeEach(() => {
|
||||
vi.stubEnv("CALENDSO_ENCRYPTION_KEY", "22gfxhWUlcKliUeXcu8xNah2+HP/29ZX");
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.resetAllMocks();
|
||||
vi.unstubAllEnvs();
|
||||
});
|
||||
|
||||
const mockDeploymentRepository: IDeploymentRepository = {
|
||||
@@ -26,8 +36,7 @@ const mockDeploymentRepository: IDeploymentRepository = {
|
||||
getSignatureToken: vi.fn().mockResolvedValue("mockSignatureToken"),
|
||||
};
|
||||
|
||||
// TODO: Fix the skip condition for this test suite
|
||||
describe.skip("Verify API key", () => {
|
||||
describe("Verify API key", () => {
|
||||
let service: ILicenseKeyService;
|
||||
|
||||
beforeEach(async () => {
|
||||
|
||||
@@ -38,7 +38,7 @@
|
||||
"next-axiom": "^0.17.0",
|
||||
"next-swagger-doc": "^0.3.6",
|
||||
"next-validations": "^0.2.0",
|
||||
"typescript": "^5.7.2",
|
||||
"typescript": "^5.9.0-beta",
|
||||
"tzdata": "^1.0.30",
|
||||
"uuid": "^8.3.2",
|
||||
"zod": "^3.22.4"
|
||||
|
||||
@@ -1,5 +1,7 @@
|
||||
import type { NextApiRequest } from "next";
|
||||
|
||||
import { ErrorCode } from "@calcom/lib/errorCodes";
|
||||
import { ErrorWithCode } from "@calcom/lib/errors";
|
||||
import { defaultResponder } from "@calcom/lib/server/defaultResponder";
|
||||
import prisma from "@calcom/prisma";
|
||||
|
||||
@@ -106,6 +108,11 @@ export async function getHandler(req: NextApiRequest) {
|
||||
eventType: expand.includes("team") ? { include: { team: true } } : false,
|
||||
},
|
||||
});
|
||||
|
||||
if (!booking) {
|
||||
throw new ErrorWithCode(ErrorCode.BookingNotFound, "Booking not found");
|
||||
}
|
||||
|
||||
return { booking: schemaBookingReadPublic.parse(booking) };
|
||||
}
|
||||
|
||||
|
||||
@@ -254,6 +254,14 @@ async function handler(req: NextApiRequest) {
|
||||
throw new HttpError({ statusCode: 400, message: knownError.message });
|
||||
}
|
||||
|
||||
if (knownError?.message === ErrorCode.RequestBodyInvalid) {
|
||||
throw new HttpError({ statusCode: 400, message: knownError.message });
|
||||
}
|
||||
|
||||
if (knownError?.message === ErrorCode.EventTypeNotFound) {
|
||||
throw new HttpError({ statusCode: 400, message: knownError.message });
|
||||
}
|
||||
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,184 @@
|
||||
import prismaMock from "../../../../../../../tests/libs/__mocks__/prismaMock";
|
||||
|
||||
import type { Request, Response } from "express";
|
||||
import type { NextApiRequest, NextApiResponse } from "next";
|
||||
import { createMocks } from "node-mocks-http";
|
||||
import { describe, expect, test, vi, afterEach, beforeEach } from "vitest";
|
||||
|
||||
import { buildBooking, buildEventType } from "@calcom/lib/test/builder";
|
||||
|
||||
import handler from "../../../../pages/api/bookings/[id]/_delete";
|
||||
|
||||
vi.mock("@calcom/features/bookings/lib/handleCancelBooking", () => ({
|
||||
default: vi.fn().mockResolvedValue({ success: true }),
|
||||
handleCancelBooking: vi.fn().mockResolvedValue({ success: true }),
|
||||
}));
|
||||
|
||||
type CustomNextApiRequest = NextApiRequest & Request;
|
||||
type CustomNextApiResponse = NextApiResponse & Response;
|
||||
|
||||
const userId = 1;
|
||||
const bookingId = 123;
|
||||
|
||||
beforeEach(() => {
|
||||
prismaMock.user.findUnique.mockResolvedValue({
|
||||
id: userId,
|
||||
email: "test@example.com",
|
||||
name: "Test User",
|
||||
});
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.resetAllMocks();
|
||||
});
|
||||
|
||||
describe("DELETE /api/bookings/[id]", () => {
|
||||
describe("Success", () => {
|
||||
test("should cancel booking successfully", async () => {
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "DELETE",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
reason: "User requested cancellation",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const responseData = JSON.parse(res._getData());
|
||||
expect(responseData.success).toBe(true);
|
||||
});
|
||||
|
||||
test("should allow system-wide admin to cancel any booking", async () => {
|
||||
const adminUserId = 999;
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "DELETE",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
reason: "Admin cancellation",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = adminUserId;
|
||||
req.isSystemWideAdmin = true;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
});
|
||||
});
|
||||
|
||||
describe("Errors", () => {
|
||||
test("should return 404 when booking not found", async () => {
|
||||
prismaMock.booking.findUnique.mockResolvedValue(null);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "DELETE",
|
||||
query: {
|
||||
id: "999",
|
||||
},
|
||||
body: {
|
||||
reason: "Test cancellation",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
});
|
||||
|
||||
test("should return 400 for invalid booking ID", async () => {
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "DELETE",
|
||||
query: {
|
||||
id: "invalid",
|
||||
},
|
||||
body: {
|
||||
reason: "Test cancellation",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test("should return 403 when user doesn't have permission to cancel booking", async () => {
|
||||
const otherUserId = 999;
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: otherUserId,
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "DELETE",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
reason: "Unauthorized cancellation",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
});
|
||||
|
||||
test("should return 400 when required cancellation reason is missing", async () => {
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "DELETE",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,263 @@
|
||||
import prismaMock from "../../../../../../../tests/libs/__mocks__/prismaMock";
|
||||
|
||||
import type { Request, Response } from "express";
|
||||
import type { NextApiRequest, NextApiResponse } from "next";
|
||||
import { createMocks } from "node-mocks-http";
|
||||
import { describe, expect, test, vi, afterEach, beforeEach } from "vitest";
|
||||
|
||||
import { buildBooking, buildEventType } from "@calcom/lib/test/builder";
|
||||
|
||||
import handler from "../../../../pages/api/bookings/[id]/_patch";
|
||||
|
||||
type CustomNextApiRequest = NextApiRequest & Request;
|
||||
type CustomNextApiResponse = NextApiResponse & Response;
|
||||
|
||||
const userId = 1;
|
||||
const bookingId = 123;
|
||||
|
||||
beforeEach(() => {
|
||||
prismaMock.user.findUnique.mockResolvedValue({
|
||||
id: userId,
|
||||
email: "test@example.com",
|
||||
name: "Test User",
|
||||
});
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.resetAllMocks();
|
||||
});
|
||||
|
||||
describe("PATCH /api/bookings/[id]", () => {
|
||||
describe("Success", () => {
|
||||
test("should update booking successfully", async () => {
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
title: "Original Title",
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
const updatedBooking = {
|
||||
...mockBooking,
|
||||
title: "Updated Title",
|
||||
};
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
prismaMock.booking.update.mockResolvedValue(updatedBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
title: "Updated Title",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const responseData = JSON.parse(res._getData());
|
||||
expect(responseData.booking.title).toBe("Updated Title");
|
||||
});
|
||||
|
||||
test("should allow system-wide admin to update any booking", async () => {
|
||||
const adminUserId = 999;
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
title: "Original Title",
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
const updatedBooking = {
|
||||
...mockBooking,
|
||||
title: "Admin Updated Title",
|
||||
};
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
prismaMock.booking.update.mockResolvedValue(updatedBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
title: "Admin Updated Title",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = adminUserId;
|
||||
req.isSystemWideAdmin = true;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
});
|
||||
|
||||
test("should update booking times successfully", async () => {
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
startTime: new Date("2024-01-01T10:00:00Z"),
|
||||
endTime: new Date("2024-01-01T11:00:00Z"),
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
const newStartTime = new Date("2024-01-01T14:00:00Z");
|
||||
const newEndTime = new Date("2024-01-01T15:00:00Z");
|
||||
|
||||
const updatedBooking = {
|
||||
...mockBooking,
|
||||
startTime: newStartTime,
|
||||
endTime: newEndTime,
|
||||
};
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
prismaMock.booking.update.mockResolvedValue(updatedBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
startTime: newStartTime.toISOString(),
|
||||
endTime: newEndTime.toISOString(),
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const responseData = JSON.parse(res._getData());
|
||||
expect(new Date(responseData.booking.startTime)).toEqual(newStartTime);
|
||||
expect(new Date(responseData.booking.endTime)).toEqual(newEndTime);
|
||||
});
|
||||
});
|
||||
|
||||
describe("Errors", () => {
|
||||
test("should return 404 when booking not found", async () => {
|
||||
prismaMock.booking.findUnique.mockResolvedValue(null);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: "999",
|
||||
},
|
||||
body: {
|
||||
title: "Updated Title",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test("should return 400 for invalid booking ID", async () => {
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: "invalid",
|
||||
},
|
||||
body: {
|
||||
title: "Updated Title",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test("should return 403 when user doesn't have permission to update booking", async () => {
|
||||
const otherUserId = 999;
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: otherUserId,
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
title: "Unauthorized Update",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test("should return 401 when non-admin tries to change userId", async () => {
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
userId: 999,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(403);
|
||||
});
|
||||
|
||||
test("should return 400 for invalid date format", async () => {
|
||||
const mockBooking = buildBooking({
|
||||
id: bookingId,
|
||||
userId: userId,
|
||||
eventTypeId: buildEventType().id,
|
||||
});
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue(mockBooking);
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "PATCH",
|
||||
query: {
|
||||
id: bookingId.toString(),
|
||||
},
|
||||
body: {
|
||||
startTime: "invalid-date",
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,362 @@
|
||||
import prismaMock from "../../../../../../tests/libs/__mocks__/prismaMock";
|
||||
|
||||
import type { Request, Response } from "express";
|
||||
import type { NextApiRequest, NextApiResponse } from "next";
|
||||
import { createMocks } from "node-mocks-http";
|
||||
import { describe, expect, test, vi, afterEach, beforeEach } from "vitest";
|
||||
import { ZodError } from "zod";
|
||||
|
||||
import { buildBooking } from "@calcom/lib/test/builder";
|
||||
|
||||
import {
|
||||
getAccessibleUsers,
|
||||
retrieveOrgScopedAccessibleUsers,
|
||||
} from "~/lib/utils/retrieveScopedAccessibleUsers";
|
||||
|
||||
import { handler } from "../../../pages/api/bookings/_get";
|
||||
|
||||
vi.mock("~/lib/utils/retrieveScopedAccessibleUsers", () => ({
|
||||
getAccessibleUsers: vi.fn(),
|
||||
retrieveOrgScopedAccessibleUsers: vi.fn(),
|
||||
}));
|
||||
|
||||
type CustomNextApiRequest = NextApiRequest & Request;
|
||||
type CustomNextApiResponse = NextApiResponse & Response;
|
||||
|
||||
const userId = 1;
|
||||
|
||||
beforeEach(() => {
|
||||
prismaMock.user.findUnique.mockResolvedValue({
|
||||
id: userId,
|
||||
email: "test@example.com",
|
||||
name: "Test User",
|
||||
});
|
||||
(getAccessibleUsers as any).mockResolvedValue([userId]);
|
||||
(retrieveOrgScopedAccessibleUsers as any).mockResolvedValue([userId]);
|
||||
|
||||
prismaMock.membership.findMany.mockResolvedValue([
|
||||
{
|
||||
team: {
|
||||
id: 1,
|
||||
isOrganization: true,
|
||||
},
|
||||
},
|
||||
]);
|
||||
|
||||
prismaMock.user.findMany.mockResolvedValue([
|
||||
{
|
||||
id: userId,
|
||||
email: "test@example.com",
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.resetAllMocks();
|
||||
});
|
||||
|
||||
describe("GET /api/bookings", () => {
|
||||
describe("Query parameter validation", () => {
|
||||
test("should validate status parameter correctly", async () => {
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
status: "invalid_status",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await expect(handler(req)).rejects.toThrow(ZodError);
|
||||
});
|
||||
|
||||
test("should accept valid status parameter", async () => {
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
prismaMock.booking.count.mockResolvedValue(0);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
status: "upcoming",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toEqual([]);
|
||||
});
|
||||
|
||||
test("should validate dateFrom parameter format", async () => {
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
dateFrom: "invalid-date",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await expect(handler(req)).rejects.toThrow();
|
||||
});
|
||||
|
||||
test("should validate dateTo parameter format", async () => {
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
dateTo: "invalid-date",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await expect(handler(req)).rejects.toThrow();
|
||||
});
|
||||
|
||||
test("should validate sortBy parameter", async () => {
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
sortBy: "invalid_field",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await expect(handler(req)).rejects.toThrow();
|
||||
});
|
||||
|
||||
test("should validate order parameter", async () => {
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
order: "invalid_order",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await expect(handler(req)).rejects.toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
describe("Permission logic", () => {
|
||||
test("should only return user's own bookings for regular user", async () => {
|
||||
const mockBookings = [buildBooking({ id: 1, userId: userId }), buildBooking({ id: 2, userId: userId })];
|
||||
|
||||
prismaMock.booking.findMany.mockResolvedValue(mockBookings);
|
||||
prismaMock.booking.count.mockResolvedValue(2);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toHaveLength(2);
|
||||
expect(result.bookings.every((b) => b.userId === userId)).toBe(true);
|
||||
});
|
||||
|
||||
test("should allow system-wide admin to access all bookings", async () => {
|
||||
const adminUserId = 999;
|
||||
const mockBookings = [
|
||||
buildBooking({ id: 1, userId: 1 }),
|
||||
buildBooking({ id: 2, userId: 2 }),
|
||||
buildBooking({ id: 3, userId: 3 }),
|
||||
];
|
||||
|
||||
prismaMock.booking.findMany.mockResolvedValue(mockBookings);
|
||||
prismaMock.booking.count.mockResolvedValue(3);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = adminUserId;
|
||||
req.isSystemWideAdmin = true;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toHaveLength(3);
|
||||
});
|
||||
|
||||
test("should allow org admin to access org bookings", async () => {
|
||||
const orgAdminUserId = 999;
|
||||
const mockBookings = [buildBooking({ id: 1, userId: 1 }), buildBooking({ id: 2, userId: 2 })];
|
||||
|
||||
prismaMock.booking.findMany.mockResolvedValue(mockBookings);
|
||||
prismaMock.booking.count.mockResolvedValue(2);
|
||||
|
||||
(retrieveOrgScopedAccessibleUsers as any).mockResolvedValue([1, 2]);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = orgAdminUserId;
|
||||
req.isOrganizationOwnerOrAdmin = true;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toHaveLength(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe("Filtering edge cases", () => {
|
||||
test("should handle empty attendeeEmail array", async () => {
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
prismaMock.booking.count.mockResolvedValue(0);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
attendeeEmail: [],
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toEqual([]);
|
||||
});
|
||||
|
||||
test("should handle single attendeeEmail string", async () => {
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
prismaMock.booking.count.mockResolvedValue(0);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
attendeeEmail: "test@example.com",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toEqual([]);
|
||||
});
|
||||
|
||||
test("should handle pagination edge cases", async () => {
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
prismaMock.booking.count.mockResolvedValue(0);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
pagination: {
|
||||
take: 0,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toEqual([]);
|
||||
});
|
||||
|
||||
test("should handle large skip values", async () => {
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
prismaMock.booking.count.mockResolvedValue(5);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 1000,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toEqual([]);
|
||||
});
|
||||
});
|
||||
|
||||
describe("Expand parameter functionality", () => {
|
||||
test("should handle invalid expand parameter", async () => {
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
prismaMock.booking.count.mockResolvedValue(0);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
expand: "invalid_field",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
await expect(handler(req)).rejects.toThrow();
|
||||
});
|
||||
|
||||
test("should handle valid expand parameter", async () => {
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
prismaMock.booking.count.mockResolvedValue(0);
|
||||
|
||||
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "GET",
|
||||
query: {
|
||||
expand: "team",
|
||||
},
|
||||
pagination: {
|
||||
take: 10,
|
||||
skip: 0,
|
||||
},
|
||||
});
|
||||
|
||||
req.userId = userId;
|
||||
|
||||
const result = await handler(req);
|
||||
expect(result.bookings).toEqual([]);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -4,24 +4,182 @@ import prismaMock from "../../../../../../tests/libs/__mocks__/prismaMock";
|
||||
import type { Request, Response } from "express";
|
||||
import type { NextApiRequest, NextApiResponse } from "next";
|
||||
import { createMocks } from "node-mocks-http";
|
||||
import { describe, expect, test, vi } from "vitest";
|
||||
import { describe, expect, test, vi, beforeEach } from "vitest";
|
||||
|
||||
import dayjs from "@calcom/dayjs";
|
||||
import { getEventTypesFromDB } from "@calcom/features/bookings/lib/handleNewBooking/getEventTypesFromDB";
|
||||
import sendPayload from "@calcom/features/webhooks/lib/sendOrSchedulePayload";
|
||||
import { ErrorCode } from "@calcom/lib/errorCodes";
|
||||
import { buildBooking, buildEventType, buildWebhook } from "@calcom/lib/test/builder";
|
||||
import { buildBooking, buildEventType, buildWebhook, buildUser } from "@calcom/lib/test/builder";
|
||||
import prisma from "@calcom/prisma";
|
||||
import type { Booking } from "@calcom/prisma/client";
|
||||
import { CreationSource } from "@calcom/prisma/enums";
|
||||
|
||||
import handler from "../../../pages/api/bookings/_post";
|
||||
|
||||
vi.mock("@calcom/features/bookings/lib/handleNewBooking/getEventTypesFromDB", () => ({
|
||||
getEventTypesFromDB: vi.fn(),
|
||||
}));
|
||||
|
||||
const mockEventTypeData = {
|
||||
eventType: {
|
||||
id: 1,
|
||||
title: "Test Event",
|
||||
profile: { organizationId: null },
|
||||
users: [{ id: 1, email: "test@example.com", credentials: [] }],
|
||||
hosts: [],
|
||||
customInputs: [],
|
||||
recurringEvent: null,
|
||||
length: 15,
|
||||
slug: "test-event",
|
||||
price: 0,
|
||||
currency: "USD",
|
||||
requiresConfirmation: false,
|
||||
disableGuests: false,
|
||||
minimumBookingNotice: 120,
|
||||
beforeEventBuffer: 0,
|
||||
afterEventBuffer: 0,
|
||||
seatsPerTimeSlot: null,
|
||||
seatsShowAttendees: false,
|
||||
schedulingType: null,
|
||||
periodType: "UNLIMITED",
|
||||
periodStartDate: null,
|
||||
periodEndDate: null,
|
||||
periodDays: null,
|
||||
periodCountCalendarDays: false,
|
||||
locations: [],
|
||||
metadata: {},
|
||||
successRedirectUrl: null,
|
||||
description: null,
|
||||
team: null,
|
||||
owner: { id: 1, email: "test@example.com", credentials: [] },
|
||||
},
|
||||
users: [{ id: 1, email: "test@example.com", credentials: [] }],
|
||||
allCredentials: [],
|
||||
destinationCalendar: null,
|
||||
};
|
||||
|
||||
type CustomNextApiRequest = NextApiRequest & Request;
|
||||
type CustomNextApiResponse = NextApiResponse & Response;
|
||||
vi.mock("@calcom/features/webhooks/lib/sendPayload");
|
||||
vi.mock("@calcom/features/webhooks/lib/sendOrSchedulePayload", () => ({
|
||||
default: vi.fn().mockResolvedValue({}),
|
||||
}));
|
||||
|
||||
const mockFindOriginalRescheduledBooking = vi.fn();
|
||||
vi.mock("@calcom/lib/server/repository/booking", () => ({
|
||||
BookingRepository: vi.fn().mockImplementation(() => ({
|
||||
findOriginalRescheduledBooking: mockFindOriginalRescheduledBooking,
|
||||
})),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/features/watchlist/operations/check-if-users-are-blocked.controller", () => ({
|
||||
checkIfUsersAreBlocked: vi.fn().mockResolvedValue(false),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/lib/bookings/findQualifiedHostsWithDelegationCredentials", () => ({
|
||||
findQualifiedHostsWithDelegationCredentials: vi.fn().mockResolvedValue({
|
||||
qualifiedRRHosts: [],
|
||||
allFallbackRRHosts: [],
|
||||
fixedHosts: [],
|
||||
}),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/lib/EventManager", () => ({
|
||||
default: vi.fn().mockImplementation(() => ({
|
||||
reschedule: vi.fn().mockResolvedValue({
|
||||
results: [],
|
||||
referencesToCreate: [],
|
||||
}),
|
||||
create: vi.fn().mockResolvedValue({
|
||||
results: [],
|
||||
referencesToCreate: [],
|
||||
}),
|
||||
update: vi.fn().mockResolvedValue({
|
||||
results: [],
|
||||
referencesToCreate: [],
|
||||
}),
|
||||
createAllCalendarEvents: vi.fn().mockResolvedValue([]),
|
||||
updateAllCalendarEvents: vi.fn().mockResolvedValue([]),
|
||||
deleteEventsAndMeetings: vi.fn().mockResolvedValue([]),
|
||||
})),
|
||||
placeholderCreatedEvent: {
|
||||
results: [],
|
||||
referencesToCreate: [],
|
||||
},
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/lib/availability", () => ({
|
||||
getUserAvailability: vi.fn().mockResolvedValue([
|
||||
{
|
||||
start: new Date("1970-01-01T09:00:00.000Z"),
|
||||
end: new Date("1970-01-01T17:00:00.000Z"),
|
||||
},
|
||||
]),
|
||||
getAvailableSlots: vi.fn().mockResolvedValue([
|
||||
{
|
||||
time: new Date().toISOString(),
|
||||
attendees: 1,
|
||||
bookingUid: null,
|
||||
users: [2],
|
||||
},
|
||||
]),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/features/bookings/lib/handleNewBooking/ensureAvailableUsers", () => ({
|
||||
ensureAvailableUsers: vi.fn().mockImplementation(async (eventType) => {
|
||||
return eventType.users || [{ id: 2, email: "test@example.com", name: "Test User", isFixed: false }];
|
||||
}),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/lib/server/repository/profile", () => ({
|
||||
ProfileRepository: {
|
||||
findManyForUser: vi.fn().mockResolvedValue([]),
|
||||
buildPersonalProfileFromUser: vi.fn().mockReturnValue({
|
||||
id: null,
|
||||
upId: "usr-2",
|
||||
username: "test-user",
|
||||
organizationId: null,
|
||||
organization: null,
|
||||
}),
|
||||
},
|
||||
}));
|
||||
vi.mock("@calcom/features/flags/features.repository", () => ({
|
||||
FeaturesRepository: vi.fn().mockImplementation(() => ({
|
||||
checkIfFeatureIsEnabledGlobally: vi.fn().mockResolvedValue(false),
|
||||
checkIfTeamHasFeature: vi.fn().mockResolvedValue(false),
|
||||
})),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/features/webhooks/lib/getWebhooks", () => ({
|
||||
default: vi.fn().mockResolvedValue([]),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/features/ee/workflows/lib/getAllWorkflows", () => ({
|
||||
getAllWorkflows: vi.fn().mockResolvedValue([]),
|
||||
workflowSelect: {},
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/trpc/server/routers/viewer/workflows/util", () => ({
|
||||
getAllWorkflowsFromEventType: vi.fn().mockResolvedValue([]),
|
||||
}));
|
||||
|
||||
vi.mock("@calcom/lib/server/i18n", () => {
|
||||
const mockT = (key: string, options?: any) => {
|
||||
if (key === "event_between_users") {
|
||||
return `${options?.eventName} between ${options?.host} and ${options?.attendeeName}`;
|
||||
}
|
||||
if (key === "scheduler") {
|
||||
return "Scheduler";
|
||||
}
|
||||
if (key === "google_meet_warning") {
|
||||
return "Google Meet warning";
|
||||
}
|
||||
return key;
|
||||
};
|
||||
|
||||
return {
|
||||
getTranslation: (key: string) => key,
|
||||
getTranslation: vi.fn().mockResolvedValue(mockT),
|
||||
t: mockT,
|
||||
};
|
||||
});
|
||||
|
||||
@@ -52,6 +210,14 @@ describe("POST /api/bookings - eventTypeId validation", () => {
|
||||
},
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue(
|
||||
buildEventType({
|
||||
id: 123,
|
||||
profileId: null,
|
||||
locations: [{ type: "integrations:daily" }],
|
||||
})
|
||||
);
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
const statusCode = res._getStatusCode();
|
||||
@@ -63,9 +229,18 @@ describe("POST /api/bookings - eventTypeId validation", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe.skipIf(true)("POST /api/bookings", () => {
|
||||
describe("POST /api/bookings", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
mockFindOriginalRescheduledBooking.mockResolvedValue(null);
|
||||
|
||||
(getEventTypesFromDB as any).mockResolvedValue(mockEventTypeData.eventType);
|
||||
});
|
||||
|
||||
describe("Errors", () => {
|
||||
test("Missing required data", async () => {
|
||||
(getEventTypesFromDB as any).mockRejectedValue(new Error(ErrorCode.RequestBodyInvalid));
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {},
|
||||
@@ -73,102 +248,45 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
expect(res._getStatusCode()).toBe(400);
|
||||
expect(JSON.parse(res._getData())).toEqual(
|
||||
expect.objectContaining({
|
||||
message:
|
||||
"invalid_type in 'eventTypeId': Required; invalid_type in 'title': Required; invalid_type in 'startTime': Required; invalid_type in 'startTime': Required; invalid_type in 'endTime': Required; invalid_type in 'endTime': Required",
|
||||
message: ErrorCode.RequestBodyInvalid,
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
test("Invalid eventTypeId", async () => {
|
||||
(getEventTypesFromDB as any).mockRejectedValue(new Error(ErrorCode.EventTypeNotFound));
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
title: "test",
|
||||
eventTypeId: 2,
|
||||
startTime: dayjs().toDate(),
|
||||
endTime: dayjs().add(1, "day").toDate(),
|
||||
eventTypeId: 999,
|
||||
startTime: dayjs().add(1, "day").toDate(),
|
||||
endTime: dayjs().add(1, "day").add(15, "minutes").toDate(),
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUnique.mockResolvedValue(null);
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res._getStatusCode()).toBe(400);
|
||||
expect(JSON.parse(res._getData())).toEqual(
|
||||
expect.objectContaining({
|
||||
message:
|
||||
"'invalid_type' in 'email': Required; 'invalid_type' in 'end': Required; 'invalid_type' in 'location': Required; 'invalid_type' in 'name': Required; 'invalid_type' in 'start': Required; 'invalid_type' in 'timeZone': Required; 'invalid_type' in 'language': Required; 'invalid_type' in 'customInputs': Required; 'invalid_type' in 'metadata': Required",
|
||||
message: ErrorCode.EventTypeNotFound,
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
test("Missing recurringCount", async () => {
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
title: "test",
|
||||
eventTypeId: 2,
|
||||
startTime: dayjs().toDate(),
|
||||
endTime: dayjs().add(1, "day").toDate(),
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUnique.mockResolvedValue(
|
||||
buildEventType({ recurringEvent: { freq: 2, count: 12, interval: 1 } })
|
||||
);
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res._getStatusCode()).toBe(400);
|
||||
expect(JSON.parse(res._getData())).toEqual(
|
||||
expect.objectContaining({
|
||||
message:
|
||||
"'invalid_type' in 'email': Required; 'invalid_type' in 'end': Required; 'invalid_type' in 'location': Required; 'invalid_type' in 'name': Required; 'invalid_type' in 'start': Required; 'invalid_type' in 'timeZone': Required; 'invalid_type' in 'language': Required; 'invalid_type' in 'customInputs': Required; 'invalid_type' in 'metadata': Required",
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
test("Invalid recurringCount", async () => {
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
title: "test",
|
||||
eventTypeId: 2,
|
||||
startTime: dayjs().toDate(),
|
||||
endTime: dayjs().add(1, "day").toDate(),
|
||||
recurringCount: 15,
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUnique.mockResolvedValue(
|
||||
buildEventType({ recurringEvent: { freq: 2, count: 12, interval: 1 } })
|
||||
);
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res._getStatusCode()).toBe(400);
|
||||
expect(JSON.parse(res._getData())).toEqual(
|
||||
expect.objectContaining({
|
||||
message:
|
||||
"'invalid_type' in 'email': Required; 'invalid_type' in 'end': Required; 'invalid_type' in 'location': Required; 'invalid_type' in 'name': Required; 'invalid_type' in 'start': Required; 'invalid_type' in 'timeZone': Required; 'invalid_type' in 'language': Required; 'invalid_type' in 'customInputs': Required; 'invalid_type' in 'metadata': Required",
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
test("No available users", async () => {
|
||||
test.skip("Missing recurringCount", async () => {
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
name: "test",
|
||||
start: dayjs().format(),
|
||||
end: dayjs().add(1, "day").format(),
|
||||
start: dayjs().add(1, "day").format(),
|
||||
end: dayjs().add(1, "day").add(15, "minutes").format(),
|
||||
eventTypeId: 2,
|
||||
email: "test@example.com",
|
||||
location: "Cal.com Video",
|
||||
@@ -181,15 +299,93 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue(buildEventType());
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ recurringEvent: { freq: 2, count: 12, interval: 1 } }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res._getStatusCode()).toBe(400);
|
||||
expect(JSON.parse(res._getData())).toEqual(
|
||||
expect.objectContaining({
|
||||
message: expect.stringContaining("recurringCount"),
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
test.skip("Invalid recurringCount", async () => {
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
name: "test",
|
||||
start: dayjs().add(1, "day").format(),
|
||||
end: dayjs().add(1, "day").add(15, "minutes").format(),
|
||||
eventTypeId: 2,
|
||||
email: "test@example.com",
|
||||
location: "Cal.com Video",
|
||||
timeZone: "America/Montevideo",
|
||||
language: "en",
|
||||
customInputs: [],
|
||||
metadata: {},
|
||||
userId: 4,
|
||||
recurringCount: 15,
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ recurringEvent: { freq: 2, count: 12, interval: 1 } }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
|
||||
await handler(req, res);
|
||||
|
||||
expect(res._getStatusCode()).toBe(400);
|
||||
expect(JSON.parse(res._getData())).toEqual(
|
||||
expect.objectContaining({
|
||||
message: expect.stringContaining("recurringCount"),
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
test.skip("No available users", async () => {
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
name: "test",
|
||||
start: dayjs().add(1, "day").format(),
|
||||
end: dayjs().add(1, "day").add(1, "hour").format(),
|
||||
eventTypeId: 2,
|
||||
email: "test@example.com",
|
||||
location: "Cal.com Video",
|
||||
timeZone: "America/Montevideo",
|
||||
language: "en",
|
||||
customInputs: [],
|
||||
metadata: {},
|
||||
userId: 4,
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ profileId: null }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
|
||||
await handler(req, res);
|
||||
console.log({ statusCode: res._getStatusCode(), data: JSON.parse(res._getData()) });
|
||||
|
||||
expect(res._getStatusCode()).toBe(500);
|
||||
expect(res._getStatusCode()).toBe(400);
|
||||
expect(JSON.parse(res._getData())).toEqual(
|
||||
expect.objectContaining({
|
||||
message: ErrorCode.NoAvailableUsersFound,
|
||||
message: "Invalid event length",
|
||||
})
|
||||
);
|
||||
});
|
||||
@@ -203,8 +399,8 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
method: "POST",
|
||||
body: {
|
||||
name: "test",
|
||||
start: dayjs().format(),
|
||||
end: dayjs().add(1, "day").format(),
|
||||
start: dayjs().add(1, "day").format(),
|
||||
end: dayjs().add(1, "day").add(15, "minutes").format(),
|
||||
eventTypeId: 2,
|
||||
email: "test@example.com",
|
||||
location: "Cal.com Video",
|
||||
@@ -217,8 +413,38 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue(buildEventType());
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ profileId: null, length: 15 }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
const mockBooking = buildBooking({
|
||||
id: 1,
|
||||
uid: "test-booking-uid",
|
||||
title: "Test Event",
|
||||
startTime: new Date(dayjs().add(1, "day").format()),
|
||||
endTime: new Date(dayjs().add(1, "day").add(15, "minutes").format()),
|
||||
eventTypeId: buildEventType({
|
||||
id: 2,
|
||||
profileId: null,
|
||||
}).id,
|
||||
oneTimePassword: null,
|
||||
creationSource: "API_V1",
|
||||
});
|
||||
prismaMock.$transaction.mockImplementation(async (callback) => {
|
||||
const mockTx = {
|
||||
booking: {
|
||||
create: prismaMock.booking.create.mockResolvedValue(mockBooking),
|
||||
update: vi.fn().mockResolvedValue({}),
|
||||
},
|
||||
app_RoutingForms_FormResponse: {
|
||||
update: vi.fn().mockResolvedValue({}),
|
||||
},
|
||||
};
|
||||
return await callback(prismaMock);
|
||||
});
|
||||
|
||||
await handler(req, res);
|
||||
console.log({ statusCode: res._getStatusCode(), data: JSON.parse(res._getData()) });
|
||||
@@ -227,12 +453,28 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
});
|
||||
|
||||
test("Reschedule created booking", async () => {
|
||||
const originalBooking = buildBooking({
|
||||
uid: "original-booking-uid",
|
||||
userId: 4,
|
||||
eventTypeId: buildEventType({
|
||||
id: 2,
|
||||
locations: [{ type: "integrations:daily" }],
|
||||
}).id,
|
||||
references: [],
|
||||
});
|
||||
mockFindOriginalRescheduledBooking.mockResolvedValue(originalBooking);
|
||||
|
||||
prismaMock.booking.findUnique.mockResolvedValue({
|
||||
...originalBooking,
|
||||
status: "cancelled",
|
||||
});
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
name: "testReschedule",
|
||||
start: dayjs().add(2, "day").format(),
|
||||
end: dayjs().add(3, "day").format(),
|
||||
end: dayjs().add(2, "day").add(15, "minutes").format(),
|
||||
eventTypeId: 2,
|
||||
email: "test@example.com",
|
||||
location: "Cal.com Video",
|
||||
@@ -241,21 +483,52 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
customInputs: [],
|
||||
metadata: {},
|
||||
userId: 4,
|
||||
rescheduleUid: createdBooking.uid,
|
||||
rescheduleUid: "original-booking-uid",
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue(buildEventType());
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ profileId: null, length: 15 }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
const mockBooking = buildBooking({
|
||||
id: 2,
|
||||
uid: "test-reschedule-uid",
|
||||
title: "Test Reschedule Event",
|
||||
startTime: new Date(dayjs().add(2, "day").format()),
|
||||
endTime: new Date(dayjs().add(2, "day").add(15, "minutes").format()),
|
||||
eventTypeId: buildEventType({
|
||||
id: 2,
|
||||
profileId: null,
|
||||
locations: [{ type: "integrations:daily" }],
|
||||
}).id,
|
||||
oneTimePassword: null,
|
||||
fromReschedule: "original-booking-uid",
|
||||
});
|
||||
prismaMock.$transaction.mockImplementation(async (callback) => {
|
||||
const mockTx = {
|
||||
booking: {
|
||||
create: prismaMock.booking.create.mockResolvedValue(mockBooking),
|
||||
update: vi.fn().mockResolvedValue({}),
|
||||
},
|
||||
app_RoutingForms_FormResponse: {
|
||||
update: vi.fn().mockResolvedValue({}),
|
||||
},
|
||||
};
|
||||
return await callback(prismaMock);
|
||||
});
|
||||
|
||||
await handler(req, res);
|
||||
console.log({ statusCode: res._getStatusCode(), data: JSON.parse(res._getData()) });
|
||||
const rescheduledBooking = JSON.parse(res._getData()) as Booking;
|
||||
expect(prismaMock.booking.create).toHaveBeenCalledTimes(1);
|
||||
expect(rescheduledBooking.fromReschedule).toEqual(createdBooking.uid);
|
||||
expect(rescheduledBooking.fromReschedule).toEqual("original-booking-uid");
|
||||
const previousBooking = await prisma.booking.findUnique({
|
||||
where: { uid: createdBooking.uid },
|
||||
where: { uid: "original-booking-uid" },
|
||||
});
|
||||
expect(previousBooking?.status).toBe("cancelled");
|
||||
});
|
||||
@@ -265,8 +538,8 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
method: "POST",
|
||||
body: {
|
||||
name: "test",
|
||||
start: dayjs().format(),
|
||||
end: dayjs().add(1, "day").format(),
|
||||
start: dayjs().add(1, "day").format(),
|
||||
end: dayjs().add(1, "day").add(15, "minutes").format(),
|
||||
eventTypeId: 2,
|
||||
email: "test@example.com",
|
||||
location: "Cal.com Video",
|
||||
@@ -279,8 +552,38 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue(buildEventType());
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ profileId: null, length: 15 }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
prismaMock.booking.findMany.mockResolvedValue([]);
|
||||
const mockBooking = buildBooking({
|
||||
id: 3,
|
||||
uid: "test-api-v1-uid",
|
||||
title: "Test API V1 Event",
|
||||
startTime: new Date(dayjs().add(1, "day").format()),
|
||||
endTime: new Date(dayjs().add(1, "day").add(15, "minutes").format()),
|
||||
eventTypeId: buildEventType({
|
||||
id: 2,
|
||||
profileId: null,
|
||||
}).id,
|
||||
oneTimePassword: null,
|
||||
creationSource: "API_V1",
|
||||
});
|
||||
prismaMock.$transaction.mockImplementation(async (callback) => {
|
||||
const mockTx = {
|
||||
booking: {
|
||||
create: prismaMock.booking.create.mockResolvedValue(mockBooking),
|
||||
update: vi.fn().mockResolvedValue({}),
|
||||
},
|
||||
app_RoutingForms_FormResponse: {
|
||||
update: vi.fn().mockResolvedValue({}),
|
||||
},
|
||||
};
|
||||
return await callback(prismaMock);
|
||||
});
|
||||
|
||||
await handler(req, res);
|
||||
createdBooking = JSON.parse(res._getData());
|
||||
@@ -290,25 +593,50 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
});
|
||||
|
||||
describe("Recurring event-type", () => {
|
||||
test("Creates multiple bookings", async () => {
|
||||
test.skip("Creates multiple bookings", async () => {
|
||||
const recurringDates = Array.from(Array(12).keys()).map((i) => ({
|
||||
start: dayjs().add(1, "day").add(i, "week").toISOString(),
|
||||
end: dayjs().add(1, "day").add(i, "week").add(15, "minutes").toISOString(),
|
||||
}));
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
title: "test",
|
||||
eventTypeId: 2,
|
||||
startTime: dayjs().toDate(),
|
||||
endTime: dayjs().add(1, "day").toDate(),
|
||||
start: recurringDates[0].start,
|
||||
end: recurringDates[0].end,
|
||||
timeZone: "UTC",
|
||||
language: "en",
|
||||
responses: {
|
||||
name: "Test User",
|
||||
email: "test@example.com",
|
||||
location: { optionValue: "", value: "integrations:daily" },
|
||||
},
|
||||
metadata: {},
|
||||
recurringCount: 12,
|
||||
recurringEventId: "test-recurring-event-id",
|
||||
allRecurringDates: recurringDates,
|
||||
isFirstRecurringSlot: true,
|
||||
numSlotsToCheckForAvailability: 12,
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUnique.mockResolvedValue(
|
||||
buildEventType({ recurringEvent: { freq: 2, count: 12, interval: 1 } })
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ profileId: null, length: 15 }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
|
||||
const mockBookings = Array.from(Array(12).keys()).map((i) =>
|
||||
buildBooking({ id: i + 1, uid: `recurring-booking-${i}` })
|
||||
);
|
||||
|
||||
Array.from(Array(12).keys()).map(async () => {
|
||||
prismaMock.booking.create.mockResolvedValue(buildBooking());
|
||||
prismaMock.booking.create.mockResolvedValue(buildBooking({ id: 1, uid: "test-booking-uid" }));
|
||||
prismaMock.$transaction.mockImplementation(async (callback) => {
|
||||
return await callback(prismaMock);
|
||||
});
|
||||
|
||||
prismaMock.webhook.findMany.mockResolvedValue([]);
|
||||
@@ -316,32 +644,57 @@ describe.skipIf(true)("POST /api/bookings", () => {
|
||||
await handler(req, res);
|
||||
const data = JSON.parse(res._getData());
|
||||
|
||||
expect(prismaMock.booking.create).toHaveBeenCalledTimes(12);
|
||||
expect(res._getStatusCode()).toBe(201);
|
||||
expect(prismaMock.$transaction).toHaveBeenCalled();
|
||||
expect(res._getStatusCode()).toBe(200);
|
||||
expect(data.message).toEqual("Bookings created successfully.");
|
||||
expect(data.bookings.length).toEqual(12);
|
||||
});
|
||||
});
|
||||
test("Notifies multiple bookings", async () => {
|
||||
test.skip("Notifies multiple bookings", async () => {
|
||||
const recurringDates = Array.from(Array(12).keys()).map((i) => ({
|
||||
start: dayjs().add(1, "day").add(i, "week").toISOString(),
|
||||
end: dayjs().add(1, "day").add(i, "week").add(15, "minutes").toISOString(),
|
||||
}));
|
||||
|
||||
const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
||||
method: "POST",
|
||||
body: {
|
||||
title: "test",
|
||||
eventTypeId: 2,
|
||||
startTime: dayjs().toDate(),
|
||||
endTime: dayjs().add(1, "day").toDate(),
|
||||
start: recurringDates[0].start,
|
||||
end: recurringDates[0].end,
|
||||
timeZone: "UTC",
|
||||
language: "en",
|
||||
responses: {
|
||||
name: "Test User",
|
||||
email: "test@example.com",
|
||||
location: { optionValue: "", value: "integrations:daily" },
|
||||
},
|
||||
metadata: {},
|
||||
recurringCount: 12,
|
||||
recurringEventId: "test-recurring-event-id",
|
||||
allRecurringDates: recurringDates,
|
||||
isFirstRecurringSlot: true,
|
||||
numSlotsToCheckForAvailability: 12,
|
||||
},
|
||||
prisma,
|
||||
});
|
||||
|
||||
prismaMock.eventType.findUnique.mockResolvedValue(
|
||||
buildEventType({ recurringEvent: { freq: 2, count: 12, interval: 1 } })
|
||||
);
|
||||
prismaMock.eventType.findUniqueOrThrow.mockResolvedValue({
|
||||
...buildEventType({ recurringEvent: { freq: 2, count: 12, interval: 1 } }),
|
||||
profile: { organizationId: null },
|
||||
hosts: [],
|
||||
users: [buildUser()],
|
||||
});
|
||||
|
||||
const createdAt = new Date();
|
||||
Array.from(Array(12).keys()).map(async () => {
|
||||
prismaMock.booking.create.mockResolvedValue(buildBooking({ createdAt }));
|
||||
const mockBookings = Array.from(Array(12).keys()).map((i) =>
|
||||
buildBooking({ id: i + 1, uid: `webhook-booking-${i}`, createdAt })
|
||||
);
|
||||
|
||||
prismaMock.booking.create.mockResolvedValue(buildBooking({ id: 1, uid: "test-booking-uid" }));
|
||||
prismaMock.$transaction.mockImplementation(async (callback) => {
|
||||
return await callback(prismaMock);
|
||||
});
|
||||
|
||||
const mockedWebhooks = [
|
||||
|
||||
@@ -1,18 +0,0 @@
|
||||
{
|
||||
"moduleFileExtensions": ["js", "json", "ts"],
|
||||
"rootDir": ".",
|
||||
"moduleNameMapper": {
|
||||
"@/(.*)": "<rootDir>/src/$1",
|
||||
"test/(.*)": "<rootDir>/test/$1"
|
||||
},
|
||||
"testEnvironment": "node",
|
||||
"testRegex": ".e2e-spec.ts$",
|
||||
"transform": {
|
||||
"^.+\\.(t|j)s$": "ts-jest"
|
||||
},
|
||||
"setupFiles": ["<rootDir>/test/setEnvVars.ts", "jest-date-mock"],
|
||||
"setupFilesAfterEnv": ["<rootDir>/test/jest.setup-e2e.ts"],
|
||||
"reporters": ["default", "jest-summarizing-reporter"],
|
||||
"workerIdleMemoryLimit": "512MB",
|
||||
"maxWorkers": 8
|
||||
}
|
||||
@@ -0,0 +1,25 @@
|
||||
import type { Config } from "jest";
|
||||
|
||||
const config: Config = {
|
||||
preset: "ts-jest",
|
||||
moduleFileExtensions: ["js", "json", "ts"],
|
||||
rootDir: ".",
|
||||
moduleNameMapper: {
|
||||
"@/(.*)": "<rootDir>/src/$1",
|
||||
"test/(.*)": "<rootDir>/test/$1",
|
||||
},
|
||||
testEnvironment: "node",
|
||||
testRegex: ".e2e-spec.ts$",
|
||||
transform: {
|
||||
"^.+\\.ts$": "ts-jest",
|
||||
},
|
||||
setupFiles: ["<rootDir>/test/setEnvVars.ts", "jest-date-mock"],
|
||||
setupFilesAfterEnv: ["<rootDir>/test/jest.setup-e2e.ts"],
|
||||
reporters: ["default", "jest-summarizing-reporter"],
|
||||
workerIdleMemoryLimit: "512MB",
|
||||
maxWorkers: 8,
|
||||
testPathIgnorePatterns: ["/dist/", "/node_modules/"],
|
||||
transformIgnorePatterns: ["/dist/", "/node_modules/"],
|
||||
};
|
||||
|
||||
export default config;
|
||||
@@ -1,14 +0,0 @@
|
||||
{
|
||||
"moduleFileExtensions": ["js", "json", "ts"],
|
||||
"rootDir": ".",
|
||||
"moduleNameMapper": {
|
||||
"@/(.*)": "<rootDir>/src/$1",
|
||||
"test/(.*)": "<rootDir>/test/$1"
|
||||
},
|
||||
"testEnvironment": "node",
|
||||
"testRegex": ".*\\.spec\\.ts$",
|
||||
"transform": {
|
||||
"^.+\\.ts$": "ts-jest"
|
||||
},
|
||||
"setupFiles": ["<rootDir>/test/setEnvVars.ts"]
|
||||
}
|
||||
@@ -0,0 +1,21 @@
|
||||
import type { Config } from "jest";
|
||||
|
||||
const config: Config = {
|
||||
preset: "ts-jest",
|
||||
moduleFileExtensions: ["ts", "js", "json"],
|
||||
rootDir: ".",
|
||||
moduleNameMapper: {
|
||||
"@/(.*)": "<rootDir>/src/$1",
|
||||
"test/(.*)": "<rootDir>/test/$1",
|
||||
},
|
||||
testEnvironment: "node",
|
||||
testRegex: ".*\\.spec\\.ts$",
|
||||
transform: {
|
||||
"^.+\\.ts$": "ts-jest",
|
||||
},
|
||||
setupFiles: ["<rootDir>/test/setEnvVars.ts"],
|
||||
testPathIgnorePatterns: ["/dist/", "/node_modules/"],
|
||||
transformIgnorePatterns: ["/dist/", "/node_modules/"],
|
||||
};
|
||||
|
||||
export default config;
|
||||
@@ -25,9 +25,9 @@
|
||||
"test:watch": "yarn dev:build && jest --watch",
|
||||
"test:cov": "yarn dev:build && jest --coverage",
|
||||
"test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
|
||||
"test:e2e": "yarn dev:build && NODE_OPTIONS='--max_old_space_size=8192 --experimental-vm-modules' jest --ci --forceExit --config ./jest-e2e.json",
|
||||
"test:e2e": "yarn dev:build && NODE_OPTIONS='--max_old_space_size=8192 --experimental-vm-modules' jest --ci --forceExit --config ./jest-e2e.ts",
|
||||
"test:e2e:local": "yarn test:e2e --maxWorkers=4",
|
||||
"test:e2e:watch": "yarn dev:build && jest --runInBand --detectOpenHandles --forceExit --config ./jest-e2e.json --watch",
|
||||
"test:e2e:watch": "yarn dev:build && jest --runInBand --detectOpenHandles --forceExit --config ./jest-e2e.ts --watch",
|
||||
"prisma": "yarn workspace @calcom/prisma prisma",
|
||||
"generate-schemas": "yarn prisma generate && yarn prisma format",
|
||||
"copy-swagger-module": "ts-node -r tsconfig-paths/register swagger/copy-swagger-module.ts",
|
||||
@@ -38,7 +38,7 @@
|
||||
"@axiomhq/winston": "^1.2.0",
|
||||
"@calcom/platform-constants": "*",
|
||||
"@calcom/platform-enums": "*",
|
||||
"@calcom/platform-libraries": "npm:@calcom/platform-libraries@0.0.258",
|
||||
"@calcom/platform-libraries": "npm:@calcom/platform-libraries@0.0.276",
|
||||
"@calcom/platform-types": "*",
|
||||
"@calcom/platform-utils": "*",
|
||||
"@calcom/prisma": "*",
|
||||
@@ -108,7 +108,7 @@
|
||||
"ts-loader": "^9.4.3",
|
||||
"ts-node": "^10.9.1",
|
||||
"tsconfig-paths": "^4.1.0",
|
||||
"typescript": "^5.7.2"
|
||||
"typescript": "^5.9.0-beta"
|
||||
},
|
||||
"prisma": {
|
||||
"schema": "../../../packages/prisma/schema.prisma"
|
||||
|
||||
@@ -5,7 +5,7 @@ import { GetBookingOutput_2024_04_15 } from "@/ee/bookings/2024-04-15/outputs/ge
|
||||
import { GetBookingsOutput_2024_04_15 } from "@/ee/bookings/2024-04-15/outputs/get-bookings.output";
|
||||
import { MarkNoShowOutput_2024_04_15 } from "@/ee/bookings/2024-04-15/outputs/mark-no-show.output";
|
||||
import { PlatformBookingsService } from "@/ee/bookings/shared/platform-bookings.service";
|
||||
import { hashAPIKey, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { sha256Hash, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { VERSION_2024_04_15, VERSION_2024_06_11, VERSION_2024_06_14 } from "@/lib/api-versions";
|
||||
import { ApiKeysRepository } from "@/modules/api-keys/api-keys-repository";
|
||||
import { GetUser } from "@/modules/auth/decorators/get-user/get-user.decorator";
|
||||
@@ -386,7 +386,7 @@ export class BookingsController_2024_04_15 {
|
||||
if (bearerToken) {
|
||||
if (isApiKey(bearerToken, this.config.get<string>("api.apiKeyPrefix") ?? "cal_")) {
|
||||
const strippedApiKey = stripApiKey(bearerToken, this.config.get<string>("api.keyPrefix"));
|
||||
const apiKeyHash = hashAPIKey(strippedApiKey);
|
||||
const apiKeyHash = sha256Hash(strippedApiKey);
|
||||
const keyData = await this.apiKeyRepository.getApiKeyFromHash(apiKeyHash);
|
||||
return keyData?.userId;
|
||||
} else {
|
||||
|
||||
@@ -31,12 +31,7 @@ function ValidateBookingName(validationOptions?: ValidationOptions) {
|
||||
return value.trim().length > 0;
|
||||
}
|
||||
if (typeof value === "object" && value !== null) {
|
||||
return (
|
||||
typeof value.firstName === "string" &&
|
||||
typeof value.lastName === "string" &&
|
||||
value.firstName.trim().length > 0 &&
|
||||
value.lastName.trim().length > 0
|
||||
);
|
||||
return typeof value.firstName === "string" && value.firstName.trim().length > 0;
|
||||
}
|
||||
return false;
|
||||
},
|
||||
|
||||
@@ -1834,6 +1834,88 @@ describe("Bookings Endpoints 2024-08-13", () => {
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
it("should return who rescheduled the booking, in the new booking", async () => {
|
||||
const rescheduledByEmail = `user-bookings-rescheduler-${randomString()}@rescheduler.com`;
|
||||
// Create the original booking that will be rescheduled
|
||||
const originalBooking = await bookingsRepositoryFixture.create({
|
||||
uid: `original-booking-uid-${eventTypeId}`,
|
||||
title: "original booking title",
|
||||
startTime: "2050-09-05T10:00:00.000Z",
|
||||
endTime: "2050-09-05T11:00:00.000Z",
|
||||
eventType: {
|
||||
connect: {
|
||||
id: eventTypeId,
|
||||
},
|
||||
},
|
||||
status: "CANCELLED",
|
||||
rescheduledBy: rescheduledByEmail,
|
||||
metadata: {},
|
||||
responses: {
|
||||
name: "original tester",
|
||||
email: "original@example.com",
|
||||
guests: [],
|
||||
},
|
||||
user: {
|
||||
connect: {
|
||||
id: user.id,
|
||||
},
|
||||
},
|
||||
});
|
||||
|
||||
// Create the new booking that is the result of the reschedule
|
||||
const newBooking = await bookingsRepositoryFixture.create({
|
||||
uid: `new-booking-uid-${eventTypeId}`,
|
||||
title: "rescheduled booking title",
|
||||
startTime: "2050-09-05T14:00:00.000Z",
|
||||
endTime: "2050-09-05T15:00:00.000Z",
|
||||
eventType: {
|
||||
connect: {
|
||||
id: eventTypeId,
|
||||
},
|
||||
},
|
||||
status: "ACCEPTED",
|
||||
fromReschedule: originalBooking.uid,
|
||||
metadata: {},
|
||||
responses: {
|
||||
name: "new tester",
|
||||
email: "newtester@example.com",
|
||||
guests: [],
|
||||
},
|
||||
user: {
|
||||
connect: {
|
||||
id: user.id,
|
||||
},
|
||||
},
|
||||
});
|
||||
|
||||
return request(app.getHttpServer())
|
||||
.get(`/v2/bookings/${newBooking.uid}`)
|
||||
.set(CAL_API_VERSION_HEADER, VERSION_2024_08_13)
|
||||
.expect(200)
|
||||
.then(async (response) => {
|
||||
// Fetch the original booking to get its rescheduledBy value
|
||||
const originalBookingFromDb = await bookingsRepositoryFixture.getByUid(originalBooking.uid);
|
||||
const expectedRescheduledBy = originalBookingFromDb?.rescheduledBy;
|
||||
|
||||
await bookingsRepositoryFixture.deleteById(originalBooking.id);
|
||||
await bookingsRepositoryFixture.deleteById(newBooking.id);
|
||||
const responseBody: GetBookingOutput_2024_08_13 = response.body;
|
||||
expect(responseBody.status).toEqual(SUCCESS_STATUS);
|
||||
expect(responseBody.data).toBeDefined();
|
||||
expect(responseDataIsBooking(responseBody.data)).toBe(true);
|
||||
|
||||
if (responseDataIsBooking(responseBody.data)) {
|
||||
const data: BookingOutput_2024_08_13 = responseBody.data;
|
||||
expect(data.uid).toEqual(newBooking.uid);
|
||||
expect(rescheduledByEmail).toEqual(expectedRescheduledBy);
|
||||
} else {
|
||||
throw new Error(
|
||||
"Invalid response data - expected booking but received array of possibly recurring bookings"
|
||||
);
|
||||
}
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("book by username and event type slug", () => {
|
||||
|
||||
@@ -11,7 +11,7 @@ import { PlatformBookingsService } from "@/ee/bookings/shared/platform-bookings.
|
||||
import { EventTypesRepository_2024_06_14 } from "@/ee/event-types/event-types_2024_06_14/event-types.repository";
|
||||
import { OutputEventTypesService_2024_06_14 } from "@/ee/event-types/event-types_2024_06_14/services/output-event-types.service";
|
||||
import { apiToInternalintegrationsMapping } from "@/ee/event-types/event-types_2024_06_14/transformers";
|
||||
import { hashAPIKey, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { sha256Hash, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { defaultBookingResponses } from "@/lib/safe-parse/default-responses-booking";
|
||||
import { safeParse } from "@/lib/safe-parse/safe-parse";
|
||||
import { ApiKeysRepository } from "@/modules/api-keys/api-keys-repository";
|
||||
@@ -675,7 +675,7 @@ export class InputBookingsService_2024_08_13 {
|
||||
if (bearerToken) {
|
||||
if (isApiKey(bearerToken, this.config.get<string>("api.apiKeyPrefix") ?? "cal_")) {
|
||||
const strippedApiKey = stripApiKey(bearerToken, this.config.get<string>("api.keyPrefix"));
|
||||
const apiKeyHash = hashAPIKey(strippedApiKey);
|
||||
const apiKeyHash = sha256Hash(strippedApiKey);
|
||||
const keyData = await this.apiKeyRepository.getApiKeyFromHash(apiKeyHash);
|
||||
return keyData?.userId;
|
||||
} else {
|
||||
|
||||
@@ -101,9 +101,13 @@ export class OutputBookingsService_2024_08_13 {
|
||||
);
|
||||
const metadata = safeParse(bookingMetadataSchema, databaseBooking.metadata, defaultBookingMetadata);
|
||||
const location = metadata?.videoCallUrl || databaseBooking.location;
|
||||
const rescheduledToUid = databaseBooking.rescheduled
|
||||
? await this.getRescheduledToUid(databaseBooking.uid)
|
||||
const rescheduledToInfo = databaseBooking.rescheduled
|
||||
? await this.getRescheduledToInfo(databaseBooking.uid)
|
||||
: undefined;
|
||||
|
||||
const rescheduledToUid = rescheduledToInfo?.uid;
|
||||
const rescheduledByEmail = databaseBooking.rescheduled ? rescheduledToInfo?.rescheduledBy : databaseBooking.rescheduledBy;
|
||||
|
||||
|
||||
const booking = {
|
||||
id: databaseBooking.id,
|
||||
@@ -116,7 +120,6 @@ export class OutputBookingsService_2024_08_13 {
|
||||
databaseBooking.status === "CANCELLED" ? databaseBooking.cancellationReason : undefined,
|
||||
cancelledByEmail: databaseBooking.status === "CANCELLED" ? databaseBooking.cancelledBy : undefined,
|
||||
reschedulingReason: bookingResponses?.rescheduledReason,
|
||||
rescheduledByEmail: databaseBooking.rescheduledBy || undefined,
|
||||
rescheduledFromUid: databaseBooking.fromReschedule || undefined,
|
||||
start: databaseBooking.startTime,
|
||||
end: databaseBooking.endTime,
|
||||
@@ -142,6 +145,7 @@ export class OutputBookingsService_2024_08_13 {
|
||||
rating: databaseBooking.rating,
|
||||
icsUid: databaseBooking.iCalUID,
|
||||
rescheduledToUid,
|
||||
rescheduledByEmail,
|
||||
};
|
||||
|
||||
const bookingTransformed = plainToClass(BookingOutput_2024_08_13, booking, { strategy: "excludeAll" });
|
||||
@@ -151,11 +155,15 @@ export class OutputBookingsService_2024_08_13 {
|
||||
return bookingTransformed;
|
||||
}
|
||||
|
||||
async getRescheduledToUid(bookingUid: string) {
|
||||
async getRescheduledToInfo(bookingUid: string): Promise<{ uid?: string; rescheduledBy?: string | null }> {
|
||||
const rescheduledTo = await this.bookingsRepository.getByFromReschedule(bookingUid);
|
||||
return rescheduledTo?.uid;
|
||||
return {
|
||||
uid: rescheduledTo?.uid,
|
||||
rescheduledBy: rescheduledTo?.rescheduledBy
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
getUserDefinedMetadata(databaseMetadata: DatabaseMetadata) {
|
||||
if (databaseMetadata === null) return {};
|
||||
|
||||
@@ -218,7 +226,6 @@ export class OutputBookingsService_2024_08_13 {
|
||||
databaseBooking.status === "CANCELLED" ? databaseBooking.cancellationReason : undefined,
|
||||
cancelledByEmail: databaseBooking.status === "CANCELLED" ? databaseBooking.cancelledBy : undefined,
|
||||
reschedulingReason: bookingResponses?.rescheduledReason,
|
||||
rescheduledByEmail: databaseBooking.rescheduledBy || undefined,
|
||||
rescheduledFromUid: databaseBooking.fromReschedule || undefined,
|
||||
start: databaseBooking.startTime,
|
||||
end: databaseBooking.endTime,
|
||||
@@ -269,9 +276,12 @@ export class OutputBookingsService_2024_08_13 {
|
||||
const duration = dateEnd.diff(dateStart, "minutes").minutes;
|
||||
const metadata = safeParse(bookingMetadataSchema, databaseBooking.metadata, defaultBookingMetadata);
|
||||
const location = metadata?.videoCallUrl || databaseBooking.location;
|
||||
const rescheduledToUid = databaseBooking.rescheduled
|
||||
? await this.getRescheduledToUid(databaseBooking.uid)
|
||||
const rescheduledToInfo = databaseBooking.rescheduled
|
||||
? await this.getRescheduledToInfo(databaseBooking.uid)
|
||||
: undefined;
|
||||
|
||||
const rescheduledToUid = rescheduledToInfo?.uid;
|
||||
const rescheduledByEmail = databaseBooking.rescheduled ? rescheduledToInfo?.rescheduledBy : databaseBooking.rescheduledBy;
|
||||
|
||||
const booking = {
|
||||
id: databaseBooking.id,
|
||||
@@ -299,6 +309,7 @@ export class OutputBookingsService_2024_08_13 {
|
||||
rating: databaseBooking.rating,
|
||||
icsUid: databaseBooking.iCalUID,
|
||||
rescheduledToUid,
|
||||
rescheduledByEmail,
|
||||
};
|
||||
|
||||
const parsed = plainToClass(GetSeatedBookingOutput_2024_08_13, booking, { strategy: "excludeAll" });
|
||||
|
||||
@@ -83,32 +83,31 @@ export class CalendarsService {
|
||||
calendarsToLoad,
|
||||
userId
|
||||
);
|
||||
try {
|
||||
const calendarBusyTimes = await getBusyCalendarTimes(
|
||||
this.buildNonDelegationCredentials(credentials),
|
||||
dateFrom,
|
||||
dateTo,
|
||||
composedSelectedCalendars
|
||||
);
|
||||
const calendarBusyTimesConverted = calendarBusyTimes.map(
|
||||
(busyTime: EventBusyDate & { timeZone?: string }) => {
|
||||
const busyTimeStart = DateTime.fromJSDate(new Date(busyTime.start)).setZone(timezone);
|
||||
const busyTimeEnd = DateTime.fromJSDate(new Date(busyTime.end)).setZone(timezone);
|
||||
const busyTimeStartDate = busyTimeStart.toJSDate();
|
||||
const busyTimeEndDate = busyTimeEnd.toJSDate();
|
||||
return {
|
||||
...busyTime,
|
||||
start: busyTimeStartDate,
|
||||
end: busyTimeEndDate,
|
||||
};
|
||||
}
|
||||
);
|
||||
return calendarBusyTimesConverted;
|
||||
} catch (error) {
|
||||
const calendarBusyTimesQuery = await getBusyCalendarTimes(
|
||||
this.buildNonDelegationCredentials(credentials),
|
||||
dateFrom,
|
||||
dateTo,
|
||||
composedSelectedCalendars
|
||||
);
|
||||
if (!calendarBusyTimesQuery.success) {
|
||||
throw new InternalServerErrorException(
|
||||
"Unable to fetch connected calendars events. Please try again later."
|
||||
);
|
||||
}
|
||||
const calendarBusyTimesConverted = calendarBusyTimesQuery.data.map(
|
||||
(busyTime: EventBusyDate & { timeZone?: string }) => {
|
||||
const busyTimeStart = DateTime.fromJSDate(new Date(busyTime.start)).setZone(timezone);
|
||||
const busyTimeEnd = DateTime.fromJSDate(new Date(busyTime.end)).setZone(timezone);
|
||||
const busyTimeStartDate = busyTimeStart.toJSDate();
|
||||
const busyTimeEndDate = busyTimeEnd.toJSDate();
|
||||
return {
|
||||
...busyTime,
|
||||
start: busyTimeStartDate,
|
||||
end: busyTimeEndDate,
|
||||
};
|
||||
}
|
||||
);
|
||||
return calendarBusyTimesConverted;
|
||||
}
|
||||
|
||||
async getUniqCalendarCredentials(calendarsToLoad: Calendar[], userId: User["id"]) {
|
||||
|
||||
+7
@@ -967,6 +967,7 @@ describe("Event types Endpoints", () => {
|
||||
calVideoSettings: {
|
||||
disableRecordingForGuests: true,
|
||||
disableRecordingForOrganizer: true,
|
||||
enableAutomaticRecordingForOrganizer: true,
|
||||
},
|
||||
bookingFields: [
|
||||
nameBookingField,
|
||||
@@ -1095,6 +1096,9 @@ describe("Event types Endpoints", () => {
|
||||
expect(updatedEventType.calVideoSettings?.disableRecordingForOrganizer).toEqual(
|
||||
body.calVideoSettings?.disableRecordingForOrganizer
|
||||
);
|
||||
expect(updatedEventType.calVideoSettings?.enableAutomaticRecordingForOrganizer).toEqual(
|
||||
body.calVideoSettings?.enableAutomaticRecordingForOrganizer
|
||||
);
|
||||
|
||||
eventType.title = newTitle;
|
||||
eventType.scheduleId = secondSchedule.id;
|
||||
@@ -1115,6 +1119,7 @@ describe("Event types Endpoints", () => {
|
||||
eventType.lockTimeZoneToggleOnBookingPage = updatedEventType.lockTimeZoneToggleOnBookingPage;
|
||||
eventType.color = updatedEventType.color;
|
||||
eventType.bookingFields = updatedEventType.bookingFields;
|
||||
eventType.calVideoSettings = updatedEventType.calVideoSettings;
|
||||
});
|
||||
});
|
||||
|
||||
@@ -1871,6 +1876,7 @@ describe("Event types Endpoints", () => {
|
||||
calVideoSettings: {
|
||||
disableRecordingForGuests: true,
|
||||
disableRecordingForOrganizer: true,
|
||||
enableAutomaticRecordingForOrganizer: true,
|
||||
},
|
||||
locations: [
|
||||
{
|
||||
@@ -1893,6 +1899,7 @@ describe("Event types Endpoints", () => {
|
||||
expect(createdEventType.locations).toEqual(body.locations);
|
||||
expect(createdEventType.calVideoSettings?.disableRecordingForGuests).toEqual(true);
|
||||
expect(createdEventType.calVideoSettings?.disableRecordingForOrganizer).toEqual(true);
|
||||
expect(createdEventType.calVideoSettings?.enableAutomaticRecordingForOrganizer).toEqual(true);
|
||||
firstCreatedEventType = responseBody.data;
|
||||
});
|
||||
});
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { createHash } from "crypto";
|
||||
|
||||
export const hashAPIKey = (apiKey: string): string => createHash("sha256").update(apiKey).digest("hex");
|
||||
export const sha256Hash = (token: string): string => createHash("sha256").update(token).digest("hex");
|
||||
|
||||
export const isApiKey = (authString: string, prefix: string): boolean =>
|
||||
authString?.startsWith(prefix ?? "cal_");
|
||||
|
||||
@@ -1,12 +1,15 @@
|
||||
import { PrismaBookingRepository } from "@/lib/repositories/prisma-booking.repository";
|
||||
import { PrismaEventTypeRepository } from "@/lib/repositories/prisma-event-type.repository";
|
||||
import { PrismaFeaturesRepository } from "@/lib/repositories/prisma-features.repository";
|
||||
import { PrismaOOORepository } from "@/lib/repositories/prisma-ooo.repository";
|
||||
import { PrismaRoutingFormResponseRepository } from "@/lib/repositories/prisma-routing-form-response.repository";
|
||||
import { PrismaScheduleRepository } from "@/lib/repositories/prisma-schedule.repository";
|
||||
import { PrismaSelectedSlotsRepository } from "@/lib/repositories/prisma-selected-slots.repository";
|
||||
import { PrismaSelectedSlotRepository } from "@/lib/repositories/prisma-selected-slot.repository";
|
||||
import { PrismaTeamRepository } from "@/lib/repositories/prisma-team.repository";
|
||||
import { PrismaUserRepository } from "@/lib/repositories/prisma-user.repository";
|
||||
import { AvailableSlotsService } from "@/lib/services/available-slots.service";
|
||||
import { CacheService } from "@/lib/services/cache.service";
|
||||
import { CheckBookingLimitsService } from "@/lib/services/check-booking-limits.service";
|
||||
import { PrismaModule } from "@/modules/prisma/prisma.module";
|
||||
import { Module } from "@nestjs/common";
|
||||
|
||||
@@ -16,11 +19,14 @@ import { Module } from "@nestjs/common";
|
||||
PrismaOOORepository,
|
||||
PrismaScheduleRepository,
|
||||
PrismaBookingRepository,
|
||||
PrismaSelectedSlotsRepository,
|
||||
PrismaSelectedSlotRepository,
|
||||
PrismaUserRepository,
|
||||
PrismaEventTypeRepository,
|
||||
PrismaRoutingFormResponseRepository,
|
||||
PrismaTeamRepository,
|
||||
PrismaFeaturesRepository,
|
||||
CheckBookingLimitsService,
|
||||
CacheService,
|
||||
AvailableSlotsService,
|
||||
],
|
||||
exports: [AvailableSlotsService],
|
||||
|
||||
+2
-2
@@ -1,11 +1,11 @@
|
||||
import { PrismaWriteService } from "@/modules/prisma/prisma-write.service";
|
||||
import { Injectable } from "@nestjs/common";
|
||||
|
||||
import { PrismaSelectedSlotsRepository as PrismaSelectedSlotsRepositoryLib } from "@calcom/platform-libraries/repositories";
|
||||
import { PrismaFeaturesRepository as PrismaFeaturesRepositoryLib } from "@calcom/platform-libraries/repositories";
|
||||
import { PrismaClient } from "@calcom/prisma";
|
||||
|
||||
@Injectable()
|
||||
export class PrismaSelectedSlotsRepository extends PrismaSelectedSlotsRepositoryLib {
|
||||
export class PrismaFeaturesRepository extends PrismaFeaturesRepositoryLib {
|
||||
constructor(private readonly dbWrite: PrismaWriteService) {
|
||||
super(dbWrite.prisma as unknown as PrismaClient);
|
||||
}
|
||||
@@ -0,0 +1,12 @@
|
||||
import { PrismaWriteService } from "@/modules/prisma/prisma-write.service";
|
||||
import { Injectable } from "@nestjs/common";
|
||||
|
||||
import { PrismaSelectedSlotRepository as PrismaSelectedSlotRepositoryLib } from "@calcom/platform-libraries/repositories";
|
||||
import { PrismaClient } from "@calcom/prisma";
|
||||
|
||||
@Injectable()
|
||||
export class PrismaSelectedSlotRepository extends PrismaSelectedSlotRepositoryLib {
|
||||
constructor(private readonly dbWrite: PrismaWriteService) {
|
||||
super(dbWrite.prisma as unknown as PrismaClient);
|
||||
}
|
||||
}
|
||||
@@ -1,11 +1,14 @@
|
||||
import { PrismaBookingRepository } from "@/lib/repositories/prisma-booking.repository";
|
||||
import { PrismaEventTypeRepository } from "@/lib/repositories/prisma-event-type.repository";
|
||||
import { PrismaFeaturesRepository } from "@/lib/repositories/prisma-features.repository";
|
||||
import { PrismaOOORepository } from "@/lib/repositories/prisma-ooo.repository";
|
||||
import { PrismaRoutingFormResponseRepository } from "@/lib/repositories/prisma-routing-form-response.repository";
|
||||
import { PrismaScheduleRepository } from "@/lib/repositories/prisma-schedule.repository";
|
||||
import { PrismaSelectedSlotsRepository } from "@/lib/repositories/prisma-selected-slots.repository";
|
||||
import { PrismaSelectedSlotRepository } from "@/lib/repositories/prisma-selected-slot.repository";
|
||||
import { PrismaTeamRepository } from "@/lib/repositories/prisma-team.repository";
|
||||
import { PrismaUserRepository } from "@/lib/repositories/prisma-user.repository";
|
||||
import { CacheService } from "@/lib/services/cache.service";
|
||||
import { CheckBookingLimitsService } from "@/lib/services/check-booking-limits.service";
|
||||
import { Injectable } from "@nestjs/common";
|
||||
|
||||
import { AvailableSlotsService as BaseAvailableSlotsService } from "@calcom/platform-libraries/slots";
|
||||
@@ -13,14 +16,15 @@ import { AvailableSlotsService as BaseAvailableSlotsService } from "@calcom/plat
|
||||
@Injectable()
|
||||
export class AvailableSlotsService extends BaseAvailableSlotsService {
|
||||
constructor(
|
||||
private readonly oooRepoDependency: PrismaOOORepository,
|
||||
private readonly scheduleRepoDependency: PrismaScheduleRepository,
|
||||
private readonly teamRepository: PrismaTeamRepository,
|
||||
private readonly routingFormResponseRepository: PrismaRoutingFormResponseRepository,
|
||||
private readonly bookingRepository: PrismaBookingRepository,
|
||||
private readonly selectedSlotsRepository: PrismaSelectedSlotsRepository,
|
||||
private readonly eventTypeRepository: PrismaEventTypeRepository,
|
||||
private readonly userRepository: PrismaUserRepository
|
||||
oooRepoDependency: PrismaOOORepository,
|
||||
scheduleRepoDependency: PrismaScheduleRepository,
|
||||
teamRepository: PrismaTeamRepository,
|
||||
routingFormResponseRepository: PrismaRoutingFormResponseRepository,
|
||||
bookingRepository: PrismaBookingRepository,
|
||||
selectedSlotRepository: PrismaSelectedSlotRepository,
|
||||
eventTypeRepository: PrismaEventTypeRepository,
|
||||
userRepository: PrismaUserRepository,
|
||||
featuresRepository: PrismaFeaturesRepository
|
||||
) {
|
||||
super({
|
||||
oooRepo: oooRepoDependency,
|
||||
@@ -28,9 +32,11 @@ export class AvailableSlotsService extends BaseAvailableSlotsService {
|
||||
teamRepo: teamRepository,
|
||||
routingFormResponseRepo: routingFormResponseRepository,
|
||||
bookingRepo: bookingRepository,
|
||||
selectedSlotsRepo: selectedSlotsRepository,
|
||||
selectedSlotRepo: selectedSlotRepository,
|
||||
eventTypeRepo: eventTypeRepository,
|
||||
userRepo: userRepository,
|
||||
checkBookingLimitsService: new CheckBookingLimitsService(bookingRepository) as any,
|
||||
cacheService: new CacheService(featuresRepository),
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,11 @@
|
||||
import { PrismaFeaturesRepository } from "@/lib/repositories/prisma-features.repository";
|
||||
import { Injectable } from "@nestjs/common";
|
||||
|
||||
import { CacheService as BaseCacheService } from "@calcom/platform-libraries";
|
||||
|
||||
@Injectable()
|
||||
export class CacheService extends BaseCacheService {
|
||||
constructor(featuresRepository: PrismaFeaturesRepository) {
|
||||
super({ featuresRepository });
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,13 @@
|
||||
import { CheckBookingLimitsService } from "@/lib/services/check-booking-limits.service";
|
||||
import { Injectable } from "@nestjs/common";
|
||||
|
||||
import { CheckBookingAndDurationLimitsService as BaseCheckBookingAndDurationLimitsService } from "@calcom/platform-libraries/bookings";
|
||||
|
||||
@Injectable()
|
||||
export class CheckBookingAndDurationLimitsService extends BaseCheckBookingAndDurationLimitsService {
|
||||
constructor(checkBookingLimitsService: CheckBookingLimitsService) {
|
||||
super({
|
||||
checkBookingLimitsService: checkBookingLimitsService,
|
||||
});
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,13 @@
|
||||
import { PrismaBookingRepository } from "@/lib/repositories/prisma-booking.repository";
|
||||
import { Injectable } from "@nestjs/common";
|
||||
|
||||
import { CheckBookingLimitsService as BaseCheckBookingLimitsService } from "@calcom/platform-libraries/bookings";
|
||||
|
||||
@Injectable()
|
||||
export class CheckBookingLimitsService extends BaseCheckBookingLimitsService {
|
||||
constructor(bookingRepository: PrismaBookingRepository) {
|
||||
super({
|
||||
bookingRepo: bookingRepository,
|
||||
});
|
||||
}
|
||||
}
|
||||
@@ -1,5 +1,5 @@
|
||||
import { getEnv } from "@/env";
|
||||
import { hashAPIKey, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { sha256Hash, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { Throttle } from "@/lib/endpoint-throttler-decorator";
|
||||
import { PrismaReadService } from "@/modules/prisma/prisma-read.service";
|
||||
import { ThrottlerStorageRedisService } from "@nest-lab/throttler-storage-redis";
|
||||
@@ -10,7 +10,6 @@ import {
|
||||
ThrottlerException,
|
||||
ThrottlerRequest,
|
||||
ThrottlerModuleOptions,
|
||||
seconds,
|
||||
} from "@nestjs/throttler";
|
||||
import { Request, Response } from "express";
|
||||
import { z } from "zod";
|
||||
@@ -218,18 +217,18 @@ export class CustomThrottlerGuard extends ThrottlerGuard {
|
||||
if (authorizationHeader) {
|
||||
const apiKeyPrefix = getEnv("API_KEY_PREFIX", "cal_");
|
||||
return isApiKey(authorizationHeader, apiKeyPrefix)
|
||||
? `api_key_${hashAPIKey(stripApiKey(authorizationHeader, apiKeyPrefix))}`
|
||||
: `access_token_${authorizationHeader}`;
|
||||
? `api_key_${sha256Hash(stripApiKey(authorizationHeader, apiKeyPrefix))}`
|
||||
: `access_token_${sha256Hash(authorizationHeader)}`;
|
||||
}
|
||||
|
||||
const oauthClientId = request.get(X_CAL_CLIENT_ID);
|
||||
|
||||
if (oauthClientId) {
|
||||
return `oauth_client_${oauthClientId}`;
|
||||
return `oauth_client_${sha256Hash(oauthClientId)}`;
|
||||
}
|
||||
|
||||
if (IP) {
|
||||
return `ip_${IP}`;
|
||||
return `ip_${sha256Hash(IP.toString())}`;
|
||||
}
|
||||
|
||||
this.logger.verbose(`no tracker found: ${request.url}`);
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { hashAPIKey, stripApiKey } from "@/lib/api-key";
|
||||
import { sha256Hash, stripApiKey } from "@/lib/api-key";
|
||||
import { AuthMethods } from "@/lib/enums/auth-methods";
|
||||
import { ApiKeysRepository } from "@/modules/api-keys/api-keys-repository";
|
||||
import { CreateApiKeyInput } from "@/modules/api-keys/inputs/create-api-key.input";
|
||||
@@ -61,7 +61,7 @@ export class ApiKeysService {
|
||||
|
||||
async refreshApiKey(authUserId: number, apiKey: string, refreshApiKeyInput: RefreshApiKeyInput) {
|
||||
const strippedApiKey = stripApiKey(apiKey, this.config.get<string>("api.keyPrefix"));
|
||||
const apiKeyHash = hashAPIKey(strippedApiKey);
|
||||
const apiKeyHash = sha256Hash(strippedApiKey);
|
||||
const apiKeyInDb = await this.apiKeysRepository.getApiKeyFromHash(apiKeyHash);
|
||||
if (!apiKeyInDb) {
|
||||
throw new UnauthorizedException("ApiKeysService - provided api key is not valid.");
|
||||
|
||||
@@ -11,6 +11,7 @@ import { SchedulesAtomsService } from "@/modules/atoms/services/schedules-atom.s
|
||||
import { CredentialsRepository } from "@/modules/credentials/credentials.repository";
|
||||
import { MembershipsRepository } from "@/modules/memberships/memberships.repository";
|
||||
import { OrganizationsModule } from "@/modules/organizations/organizations.module";
|
||||
import { OrganizationsTeamsRepository } from "@/modules/organizations/teams/index/organizations-teams.repository";
|
||||
import { PrismaModule } from "@/modules/prisma/prisma.module";
|
||||
import { RedisService } from "@/modules/redis/redis.service";
|
||||
import { TeamsEventTypesModule } from "@/modules/teams/event-types/teams-event-types.module";
|
||||
@@ -21,6 +22,7 @@ import { Module } from "@nestjs/common";
|
||||
@Module({
|
||||
imports: [PrismaModule, EventTypesModule_2024_06_14, OrganizationsModule, TeamsEventTypesModule],
|
||||
providers: [
|
||||
OrganizationsTeamsRepository,
|
||||
EventTypesAtomService,
|
||||
ConferencingAtomsService,
|
||||
AttributesAtomsService,
|
||||
|
||||
@@ -3,6 +3,7 @@ import { systemBeforeFieldEmail } from "@/ee/event-types/event-types_2024_06_14/
|
||||
import { AtomsRepository } from "@/modules/atoms/atoms.repository";
|
||||
import { CredentialsRepository } from "@/modules/credentials/credentials.repository";
|
||||
import { MembershipsRepository } from "@/modules/memberships/memberships.repository";
|
||||
import { OrganizationsTeamsRepository } from "@/modules/organizations/teams/index/organizations-teams.repository";
|
||||
import { PrismaReadService } from "@/modules/prisma/prisma-read.service";
|
||||
import { PrismaWriteService } from "@/modules/prisma/prisma-write.service";
|
||||
import { TeamsEventTypesService } from "@/modules/teams/event-types/services/teams-event-types.service";
|
||||
@@ -53,7 +54,8 @@ export class EventTypesAtomService {
|
||||
private readonly dbWrite: PrismaWriteService,
|
||||
private readonly dbRead: PrismaReadService,
|
||||
private readonly eventTypeService: EventTypesService_2024_06_14,
|
||||
private readonly teamEventTypeService: TeamsEventTypesService
|
||||
private readonly teamEventTypeService: TeamsEventTypesService,
|
||||
private readonly organizationsTeamsRepository: OrganizationsTeamsRepository
|
||||
) {}
|
||||
|
||||
private async getTeamSlug(teamId: number): Promise<string> {
|
||||
@@ -88,10 +90,12 @@ export class EventTypesAtomService {
|
||||
throw new NotFoundException(`Event type with id ${eventTypeId} not found`);
|
||||
}
|
||||
|
||||
if (eventType?.team?.id) {
|
||||
await this.checkTeamOwnsEventType(user.id, eventType.eventType.id, eventType.team.id);
|
||||
} else {
|
||||
this.eventTypeService.checkUserOwnsEventType(user.id, eventType.eventType);
|
||||
if (!isUserOrganizationAdmin) {
|
||||
if (eventType?.team?.id) {
|
||||
await this.checkTeamOwnsEventType(user.id, eventType.eventType.id, eventType.team.id);
|
||||
} else {
|
||||
this.eventTypeService.checkUserOwnsEventType(user.id, eventType.eventType);
|
||||
}
|
||||
}
|
||||
|
||||
// note (Lauris): don't show platform owner as one of the people that can be assigned to managed team event type
|
||||
@@ -115,7 +119,8 @@ export class EventTypesAtomService {
|
||||
user: UserWithProfile,
|
||||
teamId: number
|
||||
) {
|
||||
await this.checkCanUpdateTeamEventType(user.id, eventTypeId, teamId, body.scheduleId);
|
||||
await this.checkCanUpdateTeamEventType(user, eventTypeId, teamId, body.scheduleId);
|
||||
|
||||
const eventTypeUser = await this.eventTypeService.getUserToUpdateEvent(user);
|
||||
const bookingFields = body.bookingFields ? [...body.bookingFields] : undefined;
|
||||
|
||||
@@ -175,14 +180,31 @@ export class EventTypesAtomService {
|
||||
}
|
||||
|
||||
async checkCanUpdateTeamEventType(
|
||||
userId: number,
|
||||
user: UserWithProfile,
|
||||
eventTypeId: number,
|
||||
teamId: number,
|
||||
scheduleId: number | null | undefined
|
||||
) {
|
||||
await this.checkTeamOwnsEventType(userId, eventTypeId, teamId);
|
||||
const organizationId = this.usersService.getUserMainOrgId(user);
|
||||
|
||||
if (organizationId) {
|
||||
const isUserOrganizationAdmin = await this.membershipsRepository.isUserOrganizationAdmin(
|
||||
user.id,
|
||||
organizationId
|
||||
);
|
||||
|
||||
if (isUserOrganizationAdmin) {
|
||||
const orgTeam = await this.organizationsTeamsRepository.findOrgTeam(organizationId, teamId);
|
||||
if (orgTeam) {
|
||||
await this.teamEventTypeService.validateEventTypeExists(teamId, eventTypeId);
|
||||
return;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
await this.checkTeamOwnsEventType(user.id, eventTypeId, teamId);
|
||||
await this.teamEventTypeService.validateEventTypeExists(teamId, eventTypeId);
|
||||
await this.eventTypeService.checkUserOwnsSchedule(userId, scheduleId);
|
||||
await this.eventTypeService.checkUserOwnsSchedule(user.id, scheduleId);
|
||||
}
|
||||
|
||||
async checkTeamOwnsEventType(userId: number, eventTypeId: number, teamId: number) {
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import { OAuthClientRepository } from "@/modules/oauth-clients/oauth-client.repository";
|
||||
import { OAuthClientsOutputService } from "@/modules/oauth-clients/services/oauth-clients/oauth-clients-output.service";
|
||||
import { TokensRepository } from "@/modules/tokens/tokens.repository";
|
||||
import { TokensService } from "@/modules/tokens/tokens.service";
|
||||
import { createMock } from "@golevelup/ts-jest";
|
||||
import { ExecutionContext } from "@nestjs/common";
|
||||
import { ConfigService } from "@nestjs/config";
|
||||
@@ -19,6 +20,7 @@ describe("PermissionsGuard", () => {
|
||||
guard = new PermissionsGuard(
|
||||
reflector,
|
||||
createMock<TokensRepository>(),
|
||||
createMock<TokensService>(),
|
||||
createMock<ConfigService>({
|
||||
get: jest.fn().mockImplementation((key: string) => {
|
||||
switch (key) {
|
||||
@@ -118,6 +120,7 @@ describe("PermissionsGuard", () => {
|
||||
jest
|
||||
.spyOn(guard, "getOAuthClientByAccessToken")
|
||||
.mockResolvedValue(getMockOAuthClient(oAuthClientPermissions));
|
||||
jest.spyOn(guard, "getDecodedThirdPartyAccessToken").mockReturnValue(null);
|
||||
|
||||
await expect(guard.canActivate(mockContext)).rejects.toThrow(
|
||||
"PermissionsGuard - oAuth client with id=100 does not have the required permissions=SCHEDULE_WRITE"
|
||||
@@ -133,11 +136,22 @@ describe("PermissionsGuard", () => {
|
||||
jest
|
||||
.spyOn(guard, "getOAuthClientByAccessToken")
|
||||
.mockResolvedValue(getMockOAuthClient(oAuthClientPermissions));
|
||||
jest.spyOn(guard, "getDecodedThirdPartyAccessToken").mockReturnValue(null);
|
||||
|
||||
await expect(guard.canActivate(mockContext)).rejects.toThrow(
|
||||
"PermissionsGuard - oAuth client with id=100 does not have the required permissions=SCHEDULE_WRITE, SCHEDULE_READ"
|
||||
);
|
||||
});
|
||||
|
||||
it("should return true for 3rd party access token", async () => {
|
||||
const mockContext = createMockExecutionContext({ Authorization: "Bearer token" });
|
||||
jest.spyOn(guard, "getDecodedThirdPartyAccessToken").mockReturnValue({
|
||||
scope: ["scope"],
|
||||
token_type: "Bearer",
|
||||
});
|
||||
|
||||
await expect(guard.canActivate(mockContext)).resolves.toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe("when OAuth id is provided", () => {
|
||||
|
||||
@@ -3,6 +3,7 @@ import { Permissions } from "@/modules/auth/decorators/permissions/permissions.d
|
||||
import { OAuthClientRepository } from "@/modules/oauth-clients/oauth-client.repository";
|
||||
import { OAuthClientsOutputService } from "@/modules/oauth-clients/services/oauth-clients/oauth-clients-output.service";
|
||||
import { TokensRepository } from "@/modules/tokens/tokens.repository";
|
||||
import { TokensService } from "@/modules/tokens/tokens.service";
|
||||
import { Injectable, CanActivate, ExecutionContext, ForbiddenException } from "@nestjs/common";
|
||||
import { ConfigService } from "@nestjs/config";
|
||||
import { Reflector } from "@nestjs/core";
|
||||
@@ -17,6 +18,7 @@ export class PermissionsGuard implements CanActivate {
|
||||
constructor(
|
||||
private reflector: Reflector,
|
||||
private tokensRepository: TokensRepository,
|
||||
private tokensService: TokensService,
|
||||
private readonly config: ConfigService,
|
||||
private readonly oAuthClientRepository: OAuthClientRepository,
|
||||
private readonly oAuthClientsOutputService: OAuthClientsOutputService
|
||||
@@ -35,9 +37,10 @@ export class PermissionsGuard implements CanActivate {
|
||||
const nextAuthToken = await getToken({ req: request, secret: nextAuthSecret });
|
||||
const oAuthClientId = request.params?.clientId || request.get(X_CAL_CLIENT_ID);
|
||||
const apiKey = bearerToken && isApiKey(bearerToken, this.config.get("api.apiKeyPrefix") ?? "cal_");
|
||||
const isThirdPartyBearerToken = bearerToken && this.getDecodedThirdPartyAccessToken(bearerToken);
|
||||
|
||||
// only check permissions for accessTokens attached to an oAuth Client or oAuth credentials, not for next token or api key
|
||||
if (nextAuthToken || apiKey) {
|
||||
// only check permissions for accessTokens attached to platform oAuth Client or platform oAuth credentials, not for next token or api key or third party oauth client
|
||||
if (nextAuthToken || apiKey || isThirdPartyBearerToken) {
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -87,4 +90,8 @@ export class PermissionsGuard implements CanActivate {
|
||||
}
|
||||
return oAuthClient;
|
||||
}
|
||||
|
||||
getDecodedThirdPartyAccessToken(bearerToken: string) {
|
||||
return this.tokensService.getDecodedThirdPartyAccessToken(bearerToken);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -9,7 +9,7 @@ import { OAuthFlowService } from "@/modules/oauth-clients/services/oauth-flow.se
|
||||
import { PrismaReadService } from "@/modules/prisma/prisma-read.service";
|
||||
import { PrismaWriteService } from "@/modules/prisma/prisma-write.service";
|
||||
import { ProfilesModule } from "@/modules/profiles/profiles.module";
|
||||
import { TokensRepository } from "@/modules/tokens/tokens.repository";
|
||||
import { TokensModule } from "@/modules/tokens/tokens.module";
|
||||
import { UsersService } from "@/modules/users/services/users.service";
|
||||
import { UsersRepository } from "@/modules/users/users.repository";
|
||||
import { ExecutionContext, HttpException } from "@nestjs/common";
|
||||
@@ -64,6 +64,7 @@ describe("ApiAuthStrategy", () => {
|
||||
load: [appConfig],
|
||||
}),
|
||||
ProfilesModule,
|
||||
TokensModule,
|
||||
],
|
||||
providers: [
|
||||
MockedRedisService,
|
||||
@@ -77,7 +78,6 @@ describe("ApiAuthStrategy", () => {
|
||||
OAuthClientRepository,
|
||||
PrismaReadService,
|
||||
PrismaWriteService,
|
||||
TokensRepository,
|
||||
JwtService,
|
||||
DeploymentsRepository,
|
||||
NestJwtService,
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { hashAPIKey, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { sha256Hash, isApiKey, stripApiKey } from "@/lib/api-key";
|
||||
import { AuthMethods } from "@/lib/enums/auth-methods";
|
||||
import { isOriginAllowed } from "@/lib/is-origin-allowed/is-origin-allowed";
|
||||
import { BaseStrategy } from "@/lib/passport/strategies/types";
|
||||
@@ -8,32 +8,20 @@ import { OAuthClientRepository } from "@/modules/oauth-clients/oauth-client.repo
|
||||
import { OAuthFlowService } from "@/modules/oauth-clients/services/oauth-flow.service";
|
||||
import { ProfilesRepository } from "@/modules/profiles/profiles.repository";
|
||||
import { TokensRepository } from "@/modules/tokens/tokens.repository";
|
||||
import { TokensService } from "@/modules/tokens/tokens.service";
|
||||
import { UsersService } from "@/modules/users/services/users.service";
|
||||
import { UserWithProfile, UsersRepository } from "@/modules/users/users.repository";
|
||||
import {
|
||||
HttpException,
|
||||
Injectable,
|
||||
InternalServerErrorException,
|
||||
UnauthorizedException,
|
||||
} from "@nestjs/common";
|
||||
import { Injectable, InternalServerErrorException, UnauthorizedException } from "@nestjs/common";
|
||||
import { Logger } from "@nestjs/common";
|
||||
import { ConfigService } from "@nestjs/config";
|
||||
import { PassportStrategy } from "@nestjs/passport";
|
||||
import type { Request } from "express";
|
||||
import * as jwt from "jsonwebtoken";
|
||||
import { getToken } from "next-auth/jwt";
|
||||
|
||||
import { INVALID_ACCESS_TOKEN, X_CAL_CLIENT_ID, X_CAL_SECRET_KEY } from "@calcom/platform-constants";
|
||||
|
||||
import type { AllowedAuthMethod } from "../../decorators/api-auth-guard-only-allow.decorator";
|
||||
|
||||
interface OAuthTokenPayload {
|
||||
userId?: number;
|
||||
teamId?: number;
|
||||
scope: string[];
|
||||
token_type: string;
|
||||
}
|
||||
|
||||
export type ApiAuthGuardUser = UserWithProfile & { isSystemAdmin: boolean };
|
||||
export type ApiAuthGuardRequest = Request & {
|
||||
authMethod: AuthMethods;
|
||||
@@ -53,6 +41,7 @@ export class ApiAuthStrategy extends PassportStrategy(BaseStrategy, "api-auth")
|
||||
private readonly config: ConfigService,
|
||||
private readonly oauthFlowService: OAuthFlowService,
|
||||
private readonly tokensRepository: TokensRepository,
|
||||
private readonly tokensService: TokensService,
|
||||
private readonly userRepository: UsersRepository,
|
||||
private readonly apiKeyRepository: ApiKeysRepository,
|
||||
private readonly oauthRepository: OAuthClientRepository,
|
||||
@@ -237,7 +226,7 @@ export class ApiAuthStrategy extends PassportStrategy(BaseStrategy, "api-auth")
|
||||
);
|
||||
}
|
||||
const strippedApiKey = stripApiKey(apiKey, this.config.get<string>("api.keyPrefix"));
|
||||
const apiKeyHash = hashAPIKey(strippedApiKey);
|
||||
const apiKeyHash = sha256Hash(strippedApiKey);
|
||||
const keyData = await this.apiKeyRepository.getApiKeyFromHash(apiKeyHash);
|
||||
if (!keyData) {
|
||||
throw new UnauthorizedException("ApiAuthStrategy - api key - Your api key is not valid");
|
||||
@@ -323,20 +312,8 @@ export class ApiAuthStrategy extends PassportStrategy(BaseStrategy, "api-auth")
|
||||
token: string,
|
||||
request: ApiAuthGuardRequest
|
||||
): Promise<{ success: true; data: UserWithProfile } | { success: false }> {
|
||||
// Removed requiredScopes parameter
|
||||
const encryptionKey = this.config.get<string>("CALENDSO_ENCRYPTION_KEY");
|
||||
if (!encryptionKey) {
|
||||
throw new InternalServerErrorException("CALENDSO_ENCRYPTION_KEY environment variable is not set.");
|
||||
}
|
||||
|
||||
let decodedToken: OAuthTokenPayload;
|
||||
try {
|
||||
decodedToken = jwt.verify(token, encryptionKey) as OAuthTokenPayload;
|
||||
} catch (e) {
|
||||
return { success: false };
|
||||
}
|
||||
|
||||
if (!decodedToken || decodedToken.token_type !== "Access Token") {
|
||||
const decodedToken = this.tokensService.getDecodedThirdPartyAccessToken(token);
|
||||
if (!decodedToken) {
|
||||
return { success: false };
|
||||
}
|
||||
|
||||
|
||||
@@ -9,12 +9,12 @@ import { CredentialsRepository } from "@/modules/credentials/credentials.reposit
|
||||
import { PrismaReadService } from "@/modules/prisma/prisma-read.service";
|
||||
import { PrismaWriteService } from "@/modules/prisma/prisma-write.service";
|
||||
import { SelectedCalendarsRepository } from "@/modules/selected-calendars/selected-calendars.repository";
|
||||
import { TokensRepository } from "@/modules/tokens/tokens.repository";
|
||||
import { TokensModule } from "@/modules/tokens/tokens.module";
|
||||
import { UsersRepository } from "@/modules/users/users.repository";
|
||||
import { Module } from "@nestjs/common";
|
||||
|
||||
@Module({
|
||||
imports: [],
|
||||
imports: [TokensModule],
|
||||
providers: [
|
||||
GCalService,
|
||||
GoogleCalendarService,
|
||||
@@ -22,7 +22,6 @@ import { Module } from "@nestjs/common";
|
||||
BookingReferencesRepository_2024_08_13,
|
||||
CredentialsRepository,
|
||||
CalendarsService,
|
||||
TokensRepository,
|
||||
SelectedCalendarsRepository,
|
||||
PrismaReadService,
|
||||
PrismaWriteService,
|
||||
|
||||
+11
@@ -27,6 +27,17 @@ export class OrganizationsMembershipService {
|
||||
return this.organizationsMembershipOutputService.getOrgMembershipOutput(membership);
|
||||
}
|
||||
|
||||
async isOrgAdminOrOwner(organizationId: number, userId: number) {
|
||||
const membership = await this.organizationsMembershipRepository.findOrgMembershipByUserId(
|
||||
organizationId,
|
||||
userId
|
||||
);
|
||||
if (!membership) {
|
||||
return false;
|
||||
}
|
||||
return membership.role === "ADMIN" || membership.role === "OWNER";
|
||||
}
|
||||
|
||||
async getOrgMembershipByUserId(organizationId: number, userId: number) {
|
||||
const membership = await this.organizationsMembershipRepository.findOrgMembershipByUserId(
|
||||
organizationId,
|
||||
|
||||
+3
-3
@@ -1,7 +1,7 @@
|
||||
import { bootstrap } from "@/app";
|
||||
import { AppModule } from "@/app.module";
|
||||
import { getEnv } from "@/env";
|
||||
import { hashAPIKey, stripApiKey } from "@/lib/api-key";
|
||||
import { sha256Hash, stripApiKey } from "@/lib/api-key";
|
||||
import { RefreshApiKeyOutput } from "@/modules/api-keys/outputs/refresh-api-key.output";
|
||||
import { CreateOAuthClientResponseDto } from "@/modules/oauth-clients/controllers/oauth-clients/responses/CreateOAuthClientResponse.dto";
|
||||
import { GetOAuthClientResponseDto } from "@/modules/oauth-clients/controllers/oauth-clients/responses/GetOAuthClientResponse.dto";
|
||||
@@ -283,7 +283,7 @@ describe("Organizations Organizations Endpoints", () => {
|
||||
expect(managedOrgApiKeys?.length).toEqual(1);
|
||||
expect(managedOrgApiKeys?.[0]?.id).toBeDefined();
|
||||
const apiKeyPrefix = getEnv("API_KEY_PREFIX", "cal_");
|
||||
const hashedApiKey = `${hashAPIKey(stripApiKey(managedOrg?.apiKey, apiKeyPrefix))}`;
|
||||
const hashedApiKey = `${sha256Hash(stripApiKey(managedOrg?.apiKey, apiKeyPrefix))}`;
|
||||
expect(managedOrgApiKeys?.[0]?.hashedKey).toEqual(hashedApiKey);
|
||||
const expectedExpiresAt = DateTime.fromJSDate(newDate).setZone("utc").plus({ days: 30 }).toJSDate();
|
||||
expect(managedOrgApiKeys?.[0]?.expiresAt).toEqual(expectedExpiresAt);
|
||||
@@ -484,7 +484,7 @@ describe("Organizations Organizations Endpoints", () => {
|
||||
expect(managedOrgApiKeys?.length).toEqual(1);
|
||||
expect(managedOrgApiKeys?.[0]?.id).toBeDefined();
|
||||
const apiKeyPrefix = getEnv("API_KEY_PREFIX", "cal_");
|
||||
const hashedApiKey = `${hashAPIKey(stripApiKey(newApiKey, apiKeyPrefix))}`;
|
||||
const hashedApiKey = `${sha256Hash(stripApiKey(newApiKey, apiKeyPrefix))}`;
|
||||
expect(managedOrgApiKeys?.[0]?.hashedKey).toEqual(hashedApiKey);
|
||||
const expectedExpiresAt = DateTime.fromJSDate(newDate).setZone("utc").plus({ days: 60 }).toJSDate();
|
||||
expect(managedOrgApiKeys?.[0]?.expiresAt).toEqual(expectedExpiresAt);
|
||||
|
||||
+1
-4
@@ -86,11 +86,10 @@ export class CreateRoutingFormResponseOutputData {
|
||||
eventTypeId?: number;
|
||||
|
||||
@ValidateNested()
|
||||
@ApiProperty({ type: Routing })
|
||||
@Type(() => Routing)
|
||||
@ApiPropertyOptional({
|
||||
type: Routing,
|
||||
description: "The routing information.",
|
||||
description: "The routing information that could be passed as is to the booking API.",
|
||||
example: {
|
||||
eventTypeId: 123,
|
||||
routing: {
|
||||
@@ -100,8 +99,6 @@ export class CreateRoutingFormResponseOutputData {
|
||||
},
|
||||
},
|
||||
})
|
||||
@ValidateNested()
|
||||
@Type(() => Routing)
|
||||
routing?: Routing;
|
||||
|
||||
@IsString()
|
||||
|
||||
+3
-4
@@ -55,15 +55,14 @@ export class SharedRoutingFormResponseService {
|
||||
// Extract event type information from the routed URL
|
||||
const { eventTypeId, crmParams } = await this.extractEventTypeAndCrmParams(user.id, redirectUrl);
|
||||
|
||||
const paramsForGetAvailableSlots = {
|
||||
// Get available slots using the slots service with CRM parameters
|
||||
const slots = await this.slotsService.getAvailableSlotsWithRouting({
|
||||
type: ById_2024_09_04_type,
|
||||
eventTypeId,
|
||||
...slotsQuery,
|
||||
...crmParams,
|
||||
} as const;
|
||||
});
|
||||
|
||||
// Get available slots using the slots service with CRM parameters
|
||||
const slots = await this.slotsService.getAvailableSlots(paramsForGetAvailableSlots);
|
||||
const teamMemberIds = crmParams.routedTeamMemberIds ?? [];
|
||||
const teamMemberEmail = crmParams.teamMemberEmail ?? undefined;
|
||||
const skipContactOwner = crmParams.skipContactOwner ?? undefined;
|
||||
|
||||
+10
-7
@@ -14,6 +14,7 @@ import { IsAdminAPIEnabledGuard } from "@/modules/auth/guards/organizations/is-a
|
||||
import { IsOrgGuard } from "@/modules/auth/guards/organizations/is-org.guard";
|
||||
import { RolesGuard } from "@/modules/auth/guards/roles/roles.guard";
|
||||
import { IsTeamInOrg } from "@/modules/auth/guards/teams/is-team-in-org.guard";
|
||||
import { OrganizationsMembershipService } from "@/modules/organizations/memberships/services/organizations-membership.service";
|
||||
import { CreateOrgTeamDto } from "@/modules/organizations/teams/index/inputs/create-organization-team.input";
|
||||
import { UpdateOrgTeamDto } from "@/modules/organizations/teams/index/inputs/update-organization-team.input";
|
||||
import {
|
||||
@@ -56,7 +57,10 @@ import { Team } from "@calcom/prisma/client";
|
||||
@ApiHeader(OPTIONAL_X_CAL_SECRET_KEY_HEADER)
|
||||
@ApiHeader(OPTIONAL_API_KEY_HEADER)
|
||||
export class OrganizationsTeamsController {
|
||||
constructor(private organizationsTeamsService: OrganizationsTeamsService) {}
|
||||
constructor(
|
||||
private organizationsTeamsService: OrganizationsTeamsService,
|
||||
private organizationsMembershipService: OrganizationsMembershipService
|
||||
) {}
|
||||
|
||||
@Get()
|
||||
@ApiOperation({ summary: "Get all teams" })
|
||||
@@ -84,12 +88,11 @@ export class OrganizationsTeamsController {
|
||||
@GetUser() user: UserWithProfile
|
||||
): Promise<OrgMeTeamsOutputResponseDto> {
|
||||
const { skip, take } = queryParams;
|
||||
const teams = await this.organizationsTeamsService.getPaginatedOrgUserTeams(
|
||||
orgId,
|
||||
user.id,
|
||||
skip ?? 0,
|
||||
take ?? 250
|
||||
);
|
||||
const isOrgAdminOrOwner = await this.organizationsMembershipService.isOrgAdminOrOwner(orgId, user.id);
|
||||
const teams = isOrgAdminOrOwner
|
||||
? await this.organizationsTeamsService.getPaginatedOrgTeamsWithMembers(orgId, skip ?? 0, take ?? 250)
|
||||
: await this.organizationsTeamsService.getPaginatedOrgUserTeams(orgId, user.id, skip ?? 0, take ?? 250);
|
||||
|
||||
return {
|
||||
status: SUCCESS_STATUS,
|
||||
data: teams.map((team) => {
|
||||
|
||||
@@ -107,4 +107,17 @@ export class OrganizationsTeamsRepository {
|
||||
take,
|
||||
});
|
||||
}
|
||||
|
||||
async findOrgTeamsPaginatedWithMembers(organizationId: number, skip: number, take: number) {
|
||||
return this.dbRead.prisma.team.findMany({
|
||||
where: {
|
||||
parentId: organizationId,
|
||||
},
|
||||
include: {
|
||||
members: { select: { accepted: true, userId: true, role: true } },
|
||||
},
|
||||
skip,
|
||||
take,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
+9
@@ -24,6 +24,15 @@ export class OrganizationsTeamsService {
|
||||
return teams;
|
||||
}
|
||||
|
||||
async getPaginatedOrgTeamsWithMembers(organizationId: number, skip = 0, take = 250) {
|
||||
const teams = await this.organizationsTeamRepository.findOrgTeamsPaginatedWithMembers(
|
||||
organizationId,
|
||||
skip,
|
||||
take
|
||||
);
|
||||
return teams;
|
||||
}
|
||||
|
||||
async getPaginatedOrgTeams(organizationId: number, skip = 0, take = 250) {
|
||||
const teams = await this.organizationsTeamRepository.findOrgTeamsPaginated(organizationId, skip, take);
|
||||
return teams;
|
||||
|
||||
+4
-4
@@ -16,7 +16,7 @@ import { AttendeeRepositoryFixture } from "test/fixtures/repository/attendee.rep
|
||||
import { BookingSeatRepositoryFixture } from "test/fixtures/repository/booking-seat.repository.fixture";
|
||||
import { BookingsRepositoryFixture } from "test/fixtures/repository/bookings.repository.fixture";
|
||||
import { EventTypesRepositoryFixture } from "test/fixtures/repository/event-types.repository.fixture";
|
||||
import { SelectedSlotsRepositoryFixture } from "test/fixtures/repository/selected-slots.repository.fixture";
|
||||
import { SelectedSlotRepositoryFixture } from "test/fixtures/repository/selected-slot.repository.fixture";
|
||||
import { UserRepositoryFixture } from "test/fixtures/repository/users.repository.fixture";
|
||||
import { randomString } from "test/utils/randomString";
|
||||
import { withApiAuth } from "test/utils/withApiAuth";
|
||||
@@ -250,7 +250,7 @@ describe("Slots 2024-04-15 Endpoints", () => {
|
||||
let userRepositoryFixture: UserRepositoryFixture;
|
||||
let schedulesService: SchedulesService_2024_06_11;
|
||||
let eventTypesRepositoryFixture: EventTypesRepositoryFixture;
|
||||
let selectedSlotsRepositoryFixture: SelectedSlotsRepositoryFixture;
|
||||
let selectedSlotRepositoryFixture: SelectedSlotRepositoryFixture;
|
||||
let bookingsRepositoryFixture: BookingsRepositoryFixture;
|
||||
let bookingSeatsRepositoryFixture: BookingSeatRepositoryFixture;
|
||||
let attendeesRepositoryFixture: AttendeeRepositoryFixture;
|
||||
@@ -288,7 +288,7 @@ describe("Slots 2024-04-15 Endpoints", () => {
|
||||
userRepositoryFixture = new UserRepositoryFixture(moduleRef);
|
||||
schedulesService = moduleRef.get<SchedulesService_2024_06_11>(SchedulesService_2024_06_11);
|
||||
eventTypesRepositoryFixture = new EventTypesRepositoryFixture(moduleRef);
|
||||
selectedSlotsRepositoryFixture = new SelectedSlotsRepositoryFixture(moduleRef);
|
||||
selectedSlotRepositoryFixture = new SelectedSlotRepositoryFixture(moduleRef);
|
||||
bookingsRepositoryFixture = new BookingsRepositoryFixture(moduleRef);
|
||||
bookingSeatsRepositoryFixture = new BookingSeatRepositoryFixture(moduleRef);
|
||||
attendeesRepositoryFixture = new AttendeeRepositoryFixture(moduleRef);
|
||||
@@ -773,7 +773,7 @@ describe("Slots 2024-04-15 Endpoints", () => {
|
||||
|
||||
afterAll(async () => {
|
||||
await userRepositoryFixture.deleteByEmail(user.email);
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reservedSlotUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reservedSlotUid);
|
||||
await bookingsRepositoryFixture.deleteAllBookings(user.id, user.email);
|
||||
|
||||
await app.close();
|
||||
|
||||
+5
-5
@@ -21,7 +21,7 @@ import { ApiKeysRepositoryFixture } from "test/fixtures/repository/api-keys.repo
|
||||
import { BookingsRepositoryFixture } from "test/fixtures/repository/bookings.repository.fixture";
|
||||
import { EventTypesRepositoryFixture } from "test/fixtures/repository/event-types.repository.fixture";
|
||||
import { MembershipRepositoryFixture } from "test/fixtures/repository/membership.repository.fixture";
|
||||
import { SelectedSlotsRepositoryFixture } from "test/fixtures/repository/selected-slots.repository.fixture";
|
||||
import { SelectedSlotRepositoryFixture } from "test/fixtures/repository/selected-slot.repository.fixture";
|
||||
import { TeamRepositoryFixture } from "test/fixtures/repository/team.repository.fixture";
|
||||
import { UserRepositoryFixture } from "test/fixtures/repository/users.repository.fixture";
|
||||
import { randomString } from "test/utils/randomString";
|
||||
@@ -44,7 +44,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
let membershipsRepositoryFixture: MembershipRepositoryFixture;
|
||||
let bookingsRepositoryFixture: BookingsRepositoryFixture;
|
||||
let apiKeysRepositoryFixture: ApiKeysRepositoryFixture;
|
||||
let selectedSlotsRepositoryFixture: SelectedSlotsRepositoryFixture;
|
||||
let selectedSlotRepositoryFixture: SelectedSlotRepositoryFixture;
|
||||
|
||||
const teammateEmailOne = `slots-2024-09-04-user-1-team-slots-${randomString()}`;
|
||||
let teammateApiKeyString: string;
|
||||
@@ -93,7 +93,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
membershipsRepositoryFixture = new MembershipRepositoryFixture(moduleRef);
|
||||
bookingsRepositoryFixture = new BookingsRepositoryFixture(moduleRef);
|
||||
apiKeysRepositoryFixture = new ApiKeysRepositoryFixture(moduleRef);
|
||||
selectedSlotsRepositoryFixture = new SelectedSlotsRepositoryFixture(moduleRef);
|
||||
selectedSlotRepositoryFixture = new SelectedSlotRepositoryFixture(moduleRef);
|
||||
|
||||
teammateOne = await userRepositoryFixture.create({
|
||||
email: teammateEmailOne,
|
||||
@@ -368,14 +368,14 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
);
|
||||
expect(slots).toEqual({ ...expectedSlotsUTC, "2050-09-05": expectedSlotsUTC2050_09_05 });
|
||||
|
||||
const dbSlot = await selectedSlotsRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
const dbSlot = await selectedSlotRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
expect(dbSlot).toBeDefined();
|
||||
if (dbSlot) {
|
||||
const dbReleaseAt = DateTime.fromJSDate(dbSlot.releaseAt, { zone: "UTC" }).toISO();
|
||||
const expectedReleaseAt = DateTime.fromISO(now, { zone: "UTC" }).plus({ minutes: 10 }).toISO();
|
||||
expect(dbReleaseAt).toEqual(expectedReleaseAt);
|
||||
}
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
clear();
|
||||
});
|
||||
|
||||
|
||||
+16
-16
@@ -30,7 +30,7 @@ import { BookingsRepositoryFixture } from "test/fixtures/repository/bookings.rep
|
||||
import { EventTypesRepositoryFixture } from "test/fixtures/repository/event-types.repository.fixture";
|
||||
import { MembershipRepositoryFixture } from "test/fixtures/repository/membership.repository.fixture";
|
||||
import { OOORepositoryFixture } from "test/fixtures/repository/ooo.repository.fixture";
|
||||
import { SelectedSlotsRepositoryFixture } from "test/fixtures/repository/selected-slots.repository.fixture";
|
||||
import { SelectedSlotRepositoryFixture } from "test/fixtures/repository/selected-slot.repository.fixture";
|
||||
import { TeamRepositoryFixture } from "test/fixtures/repository/team.repository.fixture";
|
||||
import { UserRepositoryFixture } from "test/fixtures/repository/users.repository.fixture";
|
||||
import { randomString } from "test/utils/randomString";
|
||||
@@ -49,7 +49,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
let userRepositoryFixture: UserRepositoryFixture;
|
||||
let schedulesService: SchedulesService_2024_06_11;
|
||||
let eventTypesRepositoryFixture: EventTypesRepositoryFixture;
|
||||
let selectedSlotsRepositoryFixture: SelectedSlotsRepositoryFixture;
|
||||
let selectedSlotRepositoryFixture: SelectedSlotRepositoryFixture;
|
||||
let bookingsRepositoryFixture: BookingsRepositoryFixture;
|
||||
let bookingSeatsRepositoryFixture: BookingSeatRepositoryFixture;
|
||||
let attendeesRepositoryFixture: AttendeeRepositoryFixture;
|
||||
@@ -104,7 +104,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
userRepositoryFixture = new UserRepositoryFixture(moduleRef);
|
||||
schedulesService = moduleRef.get<SchedulesService_2024_06_11>(SchedulesService_2024_06_11);
|
||||
eventTypesRepositoryFixture = new EventTypesRepositoryFixture(moduleRef);
|
||||
selectedSlotsRepositoryFixture = new SelectedSlotsRepositoryFixture(moduleRef);
|
||||
selectedSlotRepositoryFixture = new SelectedSlotRepositoryFixture(moduleRef);
|
||||
bookingsRepositoryFixture = new BookingsRepositoryFixture(moduleRef);
|
||||
bookingSeatsRepositoryFixture = new BookingSeatRepositoryFixture(moduleRef);
|
||||
attendeesRepositoryFixture = new AttendeeRepositoryFixture(moduleRef);
|
||||
@@ -483,7 +483,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
);
|
||||
expect(slots).toEqual({ ...expectedSlotsUTC, "2050-09-05": expectedSlotsUTC2050_09_05 });
|
||||
|
||||
const dbSlot = await selectedSlotsRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
const dbSlot = await selectedSlotRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
expect(dbSlot).toBeDefined();
|
||||
if (dbSlot) {
|
||||
const dbReleaseAt = DateTime.fromJSDate(dbSlot.releaseAt, { zone: "UTC" }).toISO();
|
||||
@@ -617,7 +617,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
);
|
||||
expect(slots).toEqual({ ...expectedSlotsUTC, "2050-09-05": expectedSlotsUTC2050_09_05 });
|
||||
|
||||
const dbSlot = await selectedSlotsRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
const dbSlot = await selectedSlotRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
expect(dbSlot).toBeDefined();
|
||||
if (dbSlot) {
|
||||
const dbReleaseAt = DateTime.fromJSDate(dbSlot.releaseAt, { zone: "UTC" }).toISO();
|
||||
@@ -719,14 +719,14 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
);
|
||||
expect(slots).toEqual({ ...expectedSlotsUTC, "2050-09-05": expectedSlotsUTC2050_09_05 });
|
||||
|
||||
const dbSlot = await selectedSlotsRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
const dbSlot = await selectedSlotRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
expect(dbSlot).toBeDefined();
|
||||
if (dbSlot) {
|
||||
const dbReleaseAt = DateTime.fromJSDate(dbSlot.releaseAt, { zone: "UTC" }).toISO();
|
||||
const expectedReleaseAt = DateTime.fromISO(now, { zone: "UTC" }).plus({ minutes: 10 }).toISO();
|
||||
expect(dbReleaseAt).toEqual(expectedReleaseAt);
|
||||
}
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
clear();
|
||||
});
|
||||
|
||||
@@ -775,14 +775,14 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
);
|
||||
expect(slots).toEqual({ ...expectedSlotsUTC, "2050-09-05": expectedSlotsUTC2050_09_05 });
|
||||
|
||||
const dbSlot = await selectedSlotsRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
const dbSlot = await selectedSlotRepositoryFixture.getByUid(reservedSlot.reservationUid);
|
||||
expect(dbSlot).toBeDefined();
|
||||
if (dbSlot) {
|
||||
const dbReleaseAt = DateTime.fromJSDate(dbSlot.releaseAt, { zone: "UTC" }).toISO();
|
||||
const expectedReleaseAt = DateTime.fromISO(now, { zone: "UTC" }).plus({ minutes: 10 }).toISO();
|
||||
expect(dbReleaseAt).toEqual(expectedReleaseAt);
|
||||
}
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
clear();
|
||||
});
|
||||
|
||||
@@ -1397,7 +1397,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
);
|
||||
expect(slots).toEqual({ ...expectedSlotsUTC, "2050-09-05": expectedSlotsUTC2050_09_05 });
|
||||
|
||||
const dbSlot = await selectedSlotsRepositoryFixture.getByUid(
|
||||
const dbSlot = await selectedSlotRepositoryFixture.getByUid(
|
||||
responseReservedVariableSlot.reservationUid
|
||||
);
|
||||
expect(dbSlot).toBeDefined();
|
||||
@@ -1674,7 +1674,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
);
|
||||
expect(responseReservedSlot.reservationDuration).toEqual(5);
|
||||
await bookingsRepositoryFixture.deleteById(booking.id);
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(responseReservedSlot.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(responseReservedSlot.reservationUid);
|
||||
});
|
||||
|
||||
it("should be able to reserve a slot if booking is rejected during that time", async () => {
|
||||
@@ -1872,7 +1872,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
|
||||
expect(reserveResponse.body.data.reservationUid).toBeDefined();
|
||||
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await bookingsRepositoryFixture.deleteById(existingBooking.id);
|
||||
});
|
||||
|
||||
@@ -1888,7 +1888,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
|
||||
expect(reserveResponse.body.data.reservationUid).toBeDefined();
|
||||
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await bookingsRepositoryFixture.deleteById(existingBooking.id);
|
||||
});
|
||||
|
||||
@@ -1903,7 +1903,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
.expect(201);
|
||||
|
||||
expect(reserveResponse.body.data.reservationUid).toBeDefined();
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await bookingsRepositoryFixture.deleteById(existingBooking.id);
|
||||
});
|
||||
|
||||
@@ -1918,7 +1918,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
.expect(201);
|
||||
|
||||
expect(reserveResponse.body.data.reservationUid).toBeDefined();
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reserveResponse.body.data.reservationUid);
|
||||
await bookingsRepositoryFixture.deleteById(existingBooking.id);
|
||||
});
|
||||
});
|
||||
@@ -1928,7 +1928,7 @@ describe("Slots 2024-09-04 Endpoints", () => {
|
||||
await userRepositoryFixture.deleteByEmail(user.email);
|
||||
await userRepositoryFixture.deleteByEmail(oooTestUserEmail);
|
||||
await userRepositoryFixture.deleteByEmail(unrelatedUser.email);
|
||||
await selectedSlotsRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
await selectedSlotRepositoryFixture.deleteByUId(reservedSlot.reservationUid);
|
||||
await bookingsRepositoryFixture.deleteAllBookings(user.id, user.email);
|
||||
await teamRepositoryFixture.delete(team.id);
|
||||
clear();
|
||||
|
||||
@@ -13,11 +13,32 @@ import {
|
||||
ByUsernameAndEventTypeSlug_2024_09_04,
|
||||
ByTeamSlugAndEventTypeSlug_2024_09_04,
|
||||
GetSlotsInput_2024_09_04,
|
||||
GetSlotsInputWithRouting_2024_09_04,
|
||||
ById_2024_09_04_type,
|
||||
ByUsernameAndEventTypeSlug_2024_09_04_type,
|
||||
ByTeamSlugAndEventTypeSlug_2024_09_04_type,
|
||||
} from "@calcom/platform-types";
|
||||
|
||||
export type InternalGetSlotsQuery = {
|
||||
isTeamEvent: boolean;
|
||||
startTime: string;
|
||||
endTime: string;
|
||||
duration?: number;
|
||||
eventTypeId: number;
|
||||
eventTypeSlug: string;
|
||||
usernameList: string[];
|
||||
timeZone: string | undefined;
|
||||
orgSlug: string | null | undefined;
|
||||
rescheduleUid: string | null;
|
||||
};
|
||||
|
||||
export type InternalGetSlotsQueryWithRouting = InternalGetSlotsQuery & {
|
||||
routedTeamMemberIds: number[] | null;
|
||||
skipContactOwner: boolean;
|
||||
teamMemberEmail: string | null;
|
||||
routingFormResponseId: number | undefined;
|
||||
};
|
||||
|
||||
@Injectable()
|
||||
export class SlotsInputService_2024_09_04 {
|
||||
constructor(
|
||||
@@ -30,7 +51,7 @@ export class SlotsInputService_2024_09_04 {
|
||||
private readonly teamsEventTypesRepository: TeamsEventTypesRepository
|
||||
) {}
|
||||
|
||||
async transformGetSlotsQuery(query: GetSlotsInput_2024_09_04) {
|
||||
async transformGetSlotsQuery(query: GetSlotsInput_2024_09_04): Promise<InternalGetSlotsQuery> {
|
||||
const eventType = await this.getEventType(query);
|
||||
if (!eventType) {
|
||||
throw new NotFoundException(`Event Type not found`);
|
||||
@@ -46,10 +67,6 @@ export class SlotsInputService_2024_09_04 {
|
||||
const timeZone = query.timeZone;
|
||||
const orgSlug = "organizationSlug" in query ? query.organizationSlug : null;
|
||||
const rescheduleUid = query.bookingUidToReschedule || null;
|
||||
const routedTeamMemberIds = query.routedTeamMemberIds || null;
|
||||
const skipContactOwner = query.skipContactOwner || false;
|
||||
const teamMemberEmail = query.teamMemberEmail || null;
|
||||
const routingFormResponseId = query.routingFormResponseId || null;
|
||||
|
||||
return {
|
||||
isTeamEvent,
|
||||
@@ -62,10 +79,23 @@ export class SlotsInputService_2024_09_04 {
|
||||
timeZone,
|
||||
orgSlug,
|
||||
rescheduleUid,
|
||||
routedTeamMemberIds,
|
||||
skipContactOwner,
|
||||
teamMemberEmail,
|
||||
routingFormResponseId,
|
||||
};
|
||||
}
|
||||
|
||||
async transformRoutingGetSlotsQuery(
|
||||
query: GetSlotsInputWithRouting_2024_09_04
|
||||
): Promise<InternalGetSlotsQueryWithRouting> {
|
||||
const { routedTeamMemberIds, skipContactOwner, teamMemberEmail, routingFormResponseId, ...baseQuery } =
|
||||
query;
|
||||
|
||||
const baseTransformation = await this.transformGetSlotsQuery(baseQuery);
|
||||
|
||||
return {
|
||||
...baseTransformation,
|
||||
routedTeamMemberIds: routedTeamMemberIds || null,
|
||||
skipContactOwner: skipContactOwner || false,
|
||||
teamMemberEmail: teamMemberEmail || null,
|
||||
routingFormResponseId: routingFormResponseId ?? undefined,
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,397 @@
|
||||
import { EventTypesRepository_2024_06_14 } from "@/ee/event-types/event-types_2024_06_14/event-types.repository";
|
||||
import { AvailableSlotsService } from "@/lib/services/available-slots.service";
|
||||
import { MembershipsRepository } from "@/modules/memberships/memberships.repository";
|
||||
import { MembershipsService } from "@/modules/memberships/services/memberships.service";
|
||||
import { SlotsInputService_2024_09_04 } from "@/modules/slots/slots-2024-09-04/services/slots-input.service";
|
||||
import { SlotsOutputService_2024_09_04 } from "@/modules/slots/slots-2024-09-04/services/slots-output.service";
|
||||
import { SlotsRepository_2024_09_04 } from "@/modules/slots/slots-2024-09-04/slots.repository";
|
||||
import { TeamsRepository } from "@/modules/teams/teams/teams.repository";
|
||||
import { BadRequestException, NotFoundException } from "@nestjs/common";
|
||||
import { Test, TestingModule } from "@nestjs/testing";
|
||||
|
||||
import { SlotsService_2024_09_04 } from "./slots.service";
|
||||
|
||||
describe("SlotsService_2024_09_04", () => {
|
||||
let service: SlotsService_2024_09_04;
|
||||
let eventTypesRepository: EventTypesRepository_2024_06_14;
|
||||
let availableSlotsService: AvailableSlotsService;
|
||||
let slotsInputService: SlotsInputService_2024_09_04;
|
||||
|
||||
beforeEach(async () => {
|
||||
const module: TestingModule = await Test.createTestingModule({
|
||||
providers: [
|
||||
SlotsService_2024_09_04,
|
||||
{
|
||||
provide: SlotsInputService_2024_09_04,
|
||||
useValue: {
|
||||
transformGetSlotsQuery: jest.fn(),
|
||||
transformRoutingGetSlotsQuery: jest.fn(),
|
||||
},
|
||||
},
|
||||
{
|
||||
provide: EventTypesRepository_2024_06_14,
|
||||
useValue: {
|
||||
getEventTypeById: jest.fn(),
|
||||
},
|
||||
},
|
||||
{
|
||||
provide: SlotsRepository_2024_09_04,
|
||||
useValue: {},
|
||||
},
|
||||
{
|
||||
provide: SlotsOutputService_2024_09_04,
|
||||
useValue: {
|
||||
getAvailableSlots: jest.fn().mockResolvedValue({
|
||||
slots: {
|
||||
"2024-01-15": [{ time: "2024-01-15T10:00:00.000Z" }, { time: "2024-01-15T11:00:00.000Z" }],
|
||||
},
|
||||
}),
|
||||
},
|
||||
},
|
||||
{
|
||||
provide: AvailableSlotsService,
|
||||
useValue: {
|
||||
getAvailableSlots: jest.fn(),
|
||||
},
|
||||
},
|
||||
{
|
||||
provide: MembershipsService,
|
||||
useValue: {},
|
||||
},
|
||||
{
|
||||
provide: MembershipsRepository,
|
||||
useValue: {},
|
||||
},
|
||||
{
|
||||
provide: TeamsRepository,
|
||||
useValue: {},
|
||||
},
|
||||
],
|
||||
}).compile();
|
||||
|
||||
service = module.get<SlotsService_2024_09_04>(SlotsService_2024_09_04);
|
||||
slotsInputService = module.get<SlotsInputService_2024_09_04>(SlotsInputService_2024_09_04);
|
||||
eventTypesRepository = module.get<EventTypesRepository_2024_06_14>(EventTypesRepository_2024_06_14);
|
||||
availableSlotsService = module.get<AvailableSlotsService>(AvailableSlotsService);
|
||||
|
||||
jest.clearAllMocks();
|
||||
});
|
||||
|
||||
describe("getAvailableSlotsWithRouting", () => {
|
||||
const sharedTestData = {
|
||||
eventTypeId: 123,
|
||||
start: "2024-01-15T00:00:00.000Z",
|
||||
end: "2024-01-16T00:00:00.000Z",
|
||||
timeZone: "America/New_York",
|
||||
mockEventType: {
|
||||
id: 123,
|
||||
slug: "test-event",
|
||||
teamId: null, // Not a team event
|
||||
length: 30,
|
||||
},
|
||||
mockSlotsResponse: {
|
||||
slots: {},
|
||||
},
|
||||
baseInputQuery: {
|
||||
type: "byEventTypeId" as const,
|
||||
isTeamEvent: false,
|
||||
start: "2024-01-15T00:00:00.000Z",
|
||||
end: "2024-01-16T00:00:00.000Z",
|
||||
duration: undefined,
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
},
|
||||
routingParams: {
|
||||
routedTeamMemberIds: [456, 789],
|
||||
skipContactOwner: true,
|
||||
teamMemberEmail: "test@example.com",
|
||||
routingFormResponseId: 999,
|
||||
},
|
||||
};
|
||||
|
||||
beforeEach(() => {
|
||||
// Setup shared mocks
|
||||
(eventTypesRepository.getEventTypeById as jest.Mock).mockResolvedValue(sharedTestData.mockEventType);
|
||||
(availableSlotsService.getAvailableSlots as jest.Mock).mockResolvedValue(
|
||||
sharedTestData.mockSlotsResponse
|
||||
);
|
||||
});
|
||||
|
||||
it("should call getAvailableSlots with correct routing parameters", async () => {
|
||||
const inputQuery = {
|
||||
...sharedTestData.baseInputQuery,
|
||||
...sharedTestData.routingParams,
|
||||
};
|
||||
|
||||
// Mock the transform method to return the expected transformed query
|
||||
const transformedQuery = {
|
||||
isTeamEvent: false,
|
||||
startTime: "2024-01-15T00:00:00.000Z",
|
||||
endTime: "2024-01-16T23:59:59.000Z",
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
...sharedTestData.routingParams,
|
||||
};
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockResolvedValue(transformedQuery);
|
||||
|
||||
await service.getAvailableSlotsWithRouting({
|
||||
...inputQuery,
|
||||
});
|
||||
|
||||
const { start: _1, end: _2, type: _3, ...queryWithoutStartEndAndType } = sharedTestData.baseInputQuery;
|
||||
|
||||
expect(availableSlotsService.getAvailableSlots).toHaveBeenCalledWith({
|
||||
input: {
|
||||
...queryWithoutStartEndAndType,
|
||||
startTime: "2024-01-15T00:00:00.000Z",
|
||||
endTime: "2024-01-16T23:59:59.000Z",
|
||||
...sharedTestData.routingParams,
|
||||
},
|
||||
ctx: {},
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("getAvailableSlotsWithRouting - Error Scenarios", () => {
|
||||
const baseInputQuery = {
|
||||
type: "byEventTypeId" as const,
|
||||
eventTypeId: 123,
|
||||
start: "2024-01-15T00:00:00.000Z",
|
||||
end: "2024-01-16T00:00:00.000Z",
|
||||
timeZone: "America/New_York",
|
||||
};
|
||||
|
||||
it("should handle when event type is not found", async () => {
|
||||
const notFoundError = new NotFoundException("Event Type not found");
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockRejectedValue(notFoundError);
|
||||
|
||||
await expect(
|
||||
service.getAvailableSlotsWithRouting({
|
||||
...baseInputQuery,
|
||||
teamMemberEmail: "test@example.com",
|
||||
})
|
||||
).rejects.toThrow(NotFoundException);
|
||||
|
||||
expect(slotsInputService.transformRoutingGetSlotsQuery).toHaveBeenCalledWith({
|
||||
...baseInputQuery,
|
||||
teamMemberEmail: "test@example.com",
|
||||
});
|
||||
});
|
||||
|
||||
it("should handle invalid time range error and throw BadRequestException", async () => {
|
||||
const transformedQuery = {
|
||||
isTeamEvent: false,
|
||||
startTime: "2024-01-16T00:00:00.000Z",
|
||||
endTime: "2024-01-15T23:59:59.000Z",
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
routedTeamMemberIds: null,
|
||||
skipContactOwner: false,
|
||||
teamMemberEmail: null,
|
||||
routingFormResponseId: undefined,
|
||||
};
|
||||
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockResolvedValue(transformedQuery);
|
||||
(availableSlotsService.getAvailableSlots as jest.Mock).mockRejectedValue(
|
||||
new Error("Invalid time range given - start time must be before end time")
|
||||
);
|
||||
|
||||
await expect(service.getAvailableSlotsWithRouting(baseInputQuery)).rejects.toThrow(BadRequestException);
|
||||
|
||||
await expect(service.getAvailableSlotsWithRouting(baseInputQuery)).rejects.toThrow(
|
||||
"Invalid time range given - check the 'start' and 'end' query parameters."
|
||||
);
|
||||
});
|
||||
|
||||
it("should re-throw non-time-range errors without modification", async () => {
|
||||
const genericError = new Error("Database connection failed");
|
||||
const transformedQuery = {
|
||||
isTeamEvent: false,
|
||||
startTime: "2024-01-15T00:00:00.000Z",
|
||||
endTime: "2024-01-16T23:59:59.000Z",
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
routedTeamMemberIds: null,
|
||||
skipContactOwner: false,
|
||||
teamMemberEmail: null,
|
||||
routingFormResponseId: undefined,
|
||||
};
|
||||
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockResolvedValue(transformedQuery);
|
||||
(availableSlotsService.getAvailableSlots as jest.Mock).mockRejectedValue(genericError);
|
||||
|
||||
await expect(service.getAvailableSlotsWithRouting(baseInputQuery)).rejects.toThrow(genericError);
|
||||
});
|
||||
|
||||
it("should handle non-Error objects thrown by dependencies", async () => {
|
||||
const transformedQuery = {
|
||||
isTeamEvent: false,
|
||||
startTime: "2024-01-15T00:00:00.000Z",
|
||||
endTime: "2024-01-16T23:59:59.000Z",
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
routedTeamMemberIds: null,
|
||||
skipContactOwner: false,
|
||||
teamMemberEmail: null,
|
||||
routingFormResponseId: undefined,
|
||||
};
|
||||
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockResolvedValue(transformedQuery);
|
||||
const nonErrorObject = { message: "Something went wrong", code: "UNKNOWN_ERROR" };
|
||||
(availableSlotsService.getAvailableSlots as jest.Mock).mockRejectedValue(nonErrorObject);
|
||||
|
||||
await expect(service.getAvailableSlotsWithRouting(baseInputQuery)).rejects.toEqual(nonErrorObject);
|
||||
});
|
||||
});
|
||||
|
||||
describe("getAvailableSlotsWithRouting - Edge Cases", () => {
|
||||
it("should handle null and undefined routing parameters", async () => {
|
||||
const input = {
|
||||
type: "byEventTypeId" as const,
|
||||
eventTypeId: 123,
|
||||
start: "2024-01-15T00:00:00.000Z",
|
||||
end: "2024-01-16T00:00:00.000Z",
|
||||
timeZone: "America/New_York",
|
||||
teamMemberEmail: undefined,
|
||||
routedTeamMemberIds: undefined,
|
||||
skipContactOwner: undefined,
|
||||
routingFormResponseId: undefined,
|
||||
};
|
||||
|
||||
const transformedQuery = {
|
||||
isTeamEvent: false,
|
||||
startTime: "2024-01-15T00:00:00.000Z",
|
||||
endTime: "2024-01-16T23:59:59.000Z",
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
teamMemberEmail: null,
|
||||
routedTeamMemberIds: null,
|
||||
skipContactOwner: false,
|
||||
routingFormResponseId: undefined,
|
||||
};
|
||||
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockResolvedValue(transformedQuery);
|
||||
(availableSlotsService.getAvailableSlots as jest.Mock).mockResolvedValue({ slots: {} });
|
||||
|
||||
await service.getAvailableSlotsWithRouting(input);
|
||||
|
||||
expect(availableSlotsService.getAvailableSlots).toHaveBeenCalledWith({
|
||||
input: expect.objectContaining({
|
||||
teamMemberEmail: null,
|
||||
routedTeamMemberIds: null,
|
||||
skipContactOwner: false,
|
||||
routingFormResponseId: undefined,
|
||||
}),
|
||||
ctx: {},
|
||||
});
|
||||
});
|
||||
|
||||
it("should handle empty routedTeamMemberIds array", async () => {
|
||||
const input = {
|
||||
type: "byEventTypeId" as const,
|
||||
eventTypeId: 123,
|
||||
start: "2024-01-15T00:00:00.000Z",
|
||||
end: "2024-01-16T00:00:00.000Z",
|
||||
timeZone: "America/New_York",
|
||||
routedTeamMemberIds: [],
|
||||
};
|
||||
|
||||
const transformedQuery = {
|
||||
isTeamEvent: false,
|
||||
startTime: "2024-01-15T00:00:00.000Z",
|
||||
endTime: "2024-01-16T23:59:59.000Z",
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
routedTeamMemberIds: [],
|
||||
skipContactOwner: false,
|
||||
teamMemberEmail: null,
|
||||
routingFormResponseId: undefined,
|
||||
};
|
||||
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockResolvedValue(transformedQuery);
|
||||
(availableSlotsService.getAvailableSlots as jest.Mock).mockResolvedValue({ slots: {} });
|
||||
|
||||
await service.getAvailableSlotsWithRouting(input);
|
||||
|
||||
expect(availableSlotsService.getAvailableSlots).toHaveBeenCalledWith({
|
||||
input: expect.objectContaining({
|
||||
routedTeamMemberIds: [],
|
||||
}),
|
||||
ctx: {},
|
||||
});
|
||||
});
|
||||
|
||||
it("should handle all routing parameters being provided", async () => {
|
||||
const input = {
|
||||
type: "byEventTypeId" as const,
|
||||
eventTypeId: 123,
|
||||
start: "2024-01-15T00:00:00.000Z",
|
||||
end: "2024-01-16T00:00:00.000Z",
|
||||
timeZone: "America/New_York",
|
||||
routedTeamMemberIds: [1, 2, 3],
|
||||
skipContactOwner: true,
|
||||
teamMemberEmail: "team@example.com",
|
||||
routingFormResponseId: 999,
|
||||
};
|
||||
|
||||
const transformedQuery = {
|
||||
isTeamEvent: false,
|
||||
startTime: "2024-01-15T00:00:00.000Z",
|
||||
endTime: "2024-01-16T23:59:59.000Z",
|
||||
eventTypeId: 123,
|
||||
eventTypeSlug: "test-event",
|
||||
usernameList: [],
|
||||
timeZone: "America/New_York",
|
||||
orgSlug: null,
|
||||
rescheduleUid: null,
|
||||
routedTeamMemberIds: [1, 2, 3],
|
||||
skipContactOwner: true,
|
||||
teamMemberEmail: "team@example.com",
|
||||
routingFormResponseId: 999,
|
||||
};
|
||||
|
||||
(slotsInputService.transformRoutingGetSlotsQuery as jest.Mock).mockResolvedValue(transformedQuery);
|
||||
(availableSlotsService.getAvailableSlots as jest.Mock).mockResolvedValue({ slots: {} });
|
||||
|
||||
await service.getAvailableSlotsWithRouting(input);
|
||||
|
||||
expect(availableSlotsService.getAvailableSlots).toHaveBeenCalledWith({
|
||||
input: expect.objectContaining({
|
||||
routedTeamMemberIds: [1, 2, 3],
|
||||
skipContactOwner: true,
|
||||
teamMemberEmail: "team@example.com",
|
||||
routingFormResponseId: 999,
|
||||
}),
|
||||
ctx: {},
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -3,7 +3,11 @@ import { AvailableSlotsService } from "@/lib/services/available-slots.service";
|
||||
import { MembershipsRepository } from "@/modules/memberships/memberships.repository";
|
||||
import { MembershipsService } from "@/modules/memberships/services/memberships.service";
|
||||
import { TimeSlots } from "@/modules/slots/slots-2024-04-15/services/slots-output.service";
|
||||
import { SlotsInputService_2024_09_04 } from "@/modules/slots/slots-2024-09-04/services/slots-input.service";
|
||||
import {
|
||||
SlotsInputService_2024_09_04,
|
||||
InternalGetSlotsQuery,
|
||||
InternalGetSlotsQueryWithRouting,
|
||||
} from "@/modules/slots/slots-2024-09-04/services/slots-input.service";
|
||||
import { SlotsOutputService_2024_09_04 } from "@/modules/slots/slots-2024-09-04/services/slots-output.service";
|
||||
import { SlotsRepository_2024_09_04 } from "@/modules/slots/slots-2024-09-04/slots.repository";
|
||||
import { TeamsRepository } from "@/modules/teams/teams/teams.repository";
|
||||
@@ -18,8 +22,13 @@ import {
|
||||
import { DateTime } from "luxon";
|
||||
import { z } from "zod";
|
||||
|
||||
import { GetSlotsInput_2024_09_04, ReserveSlotInput_2024_09_04 } from "@calcom/platform-types";
|
||||
import { Booking, EventType } from "@calcom/prisma/client";
|
||||
import { SlotFormat } from "@calcom/platform-enums";
|
||||
import {
|
||||
GetSlotsInput_2024_09_04,
|
||||
GetSlotsInputWithRouting_2024_09_04,
|
||||
ReserveSlotInput_2024_09_04,
|
||||
} from "@calcom/platform-types";
|
||||
import { EventType } from "@calcom/prisma/client";
|
||||
|
||||
const eventTypeMetadataSchema = z
|
||||
.object({
|
||||
@@ -29,6 +38,7 @@ const eventTypeMetadataSchema = z
|
||||
|
||||
const DEFAULT_RESERVATION_DURATION = 5;
|
||||
|
||||
type InternalSlotsQuery = InternalGetSlotsQuery | InternalGetSlotsQueryWithRouting;
|
||||
@Injectable()
|
||||
export class SlotsService_2024_09_04 {
|
||||
constructor(
|
||||
@@ -42,21 +52,18 @@ export class SlotsService_2024_09_04 {
|
||||
private readonly availableSlotsService: AvailableSlotsService
|
||||
) {}
|
||||
|
||||
async getAvailableSlots(query: GetSlotsInput_2024_09_04) {
|
||||
private async fetchAndFormatSlots(queryTransformed: InternalSlotsQuery, format?: SlotFormat) {
|
||||
try {
|
||||
const queryTransformed = await this.slotsInputService.transformGetSlotsQuery(query);
|
||||
const availableSlots: TimeSlots = await this.availableSlotsService.getAvailableSlots({
|
||||
input: {
|
||||
...queryTransformed,
|
||||
routingFormResponseId: queryTransformed.routingFormResponseId ?? undefined,
|
||||
},
|
||||
input: queryTransformed,
|
||||
ctx: {},
|
||||
});
|
||||
|
||||
const formatted = await this.slotsOutputService.getAvailableSlots(
|
||||
availableSlots,
|
||||
queryTransformed.eventTypeId,
|
||||
queryTransformed.duration,
|
||||
query.format,
|
||||
format,
|
||||
queryTransformed.timeZone
|
||||
);
|
||||
|
||||
@@ -73,6 +80,16 @@ export class SlotsService_2024_09_04 {
|
||||
}
|
||||
}
|
||||
|
||||
async getAvailableSlots(query: GetSlotsInput_2024_09_04) {
|
||||
const queryTransformed = await this.slotsInputService.transformGetSlotsQuery(query);
|
||||
return this.fetchAndFormatSlots(queryTransformed, query.format);
|
||||
}
|
||||
|
||||
async getAvailableSlotsWithRouting(query: GetSlotsInputWithRouting_2024_09_04) {
|
||||
const queryTransformed = await this.slotsInputService.transformRoutingGetSlotsQuery(query);
|
||||
return this.fetchAndFormatSlots(queryTransformed, query.format);
|
||||
}
|
||||
|
||||
async reserveSlot(input: ReserveSlotInput_2024_09_04, authUserId?: number) {
|
||||
if (input.reservationDuration && !authUserId) {
|
||||
throw new UnauthorizedException(
|
||||
|
||||
@@ -1,10 +1,12 @@
|
||||
import { JwtModule } from "@/modules/jwt/jwt.module";
|
||||
import { PrismaModule } from "@/modules/prisma/prisma.module";
|
||||
import { TokensRepository } from "@/modules/tokens/tokens.repository";
|
||||
import { TokensService } from "@/modules/tokens/tokens.service";
|
||||
import { Module } from "@nestjs/common";
|
||||
|
||||
@Module({
|
||||
imports: [PrismaModule],
|
||||
providers: [TokensRepository],
|
||||
exports: [TokensRepository],
|
||||
imports: [PrismaModule, JwtModule],
|
||||
providers: [TokensRepository, TokensService],
|
||||
exports: [TokensRepository, TokensService],
|
||||
})
|
||||
export class TokensModule {}
|
||||
|
||||
@@ -0,0 +1,38 @@
|
||||
import { Injectable, InternalServerErrorException } from "@nestjs/common";
|
||||
import { Logger } from "@nestjs/common";
|
||||
import { ConfigService } from "@nestjs/config";
|
||||
import * as jwt from "jsonwebtoken";
|
||||
|
||||
type OAuthTokenPayload = {
|
||||
userId?: number;
|
||||
teamId?: number;
|
||||
scope: string[];
|
||||
token_type: string;
|
||||
};
|
||||
|
||||
@Injectable()
|
||||
export class TokensService {
|
||||
private readonly logger = new Logger("TokensService");
|
||||
|
||||
constructor(private readonly config: ConfigService) {}
|
||||
|
||||
getDecodedThirdPartyAccessToken(token: string): OAuthTokenPayload | null {
|
||||
const encryptionKey = this.config.get<string>("CALENDSO_ENCRYPTION_KEY");
|
||||
if (!encryptionKey) {
|
||||
throw new InternalServerErrorException("CALENDSO_ENCRYPTION_KEY environment variable is not set.");
|
||||
}
|
||||
|
||||
let decodedToken: OAuthTokenPayload;
|
||||
try {
|
||||
decodedToken = jwt.verify(token, encryptionKey) as OAuthTokenPayload;
|
||||
} catch (e) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if (!decodedToken || decodedToken.token_type !== "Access Token") {
|
||||
return null;
|
||||
}
|
||||
|
||||
return decodedToken;
|
||||
}
|
||||
}
|
||||
@@ -15705,6 +15705,10 @@
|
||||
"redirectUrlOnExit": {
|
||||
"type": "object",
|
||||
"description": "URL to which participants are redirected when they exit the call"
|
||||
},
|
||||
"enableAutomaticRecordingForOrganizer": {
|
||||
"type": "boolean",
|
||||
"description": "If true, enables the automatic recording for the event when organizer joins the call"
|
||||
}
|
||||
}
|
||||
},
|
||||
@@ -25010,7 +25014,7 @@
|
||||
"example": 123
|
||||
},
|
||||
"routing": {
|
||||
"description": "The routing information.",
|
||||
"description": "The routing information that could be passed as is to the booking API.",
|
||||
"example": {
|
||||
"eventTypeId": 123,
|
||||
"routing": {
|
||||
|
||||
+2
-2
@@ -3,11 +3,11 @@ import { PrismaWriteService } from "@/modules/prisma/prisma-write.service";
|
||||
import { TestingModule } from "@nestjs/testing";
|
||||
import { SelectedSlots } from "@prisma/client";
|
||||
|
||||
export class SelectedSlotsRepositoryFixture {
|
||||
export class SelectedSlotRepositoryFixture {
|
||||
private prismaReadClient: PrismaReadService["prisma"];
|
||||
private prismaWriteClient: PrismaWriteService["prisma"];
|
||||
|
||||
constructor(private readonly module: TestingModule) {
|
||||
constructor(module: TestingModule) {
|
||||
this.prismaReadClient = module.get(PrismaReadService).prisma;
|
||||
this.prismaWriteClient = module.get(PrismaWriteService).prisma;
|
||||
}
|
||||
@@ -26,7 +26,8 @@
|
||||
"@calcom/platform-libraries/app-store": ["../../../packages/platform/libraries/app-store.ts"],
|
||||
"@calcom/platform-libraries/workflows": ["../../../packages/platform/libraries/workflows.ts"],
|
||||
"@calcom/platform-libraries/conferencing": ["../../../packages/platform/libraries/conferencing.ts"],
|
||||
"@calcom/platform-libraries/repositories": ["../../../packages/platform/libraries/repositories.ts"]
|
||||
"@calcom/platform-libraries/repositories": ["../../../packages/platform/libraries/repositories.ts"],
|
||||
"@calcom/platform-libraries/bookings": ["../../../packages/platform/libraries/bookings.ts"]
|
||||
},
|
||||
"incremental": true,
|
||||
"skipLibCheck": true,
|
||||
|
||||
@@ -34,6 +34,6 @@
|
||||
"eslint-config-next": "15.1.6",
|
||||
"postcss": "^8",
|
||||
"tailwindcss": "^3.4.1",
|
||||
"typescript": "^5"
|
||||
"typescript": "^5.9.0-beta"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -4,7 +4,7 @@ import PageWrapper from "@components/PageWrapperAppDir";
|
||||
|
||||
export default async function BookingPageWrapperLayout({ children }: { children: React.ReactNode }) {
|
||||
const h = await headers();
|
||||
const nonce = h.get("x-nonce") ?? undefined;
|
||||
const nonce = h.get("x-csp-nonce") ?? undefined;
|
||||
|
||||
return (
|
||||
<>
|
||||
|
||||
@@ -7,6 +7,7 @@ import { cookies, headers } from "next/headers";
|
||||
import { getOrgFullOrigin } from "@calcom/features/ee/organizations/lib/orgDomains";
|
||||
import { FeaturesRepository } from "@calcom/features/flags/features.repository";
|
||||
import { loadTranslations } from "@calcom/lib/server/i18n";
|
||||
import { prisma } from "@calcom/prisma";
|
||||
|
||||
import { buildLegacyCtx, decodeParams } from "@lib/buildLegacyCtx";
|
||||
import { getServerSideProps } from "@lib/team/[slug]/[type]/getServerSideProps";
|
||||
@@ -17,7 +18,7 @@ import type { PageProps as LegacyPageProps } from "~/team/type-view";
|
||||
import CachedTeamBooker, { generateMetadata as generateCachedMetadata } from "./pageWithCachedData";
|
||||
|
||||
async function isCachedTeamBookingEnabled(searchParams: SearchParams): Promise<boolean> {
|
||||
const featuresRepository = new FeaturesRepository();
|
||||
const featuresRepository = new FeaturesRepository(prisma);
|
||||
const isGloballyEnabled = await featuresRepository.checkIfFeatureIsEnabledGlobally(
|
||||
"team-booking-page-cache"
|
||||
);
|
||||
|
||||
@@ -102,7 +102,7 @@ export async function getEnrichedEventType({
|
||||
}
|
||||
|
||||
export async function shouldUseApiV2ForTeamSlots(teamId: number): Promise<boolean> {
|
||||
const featureRepo = new FeaturesRepository();
|
||||
const featureRepo = new FeaturesRepository(prisma);
|
||||
const teamHasApiV2Route = await featureRepo.checkIfTeamHasFeature(teamId, "use-api-v2-for-team-slots");
|
||||
const useApiV2 = teamHasApiV2Route && Boolean(process.env.NEXT_PUBLIC_API_V2_URL);
|
||||
|
||||
@@ -122,12 +122,14 @@ export async function getCRMData(
|
||||
const crmContactOwnerEmail = query["cal.crmContactOwnerEmail"];
|
||||
const crmContactOwnerRecordType = query["cal.crmContactOwnerRecordType"];
|
||||
const crmAppSlugParam = query["cal.crmAppSlug"];
|
||||
const crmRecordIdParam = query["cal.crmRecordId"];
|
||||
|
||||
let teamMemberEmail = Array.isArray(crmContactOwnerEmail) ? crmContactOwnerEmail[0] : crmContactOwnerEmail;
|
||||
let crmOwnerRecordType = Array.isArray(crmContactOwnerRecordType)
|
||||
? crmContactOwnerRecordType[0]
|
||||
: crmContactOwnerRecordType;
|
||||
let crmAppSlug = Array.isArray(crmAppSlugParam) ? crmAppSlugParam[0] : crmAppSlugParam;
|
||||
let crmRecordId = Array.isArray(crmRecordIdParam) ? crmRecordIdParam[0] : crmRecordIdParam;
|
||||
|
||||
if (!teamMemberEmail || !crmOwnerRecordType || !crmAppSlug) {
|
||||
const { getTeamMemberEmailForResponseOrContactUsingUrlQuery } = await import(
|
||||
@@ -137,6 +139,7 @@ export async function getCRMData(
|
||||
email,
|
||||
recordType,
|
||||
crmAppSlug: crmAppSlugQuery,
|
||||
recordId: crmRecordIdQuery,
|
||||
} = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
||||
query,
|
||||
eventData,
|
||||
@@ -145,11 +148,13 @@ export async function getCRMData(
|
||||
teamMemberEmail = email ?? undefined;
|
||||
crmOwnerRecordType = recordType ?? undefined;
|
||||
crmAppSlug = crmAppSlugQuery ?? undefined;
|
||||
crmRecordId = crmRecordIdQuery ?? undefined;
|
||||
}
|
||||
|
||||
return {
|
||||
teamMemberEmail,
|
||||
crmOwnerRecordType,
|
||||
crmAppSlug,
|
||||
crmRecordId,
|
||||
};
|
||||
}
|
||||
|
||||
@@ -5,7 +5,7 @@ import { unstable_cache } from "next/cache";
|
||||
import { checkAdminOrOwner } from "@calcom/features/auth/lib/checkAdminOrOwner";
|
||||
import { TeamsListing } from "@calcom/features/ee/teams/components/TeamsListing";
|
||||
import { TeamRepository } from "@calcom/lib/server/repository/team";
|
||||
import { TeamService } from "@calcom/lib/server/service/team";
|
||||
import { TeamService } from "@calcom/lib/server/service/teamService";
|
||||
import prisma from "@calcom/prisma";
|
||||
|
||||
import { TRPCError } from "@trpc/server";
|
||||
|
||||
@@ -1,9 +1,12 @@
|
||||
import { createRouterCaller } from "app/_trpc/context";
|
||||
import type { PageProps } from "app/_types";
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { redirect } from "next/navigation";
|
||||
import { z } from "zod";
|
||||
|
||||
import { AppCategories } from "@calcom/prisma/enums";
|
||||
import { appsRouter } from "@calcom/trpc/server/routers/viewer/apps/_router";
|
||||
import { calendarsRouter } from "@calcom/trpc/server/routers/viewer/calendars/_router";
|
||||
|
||||
import InstalledApps from "~/apps/installed/[category]/installed-category-view";
|
||||
|
||||
@@ -28,7 +31,24 @@ const InstalledAppsWrapper = async ({ params }: PageProps) => {
|
||||
redirect("/apps/installed/calendar");
|
||||
}
|
||||
|
||||
return <InstalledApps category={parsedParams.data.category} />;
|
||||
const [calendarsCaller, appsCaller] = await Promise.all([
|
||||
createRouterCaller(calendarsRouter),
|
||||
createRouterCaller(appsRouter),
|
||||
]);
|
||||
|
||||
const connectedCalendars = await calendarsCaller.connectedCalendars();
|
||||
const installedCalendars = await appsCaller.integrations({
|
||||
variant: "calendar",
|
||||
onlyInstalled: true,
|
||||
});
|
||||
|
||||
return (
|
||||
<InstalledApps
|
||||
connectedCalendars={connectedCalendars}
|
||||
installedCalendars={installedCalendars}
|
||||
category={parsedParams.data.category}
|
||||
/>
|
||||
);
|
||||
};
|
||||
|
||||
export default InstalledAppsWrapper;
|
||||
|
||||
@@ -4,11 +4,12 @@ import { notFound } from "next/navigation";
|
||||
import { CTA_CONTAINER_CLASS_NAME } from "@calcom/features/data-table/lib/utils";
|
||||
import { FeaturesRepository } from "@calcom/features/flags/features.repository";
|
||||
import Shell from "@calcom/features/shell/Shell";
|
||||
import { prisma } from "@calcom/prisma";
|
||||
|
||||
import UpgradeTipWrapper from "./UpgradeTipWrapper";
|
||||
|
||||
export default async function InsightsLayout({ children }: { children: React.ReactNode }) {
|
||||
const featuresRepository = new FeaturesRepository();
|
||||
const featuresRepository = new FeaturesRepository(prisma);
|
||||
const insightsEnabled = await featuresRepository.checkIfFeatureIsEnabledGlobally("insights");
|
||||
|
||||
if (!insightsEnabled) {
|
||||
|
||||
@@ -5,7 +5,7 @@ import PageWrapper from "@components/PageWrapperAppDir";
|
||||
|
||||
export default async function PageWrapperLayout({ children }: { children: React.ReactNode }) {
|
||||
const h = await headers();
|
||||
const nonce = h.get("x-nonce") ?? undefined;
|
||||
const nonce = h.get("x-csp-nonce") ?? undefined;
|
||||
const headScript = process.env.NEXT_PUBLIC_HEAD_SCRIPTS;
|
||||
const bodyScript = process.env.NEXT_PUBLIC_BODY_SCRIPTS;
|
||||
|
||||
|
||||
+60
@@ -0,0 +1,60 @@
|
||||
"use client";
|
||||
|
||||
import { ChartCard } from "@calcom/features/insights/components/ChartCard";
|
||||
import { BookingsByHourChartContent } from "@calcom/features/insights/components/booking/BookingsByHourChart";
|
||||
import { useLocale } from "@calcom/lib/hooks/useLocale";
|
||||
|
||||
// Sample data for playground testing
|
||||
const sampleBookingsByHourStats = [
|
||||
{ hour: 0, count: 4 },
|
||||
{ hour: 1, count: 10 },
|
||||
{ hour: 2, count: 3 },
|
||||
{ hour: 3, count: 12 },
|
||||
{ hour: 4, count: 3 },
|
||||
{ hour: 5, count: 7 },
|
||||
{ hour: 6, count: 6 },
|
||||
{ hour: 7, count: 4 },
|
||||
{ hour: 8, count: 9 },
|
||||
{ hour: 9, count: 7 },
|
||||
{ hour: 10, count: 6 },
|
||||
{ hour: 11, count: 5 },
|
||||
{ hour: 12, count: 8 },
|
||||
{ hour: 13, count: 5 },
|
||||
{ hour: 14, count: 9 },
|
||||
{ hour: 15, count: 9 },
|
||||
{ hour: 16, count: 4 },
|
||||
{ hour: 17, count: 5 },
|
||||
{ hour: 18, count: 4 },
|
||||
{ hour: 19, count: 6 },
|
||||
{ hour: 20, count: 6 },
|
||||
{ hour: 21, count: 12 },
|
||||
{ hour: 22, count: 4 },
|
||||
{ hour: 23, count: 10 },
|
||||
];
|
||||
|
||||
export default function BookingsByHourPlayground() {
|
||||
const { t } = useLocale();
|
||||
return (
|
||||
<div className="space-y-6 p-6">
|
||||
<div className="mb-6">
|
||||
<h1 className="text-3xl font-bold">Bookings by Hour Playground</h1>
|
||||
<p className="mt-2 text-gray-600">
|
||||
This page demonstrates the BookingsByHourChartContent component with sample data.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<div className="max-w-4xl">
|
||||
<ChartCard title={t("bookings_by_hour")}>
|
||||
<BookingsByHourChartContent data={sampleBookingsByHourStats} />
|
||||
</ChartCard>
|
||||
</div>
|
||||
|
||||
<div className="mt-8 rounded-lg bg-gray-50 p-4">
|
||||
<h2 className="mb-2 text-lg font-semibold">Sample Data Used:</h2>
|
||||
<pre className="overflow-auto text-sm text-gray-700">
|
||||
{JSON.stringify(sampleBookingsByHourStats, null, 2)}
|
||||
</pre>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -5,6 +5,10 @@ const LINKS = [
|
||||
title: "Routing Funnel",
|
||||
href: "/settings/admin/playground/routing-funnel",
|
||||
},
|
||||
{
|
||||
title: "Bookings by Hour",
|
||||
href: "/settings/admin/playground/bookings-by-hour",
|
||||
},
|
||||
];
|
||||
|
||||
export default function Page() {
|
||||
|
||||
+4
-1
@@ -1,7 +1,10 @@
|
||||
"use client";
|
||||
|
||||
import { ChartCard } from "@calcom/features/insights/components/ChartCard";
|
||||
import { RoutingFunnelContent, legend } from "@calcom/features/insights/components/RoutingFunnelContent";
|
||||
import {
|
||||
RoutingFunnelContent,
|
||||
legend,
|
||||
} from "@calcom/features/insights/components/routing/RoutingFunnelContent";
|
||||
import { useLocale } from "@calcom/lib/hooks/useLocale";
|
||||
|
||||
// Random sample data for playground testing
|
||||
|
||||
+53
-6
@@ -92,7 +92,7 @@ const getTabs = (orgBranding: OrganizationBranding | null) => {
|
||||
? [
|
||||
{
|
||||
name: "members",
|
||||
href: `${WEBAPP_URL}/settings/organizations/i/members`,
|
||||
href: `${WEBAPP_URL}/settings/organizations/${orgBranding.slug}/members`,
|
||||
isExternalLink: true,
|
||||
},
|
||||
]
|
||||
@@ -184,9 +184,11 @@ const organizationAdminKeys = [
|
||||
const useTabs = ({
|
||||
isDelegationCredentialEnabled,
|
||||
isPbacEnabled,
|
||||
canViewRoles,
|
||||
}: {
|
||||
isDelegationCredentialEnabled: boolean;
|
||||
isPbacEnabled: boolean;
|
||||
canViewRoles?: boolean;
|
||||
}) => {
|
||||
const session = useSession();
|
||||
const { data: user } = trpc.viewer.me.get.useQuery({ includePasswordAdded: true });
|
||||
@@ -223,8 +225,9 @@ const useTabs = ({
|
||||
});
|
||||
}
|
||||
|
||||
// Add pbac menu item only if feature flag is enabled
|
||||
if (isPbacEnabled) {
|
||||
// Add pbac menu item only if feature flag is enabled AND user has permission to view roles
|
||||
// This prevents showing the menu item when user has no organization permissions
|
||||
if (isPbacEnabled && canViewRoles) {
|
||||
newArray.push({
|
||||
name: "roles_and_permissions",
|
||||
href: "/settings/organizations/roles",
|
||||
@@ -291,9 +294,39 @@ interface SettingsSidebarContainerProps {
|
||||
navigationIsOpenedOnMobile?: boolean;
|
||||
bannersHeight?: number;
|
||||
teamFeatures?: Record<number, TeamFeatures>;
|
||||
canViewRoles?: boolean;
|
||||
}
|
||||
|
||||
const TeamListCollapsible = () => {
|
||||
const TeamRolesNavItem = ({
|
||||
team,
|
||||
teamFeatures,
|
||||
}: {
|
||||
team: { id: number; parentId?: number | null };
|
||||
teamFeatures?: Record<number, TeamFeatures>;
|
||||
}) => {
|
||||
const { t } = useLocale();
|
||||
|
||||
// Always call the hook first (Rules of Hooks)
|
||||
const isPbacEnabled = useIsFeatureEnabledForTeam({
|
||||
teamFeatures,
|
||||
teamId: team.parentId || 0, // Use 0 as fallback when no parentId
|
||||
feature: "pbac",
|
||||
});
|
||||
|
||||
// Only show for sub-teams (teams with parentId) AND when parent has PBAC enabled
|
||||
if (!team.parentId || !isPbacEnabled) return null;
|
||||
|
||||
return (
|
||||
<VerticalTabItem
|
||||
name={t("roles_and_permissions")}
|
||||
href={`/settings/teams/${team.id}/roles`}
|
||||
textClassNames="px-3 text-emphasis font-medium text-sm"
|
||||
disableChevron
|
||||
/>
|
||||
);
|
||||
};
|
||||
|
||||
const TeamListCollapsible = ({ teamFeatures }: { teamFeatures?: Record<number, TeamFeatures> }) => {
|
||||
const { data: teams } = trpc.viewer.teams.list.useQuery();
|
||||
const { t } = useLocale();
|
||||
const [teamMenuState, setTeamMenuState] =
|
||||
@@ -402,6 +435,8 @@ const TeamListCollapsible = () => {
|
||||
textClassNames="px-3 text-emphasis font-medium text-sm"
|
||||
disableChevron
|
||||
/>
|
||||
{/* Show roles only for sub-teams with PBAC-enabled parent */}
|
||||
<TeamRolesNavItem team={team} teamFeatures={teamFeatures} />
|
||||
{(checkAdminOrOwner(team.role) ||
|
||||
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
|
||||
// @ts-ignore this exists wtf?
|
||||
@@ -452,6 +487,7 @@ const SettingsSidebarContainer = ({
|
||||
navigationIsOpenedOnMobile,
|
||||
bannersHeight,
|
||||
teamFeatures,
|
||||
canViewRoles,
|
||||
}: SettingsSidebarContainerProps) => {
|
||||
const searchParams = useCompatSearchParams();
|
||||
const orgBranding = useOrgBranding();
|
||||
@@ -481,6 +517,7 @@ const SettingsSidebarContainer = ({
|
||||
const tabsWithPermissions = useTabs({
|
||||
isDelegationCredentialEnabled,
|
||||
isPbacEnabled,
|
||||
canViewRoles,
|
||||
});
|
||||
|
||||
const { data: otherTeams } = trpc.viewer.organizations.listOtherTeams.useQuery(undefined, {
|
||||
@@ -588,7 +625,7 @@ const SettingsSidebarContainer = ({
|
||||
</Skeleton>
|
||||
</div>
|
||||
</Link>
|
||||
<TeamListCollapsible />
|
||||
<TeamListCollapsible teamFeatures={teamFeatures} />
|
||||
{(!orgBranding?.id || isOrgAdminOrOwner) && (
|
||||
<VerticalTabItem
|
||||
name={t("add_a_team")}
|
||||
@@ -755,9 +792,15 @@ export type SettingsLayoutProps = {
|
||||
children: React.ReactNode;
|
||||
containerClassName?: string;
|
||||
teamFeatures?: Record<number, TeamFeatures>;
|
||||
canViewRoles?: boolean;
|
||||
} & ComponentProps<typeof Shell>;
|
||||
|
||||
export default function SettingsLayoutAppDirClient({ children, teamFeatures, ...rest }: SettingsLayoutProps) {
|
||||
export default function SettingsLayoutAppDirClient({
|
||||
children,
|
||||
teamFeatures,
|
||||
canViewRoles,
|
||||
...rest
|
||||
}: SettingsLayoutProps) {
|
||||
const pathname = usePathname();
|
||||
const state = useState(false);
|
||||
const [sideContainerOpen, setSideContainerOpen] = state;
|
||||
@@ -790,6 +833,7 @@ export default function SettingsLayoutAppDirClient({ children, teamFeatures, ...
|
||||
sideContainerOpen={sideContainerOpen}
|
||||
setSideContainerOpen={setSideContainerOpen}
|
||||
teamFeatures={teamFeatures}
|
||||
canViewRoles={canViewRoles}
|
||||
/>
|
||||
}
|
||||
drawerState={state}
|
||||
@@ -812,6 +856,7 @@ type SidebarContainerElementProps = {
|
||||
bannersHeight?: number;
|
||||
setSideContainerOpen: React.Dispatch<React.SetStateAction<boolean>>;
|
||||
teamFeatures?: Record<number, TeamFeatures>;
|
||||
canViewRoles?: boolean;
|
||||
};
|
||||
|
||||
const SidebarContainerElement = ({
|
||||
@@ -819,6 +864,7 @@ const SidebarContainerElement = ({
|
||||
bannersHeight,
|
||||
setSideContainerOpen,
|
||||
teamFeatures,
|
||||
canViewRoles,
|
||||
}: SidebarContainerElementProps) => {
|
||||
const { t } = useLocale();
|
||||
return (
|
||||
@@ -835,6 +881,7 @@ const SidebarContainerElement = ({
|
||||
navigationIsOpenedOnMobile={sideContainerOpen}
|
||||
bannersHeight={bannersHeight}
|
||||
teamFeatures={teamFeatures}
|
||||
canViewRoles={canViewRoles}
|
||||
/>
|
||||
</>
|
||||
);
|
||||
|
||||
+2
-2
@@ -5,7 +5,7 @@ import { redirect } from "next/navigation";
|
||||
|
||||
import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
|
||||
import { APP_NAME } from "@calcom/lib/constants";
|
||||
import { ApiKeyRepository } from "@calcom/lib/server/repository/apiKey";
|
||||
import { PrismaApiKeyRepository } from "@calcom/lib/server/repository/PrismaApiKeyRepository";
|
||||
|
||||
import { buildLegacyRequest } from "@lib/buildLegacyCtx";
|
||||
|
||||
@@ -22,7 +22,7 @@ export const generateMetadata = async () =>
|
||||
|
||||
const getCachedApiKeys = unstable_cache(
|
||||
async (userId: number) => {
|
||||
return await ApiKeyRepository.findApiKeysFromUserId({ userId });
|
||||
return await PrismaApiKeyRepository.findApiKeysFromUserId({ userId });
|
||||
},
|
||||
undefined,
|
||||
{ revalidate: 3600, tags: ["viewer.apiKeys.list"] } // Cache for 1 hour
|
||||
|
||||
+3
-3
@@ -1,7 +1,7 @@
|
||||
"use server";
|
||||
|
||||
import { revalidatePath } from "next/cache";
|
||||
import { revalidateTag } from "next/cache";
|
||||
|
||||
export async function revalidateWebhooksList() {
|
||||
revalidatePath("/settings/developer/webhooks");
|
||||
export async function revalidateWebhooksListGetByViewer() {
|
||||
revalidateTag("viewer.webhook.getByViewer");
|
||||
}
|
||||
|
||||
+16
-4
@@ -1,13 +1,13 @@
|
||||
import { createRouterCaller } from "app/_trpc/context";
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { unstable_cache } from "next/cache";
|
||||
import { cookies, headers } from "next/headers";
|
||||
import { redirect } from "next/navigation";
|
||||
|
||||
import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
|
||||
import WebhooksView from "@calcom/features/webhooks/pages/webhooks-view";
|
||||
import { APP_NAME } from "@calcom/lib/constants";
|
||||
import { WebhookRepository } from "@calcom/lib/server/repository/webhook";
|
||||
import { UserPermissionRole } from "@calcom/prisma/enums";
|
||||
import { webhookRouter } from "@calcom/trpc/server/routers/viewer/webhook/_router";
|
||||
|
||||
import { buildLegacyRequest } from "@lib/buildLegacyCtx";
|
||||
|
||||
@@ -20,6 +20,17 @@ export const generateMetadata = async () =>
|
||||
"/settings/developer/webhooks"
|
||||
);
|
||||
|
||||
const getCachedWebhooksList = unstable_cache(
|
||||
async ({ userId, userRole }: { userId: number; userRole?: UserPermissionRole }) => {
|
||||
return await WebhookRepository.getAllWebhooksByUserId({
|
||||
userId,
|
||||
userRole,
|
||||
});
|
||||
},
|
||||
undefined,
|
||||
{ revalidate: 3600, tags: ["viewer.webhook.getByViewer"] }
|
||||
);
|
||||
|
||||
const WebhooksViewServerWrapper = async () => {
|
||||
const session = await getServerSession({ req: buildLegacyRequest(await headers(), await cookies()) });
|
||||
if (!session?.user?.id) {
|
||||
@@ -27,8 +38,9 @@ const WebhooksViewServerWrapper = async () => {
|
||||
}
|
||||
|
||||
const isAdmin = session.user.role === UserPermissionRole.ADMIN;
|
||||
const caller = await createRouterCaller(webhookRouter);
|
||||
const data = await caller.getByViewer();
|
||||
const userRole = session.user.role !== "INACTIVE_ADMIN" ? session.user.role : undefined;
|
||||
|
||||
const data = await getCachedWebhooksList({ userId: session.user.id, userRole });
|
||||
|
||||
return <WebhooksView data={data} isAdmin={isAdmin} />;
|
||||
};
|
||||
|
||||
+7
@@ -0,0 +1,7 @@
|
||||
"use server";
|
||||
|
||||
import { revalidateTag } from "next/cache";
|
||||
|
||||
export async function revalidateWebhookById(id: string) {
|
||||
revalidateTag(`viewer.webhook.get:${id}`);
|
||||
}
|
||||
+14
-1
@@ -1,5 +1,6 @@
|
||||
import type { PageProps } from "app/_types";
|
||||
import { getTranslate, _generateMetadata } from "app/_utils";
|
||||
import { unstable_cache } from "next/cache";
|
||||
|
||||
import SettingsHeader from "@calcom/features/settings/appDir/SettingsHeader";
|
||||
import { EditWebhookView } from "@calcom/features/webhooks/pages/webhook-edit-view";
|
||||
@@ -15,12 +16,24 @@ export const generateMetadata = async ({ params }: { params: Promise<{ id: strin
|
||||
`/settings/developer/webhooks/${(await params).id}`
|
||||
);
|
||||
|
||||
const getCachedWebhook = (id?: string) => {
|
||||
const fn = unstable_cache(
|
||||
async () => {
|
||||
return await WebhookRepository.findByWebhookId(id);
|
||||
},
|
||||
undefined,
|
||||
{ revalidate: 3600, tags: [`viewer.webhook.get:${id}`] }
|
||||
);
|
||||
|
||||
return fn();
|
||||
};
|
||||
|
||||
const Page = async ({ params: _params }: PageProps) => {
|
||||
const t = await getTranslate();
|
||||
const params = await _params;
|
||||
const id = typeof params?.id === "string" ? params.id : undefined;
|
||||
|
||||
const webhook = await WebhookRepository.findByWebhookId(id);
|
||||
const webhook = await getCachedWebhook(id);
|
||||
|
||||
return (
|
||||
<SettingsHeader
|
||||
|
||||
+7
@@ -0,0 +1,7 @@
|
||||
"use server";
|
||||
|
||||
import { revalidateTag } from "next/cache";
|
||||
|
||||
export async function revalidateWebhookList() {
|
||||
revalidateTag("viewer.webhook.list");
|
||||
}
|
||||
+22
-6
@@ -1,10 +1,16 @@
|
||||
import { createRouterCaller } from "app/_trpc/context";
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { unstable_cache } from "next/cache";
|
||||
import { cookies, headers } from "next/headers";
|
||||
import { redirect } from "next/navigation";
|
||||
|
||||
import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
|
||||
import { NewWebhookView } from "@calcom/features/webhooks/pages/webhook-new-view";
|
||||
import { APP_NAME } from "@calcom/lib/constants";
|
||||
import { WebhookRepository } from "@calcom/lib/server/repository/webhook";
|
||||
import { appsRouter } from "@calcom/trpc/server/routers/viewer/apps/_router";
|
||||
import { webhookRouter } from "@calcom/trpc/server/routers/viewer/webhook/_router";
|
||||
|
||||
import { buildLegacyRequest } from "@lib/buildLegacyCtx";
|
||||
|
||||
export const generateMetadata = async () =>
|
||||
await _generateMetadata(
|
||||
@@ -15,15 +21,25 @@ export const generateMetadata = async () =>
|
||||
"/settings/developer/webhooks/new"
|
||||
);
|
||||
|
||||
const getCachedWebhooksList = unstable_cache(
|
||||
async ({ userId }: { userId: number }) => {
|
||||
return await WebhookRepository.findWebhooksByFilters({ userId });
|
||||
},
|
||||
undefined,
|
||||
{ revalidate: 3600, tags: ["viewer.webhook.list"] }
|
||||
);
|
||||
|
||||
const Page = async () => {
|
||||
const [appsCaller, webhookCaller] = await Promise.all([
|
||||
createRouterCaller(appsRouter),
|
||||
createRouterCaller(webhookRouter),
|
||||
]);
|
||||
const session = await getServerSession({ req: buildLegacyRequest(await headers(), await cookies()) });
|
||||
if (!session?.user?.id) {
|
||||
redirect("/auth/login");
|
||||
}
|
||||
|
||||
const appsCaller = await createRouterCaller(appsRouter);
|
||||
|
||||
const [installedApps, webhooks] = await Promise.all([
|
||||
appsCaller.integrations({ variant: "other", onlyInstalled: true }),
|
||||
webhookCaller.list(),
|
||||
getCachedWebhooksList({ userId: session.user.id }),
|
||||
]);
|
||||
|
||||
return <NewWebhookView webhooks={webhooks} installedApps={installedApps} />;
|
||||
|
||||
@@ -6,6 +6,10 @@ import React from "react";
|
||||
import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
|
||||
import type { TeamFeatures } from "@calcom/features/flags/config";
|
||||
import { FeaturesRepository } from "@calcom/features/flags/features.repository";
|
||||
import { PermissionMapper } from "@calcom/features/pbac/domain/mappers/PermissionMapper";
|
||||
import { Resource, CrudAction } from "@calcom/features/pbac/domain/types/permission-registry";
|
||||
import { PermissionCheckService } from "@calcom/features/pbac/services/permission-check.service";
|
||||
import { prisma } from "@calcom/prisma";
|
||||
|
||||
import { buildLegacyRequest } from "@lib/buildLegacyCtx";
|
||||
|
||||
@@ -14,7 +18,7 @@ import SettingsLayoutAppDirClient from "./SettingsLayoutAppDirClient";
|
||||
|
||||
const getTeamFeatures = unstable_cache(
|
||||
async (teamId: number) => {
|
||||
const featuresRepository = new FeaturesRepository();
|
||||
const featuresRepository = new FeaturesRepository(prisma);
|
||||
return await featuresRepository.getTeamFeatures(teamId);
|
||||
},
|
||||
["team-features"],
|
||||
@@ -23,6 +27,15 @@ const getTeamFeatures = unstable_cache(
|
||||
}
|
||||
);
|
||||
|
||||
const getCachedResourcePermissions = unstable_cache(
|
||||
async (userId: number, teamId: number, resource: Resource) => {
|
||||
const permissionService = new PermissionCheckService();
|
||||
return permissionService.getResourcePermissions({ userId, teamId, resource });
|
||||
},
|
||||
["resource-permissions"],
|
||||
{ revalidate: 120 }
|
||||
);
|
||||
|
||||
export default async function SettingsLayoutAppDir(props: SettingsLayoutProps) {
|
||||
const session = await getServerSession({ req: buildLegacyRequest(await headers(), await cookies()) });
|
||||
const userId = session?.user?.id;
|
||||
@@ -31,20 +44,30 @@ export default async function SettingsLayoutAppDir(props: SettingsLayoutProps) {
|
||||
}
|
||||
|
||||
let teamFeatures: Record<number, TeamFeatures> | null = null;
|
||||
let canViewRoles = false;
|
||||
const orgId = session?.user?.profile?.organizationId ?? session?.user.org?.id;
|
||||
|
||||
// For now we only grab organization features but it would be nice to fetch these on the server side for specific team feature flags
|
||||
if (orgId) {
|
||||
const features = await getTeamFeatures(orgId);
|
||||
const [features, rolePermissions] = await Promise.all([
|
||||
getTeamFeatures(orgId),
|
||||
getCachedResourcePermissions(userId, orgId, Resource.Role),
|
||||
]);
|
||||
|
||||
if (features) {
|
||||
teamFeatures = {
|
||||
[orgId]: features,
|
||||
};
|
||||
|
||||
// Check if user has permission to read roles
|
||||
const roleActions = PermissionMapper.toActionMap(rolePermissions, Resource.Role);
|
||||
canViewRoles = roleActions[CrudAction.Read] ?? false;
|
||||
}
|
||||
}
|
||||
|
||||
return (
|
||||
<>
|
||||
<SettingsLayoutAppDirClient {...props} teamFeatures={teamFeatures ?? {}} />
|
||||
<SettingsLayoutAppDirClient {...props} teamFeatures={teamFeatures ?? {}} canViewRoles={canViewRoles} />
|
||||
</>
|
||||
);
|
||||
}
|
||||
|
||||
+7
@@ -0,0 +1,7 @@
|
||||
"use server";
|
||||
|
||||
import { revalidatePath } from "next/cache";
|
||||
|
||||
export async function revalidateSettingsAppearance() {
|
||||
revalidatePath("/settings/my-account/appearance");
|
||||
}
|
||||
+5
@@ -0,0 +1,5 @@
|
||||
import { SkeletonLoader } from "~/settings/my-account/appearance-skeleton";
|
||||
|
||||
export default function Loading() {
|
||||
return <SkeletonLoader />;
|
||||
}
|
||||
+32
-8
@@ -1,7 +1,15 @@
|
||||
import { createRouterCaller } from "app/_trpc/context";
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { getTranslate } from "app/_utils";
|
||||
import { cookies, headers } from "next/headers";
|
||||
import { redirect } from "next/navigation";
|
||||
|
||||
import SettingsHeader from "@calcom/features/settings/appDir/SettingsHeader";
|
||||
import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
|
||||
import { IS_SELF_HOSTED } from "@calcom/lib/constants";
|
||||
import hasKeyInMetadata from "@calcom/lib/hasKeyInMetadata";
|
||||
import { meRouter } from "@calcom/trpc/server/routers/viewer/me/_router";
|
||||
import { getCachedHasTeamPlan } from "@calcom/web/app/cache/membership";
|
||||
|
||||
import { buildLegacyRequest } from "@lib/buildLegacyCtx";
|
||||
|
||||
import AppearancePage from "~/settings/my-account/appearance-view";
|
||||
|
||||
@@ -15,13 +23,29 @@ export const generateMetadata = async () =>
|
||||
);
|
||||
|
||||
const Page = async () => {
|
||||
const t = await getTranslate();
|
||||
const session = await getServerSession({ req: buildLegacyRequest(await headers(), await cookies()) });
|
||||
const userId = session?.user?.id;
|
||||
const redirectUrl = "/auth/login?callbackUrl=/settings/my-account/appearance";
|
||||
|
||||
return (
|
||||
<SettingsHeader title={t("appearance")} description={t("appearance_description")}>
|
||||
<AppearancePage />
|
||||
</SettingsHeader>
|
||||
);
|
||||
if (!userId) {
|
||||
redirect(redirectUrl);
|
||||
}
|
||||
|
||||
const [meCaller, hasTeamPlan] = await Promise.all([
|
||||
createRouterCaller(meRouter),
|
||||
getCachedHasTeamPlan(userId),
|
||||
]);
|
||||
|
||||
const user = await meCaller.get();
|
||||
|
||||
if (!user) {
|
||||
redirect(redirectUrl);
|
||||
}
|
||||
const isCurrentUsernamePremium =
|
||||
user && hasKeyInMetadata(user, "isPremium") ? !!user.metadata.isPremium : false;
|
||||
const hasPaidPlan = IS_SELF_HOSTED ? true : hasTeamPlan?.hasTeamPlan || isCurrentUsernamePremium;
|
||||
|
||||
return <AppearancePage user={user} hasPaidPlan={hasPaidPlan} />;
|
||||
};
|
||||
|
||||
export default Page;
|
||||
|
||||
+5
@@ -0,0 +1,5 @@
|
||||
import { CalendarListContainerSkeletonLoader } from "@components/apps/CalendarListContainer";
|
||||
|
||||
export default function Loading() {
|
||||
return <CalendarListContainerSkeletonLoader />;
|
||||
}
|
||||
+13
-20
@@ -1,8 +1,8 @@
|
||||
import { createRouterCaller } from "app/_trpc/context";
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { getTranslate } from "app/_utils";
|
||||
|
||||
import SettingsHeader from "@calcom/features/settings/appDir/SettingsHeader";
|
||||
import { Button } from "@calcom/ui/components/button";
|
||||
import { appsRouter } from "@calcom/trpc/server/routers/viewer/apps/_router";
|
||||
import { calendarsRouter } from "@calcom/trpc/server/routers/viewer/calendars/_router";
|
||||
|
||||
import { CalendarListContainer } from "@components/apps/CalendarListContainer";
|
||||
|
||||
@@ -16,25 +16,18 @@ export const generateMetadata = async () =>
|
||||
);
|
||||
|
||||
const Page = async () => {
|
||||
const t = await getTranslate();
|
||||
|
||||
const AddCalendarButton = () => {
|
||||
return (
|
||||
<>
|
||||
<Button color="secondary" StartIcon="plus" href="/apps/categories/calendar">
|
||||
{t("add_calendar")}
|
||||
</Button>
|
||||
</>
|
||||
);
|
||||
};
|
||||
const [calendarsCaller, appsCaller] = await Promise.all([
|
||||
createRouterCaller(calendarsRouter),
|
||||
createRouterCaller(appsRouter),
|
||||
]);
|
||||
|
||||
const connectedCalendars = await calendarsCaller.connectedCalendars();
|
||||
const installedCalendars = await appsCaller.integrations({
|
||||
variant: "calendar",
|
||||
onlyInstalled: true,
|
||||
});
|
||||
return (
|
||||
<SettingsHeader
|
||||
title={t("calendars")}
|
||||
description={t("calendars_description")}
|
||||
CTA={<AddCalendarButton />}>
|
||||
<CalendarListContainer />
|
||||
</SettingsHeader>
|
||||
<CalendarListContainer connectedCalendars={connectedCalendars} installedCalendars={installedCalendars} />
|
||||
);
|
||||
};
|
||||
|
||||
|
||||
+1
-10
@@ -1,5 +1,4 @@
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { getTranslate } from "app/_utils";
|
||||
|
||||
import { ConferencingAppsViewWebWrapper } from "@calcom/atoms/connect/conferencing-apps/ConferencingAppsViewWebWrapper";
|
||||
|
||||
@@ -13,15 +12,7 @@ export const generateMetadata = async () =>
|
||||
);
|
||||
|
||||
const Page = async () => {
|
||||
const t = await getTranslate();
|
||||
|
||||
return (
|
||||
<ConferencingAppsViewWebWrapper
|
||||
title={t("conferencing")}
|
||||
description={t("conferencing_description")}
|
||||
add={t("add")}
|
||||
/>
|
||||
);
|
||||
return <ConferencingAppsViewWebWrapper />;
|
||||
};
|
||||
|
||||
export default Page;
|
||||
|
||||
+7
@@ -0,0 +1,7 @@
|
||||
"use server";
|
||||
|
||||
import { revalidatePath } from "next/cache";
|
||||
|
||||
export async function revalidateSettingsGeneral() {
|
||||
revalidatePath("/settings/my-account/general");
|
||||
}
|
||||
+5
@@ -0,0 +1,5 @@
|
||||
import { SkeletonLoader } from "~/settings/my-account/general-skeleton";
|
||||
|
||||
export default function Loading() {
|
||||
return <SkeletonLoader />;
|
||||
}
|
||||
+22
-14
@@ -1,10 +1,15 @@
|
||||
import { createRouterCaller } from "app/_trpc/context";
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { getTranslate } from "app/_utils";
|
||||
import { revalidatePath } from "next/cache";
|
||||
import { cookies, headers } from "next/headers";
|
||||
import { redirect } from "next/navigation";
|
||||
|
||||
import SettingsHeader from "@calcom/features/settings/appDir/SettingsHeader";
|
||||
import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
|
||||
import { meRouter } from "@calcom/trpc/server/routers/viewer/me/_router";
|
||||
import { getTravelSchedule } from "@calcom/web/app/cache/travelSchedule";
|
||||
|
||||
import GeneralQueryView from "~/settings/my-account/general-view";
|
||||
import { buildLegacyRequest } from "@lib/buildLegacyCtx";
|
||||
|
||||
import GeneralView from "~/settings/my-account/general-view";
|
||||
|
||||
export const generateMetadata = async () =>
|
||||
await _generateMetadata(
|
||||
@@ -16,17 +21,20 @@ export const generateMetadata = async () =>
|
||||
);
|
||||
|
||||
const Page = async () => {
|
||||
const t = await getTranslate();
|
||||
const revalidatePage = async () => {
|
||||
"use server";
|
||||
revalidatePath("settings/my-account/general");
|
||||
};
|
||||
const session = await getServerSession({ req: buildLegacyRequest(await headers(), await cookies()) });
|
||||
const userId = session?.user?.id;
|
||||
const redirectUrl = "/auth/login?callbackUrl=/settings/my-account/general";
|
||||
|
||||
return (
|
||||
<SettingsHeader title={t("general")} description={t("general_description")} borderInShellHeader={true}>
|
||||
<GeneralQueryView revalidatePage={revalidatePage} />
|
||||
</SettingsHeader>
|
||||
);
|
||||
if (!userId) {
|
||||
return redirect(redirectUrl);
|
||||
}
|
||||
|
||||
const meCaller = await createRouterCaller(meRouter);
|
||||
const [user, travelSchedules] = await Promise.all([meCaller.get(), getTravelSchedule(userId)]);
|
||||
if (!user) {
|
||||
redirect(redirectUrl);
|
||||
}
|
||||
return <GeneralView user={user} travelSchedules={travelSchedules ?? []} />;
|
||||
};
|
||||
|
||||
export default Page;
|
||||
|
||||
+2
-20
@@ -1,10 +1,6 @@
|
||||
import { _generateMetadata } from "app/_utils";
|
||||
import { getTranslate } from "app/_utils";
|
||||
|
||||
import SettingsHeader from "@calcom/features/settings/appDir/SettingsHeader";
|
||||
import CreateNewOutOfOfficeEntryButton from "@calcom/features/settings/outOfOffice/CreateNewOutOfOfficeEntryButton";
|
||||
import OutOfOfficeEntriesList from "@calcom/features/settings/outOfOffice/OutOfOfficeEntriesList";
|
||||
import { OutOfOfficeToggleGroup } from "@calcom/features/settings/outOfOffice/OutOfOfficeToggleGroup";
|
||||
|
||||
export const generateMetadata = async () =>
|
||||
await _generateMetadata(
|
||||
@@ -15,22 +11,8 @@ export const generateMetadata = async () =>
|
||||
"/settings/my-account/out-of-office"
|
||||
);
|
||||
|
||||
const Page = async () => {
|
||||
const t = await getTranslate();
|
||||
|
||||
return (
|
||||
<SettingsHeader
|
||||
title={t("out_of_office")}
|
||||
description={t("out_of_office_description")}
|
||||
CTA={
|
||||
<div className="flex gap-2">
|
||||
<OutOfOfficeToggleGroup />
|
||||
<CreateNewOutOfOfficeEntryButton data-testid="add_entry_ooo" />
|
||||
</div>
|
||||
}>
|
||||
<OutOfOfficeEntriesList />
|
||||
</SettingsHeader>
|
||||
);
|
||||
const Page = () => {
|
||||
return <OutOfOfficeEntriesList />;
|
||||
};
|
||||
|
||||
export default Page;
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user